Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-23486

MSI Package: Remove the entire C:\Program Files\Jenkins during the uninstallation

      Observations:
      Uninstall Jenkins and C:\Program Files\Jenkins is left full of files. Even after reboot

      What I expected:
      The Jenkins folder should be deleted

          [JENKINS-23486] MSI Package: Remove the entire C:\Program Files\Jenkins during the uninstallation

          Oleg Nenashev added a comment -

          The issue should be assigned to JENKINS project (native windows package)

          Oleg Nenashev added a comment - The issue should be assigned to JENKINS project (native windows package)

          Daniel Beck added a comment -

          Is it really an expectation on Windows that uninstalling an application removes all user data?

          Daniel Beck added a comment - Is it really an expectation on Windows that uninstalling an application removes all user data?

          Mark Waite added a comment -

          Typically Windows installers do not remove user data. The removal process most familiar to me is that all files registered through the MSI install process are removed by the uninstall process. User data does not usually exist at initial install, so it cannot be registered with the MSI install process.

          However, they also do not place user data in the "Program Files" structure. It is more common that "Program Files" is just for the executables, so user data is not there to be removed.

          I'm not sure what the Jenkins Windows installer does, though I assume it places some user data in the C:\Program Files\Jenkins directory (based on this bug report).

          Mark Waite added a comment - Typically Windows installers do not remove user data. The removal process most familiar to me is that all files registered through the MSI install process are removed by the uninstall process. User data does not usually exist at initial install, so it cannot be registered with the MSI install process. However, they also do not place user data in the "Program Files" structure. It is more common that "Program Files" is just for the executables, so user data is not there to be removed. I'm not sure what the Jenkins Windows installer does, though I assume it places some user data in the C:\Program Files\Jenkins directory (based on this bug report).

          Oleg Nenashev added a comment - - edited

          jenkins.wxs file does not define specific uninstaller handlers.
          See https://github.com/jenkinsci/jenkins/blob/master/msi/jenkins.wxs

          It means that only explicitly defined package contents (e.g. jenkins.exe) will be deleted.

          I'm not sure if this issue is a bug or an improvement, but Windows apps usually ask if the user wants to delete created files. After that, they forget to clean up their garbage

          Oleg Nenashev added a comment - - edited jenkins.wxs file does not define specific uninstaller handlers. See https://github.com/jenkinsci/jenkins/blob/master/msi/jenkins.wxs It means that only explicitly defined package contents (e.g. jenkins.exe) will be deleted. I'm not sure if this issue is a bug or an improvement, but Windows apps usually ask if the user wants to delete created files. After that, they forget to clean up their garbage

          Hi
          Thanks for the reply
          Normally user data is stored under c:\users\username\AppData\AppName etc
          It seems nicer to me if the uninstall would remove the "C:\Program Files\Jenkins" folder. Or maybe it could have an option as part of the uninstaller to ask the user the question?

          Thanks

          Jonathan Grant added a comment - Hi Thanks for the reply Normally user data is stored under c:\users\username\AppData\AppName etc It seems nicer to me if the uninstall would remove the "C:\Program Files\Jenkins" folder. Or maybe it could have an option as part of the uninstaller to ask the user the question? Thanks

          Oleg Nenashev added a comment -

          Modified the issue's description.

          Oleg Nenashev added a comment - Modified the issue's description.

          Alex Earl added a comment -

          There are log files and such that are in the installation directory, these will not be removed during uninstall because they are not created by the install. I think this is pretty standard.

          Alex Earl added a comment - There are log files and such that are in the installation directory, these will not be removed during uninstall because they are not created by the install. I think this is pretty standard.

            slide_o_mix Alex Earl
            jgrant Jonathan Grant
            Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

              Created:
              Updated:
              Resolved: