Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-23614

URL isn't escaped properly (leads to an 404 error).

    XMLWordPrintable

Details

    Description

      When I use special characters in a multi-configuration build, I always end up getting a 404 error.
      I use user-defined axis with following values:

      the name is: django.
      I can build the project with these configurations but when I go to the Project and select the configuration, I get a 404 error (see attachment, the second axis (Python), doesn't make a different).

      I think the commas break the URL but I'm not sure. I can't change the name of the axis because the define the exaction version (for instance, `=>1.5,1.6` means that every version that is new that 1.5 but older than 1.6 is allowed (e.g 1.5, 1.5.1, ...)).

      Attachments

        Activity

          matt3o12 Matteo Kloiber added a comment - - edited This issue is sponsored!
          oleg_nenashev Oleg Nenashev added a comment -

          Fixed the component

          oleg_nenashev Oleg Nenashev added a comment - Fixed the component

          Looking into code ',' and '=' are problematic in axis name and ',' is problematic in value. I will propose a fix to disallow given characters.

          olivergondza Oliver Gondža added a comment - Looking into code ',' and '=' are problematic in axis name and ',' is problematic in value. I will propose a fix to disallow given characters.
          olivergondza Oliver Gondža added a comment - Proposing fix https://github.com/jenkinsci/matrix-project-plugin/pull/14 .

          Code changed in jenkins
          User: Oliver Gondža
          Path:
          src/main/java/hudson/matrix/AxisDescriptor.java
          src/main/java/hudson/matrix/MatrixProject.java
          src/main/java/hudson/matrix/TextAxis.java
          src/main/resources/hudson/matrix/Messages.properties
          src/test/java/hudson/matrix/AxisDescriptorTest.java
          http://jenkins-ci.org/commit/matrix-project-plugin/f10684402704bb0cda1b758f0e0ecf502d442098
          Log:
          [FIXED JENKINS-23614] URL isn't escaped properly (leads to an 404 error)

          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Oliver Gondža Path: src/main/java/hudson/matrix/AxisDescriptor.java src/main/java/hudson/matrix/MatrixProject.java src/main/java/hudson/matrix/TextAxis.java src/main/resources/hudson/matrix/Messages.properties src/test/java/hudson/matrix/AxisDescriptorTest.java http://jenkins-ci.org/commit/matrix-project-plugin/f10684402704bb0cda1b758f0e0ecf502d442098 Log: [FIXED JENKINS-23614] URL isn't escaped properly (leads to an 404 error)

          Code changed in jenkins
          User: Oliver Gondža
          Path:
          src/test/java/hudson/matrix/AxisTest.java
          http://jenkins-ci.org/commit/matrix-project-plugin/8600edd99ed62ae688c695153af429c263e1688f
          Log:
          JENKINS-23614 Add more tests

          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Oliver Gondža Path: src/test/java/hudson/matrix/AxisTest.java http://jenkins-ci.org/commit/matrix-project-plugin/8600edd99ed62ae688c695153af429c263e1688f Log: JENKINS-23614 Add more tests

          Code changed in jenkins
          User: Oliver Gondža
          Path:
          src/main/java/hudson/matrix/AxisDescriptor.java
          src/main/java/hudson/matrix/JDKAxis.java
          src/main/java/hudson/matrix/LabelExpAxis.java
          src/main/java/hudson/matrix/MatrixProject.java
          src/main/java/hudson/matrix/TextAxis.java
          src/main/resources/hudson/matrix/Messages.properties
          src/test/java/hudson/matrix/AxisDescriptorTest.java
          src/test/java/hudson/matrix/AxisTest.java
          http://jenkins-ci.org/commit/matrix-project-plugin/1bdbe10c552928ce2547df3fc180c1c5db4d9588
          Log:
          Merge pull request #14 from olivergondza/validate-axes

          [FIXED JENKINS-9277 JENKINS-25448 JENKINS-23614] Disallow special chars in axis names and values

          Compare: https://github.com/jenkinsci/matrix-project-plugin/compare/6be15fe17421...1bdbe10c5529

          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Oliver Gondža Path: src/main/java/hudson/matrix/AxisDescriptor.java src/main/java/hudson/matrix/JDKAxis.java src/main/java/hudson/matrix/LabelExpAxis.java src/main/java/hudson/matrix/MatrixProject.java src/main/java/hudson/matrix/TextAxis.java src/main/resources/hudson/matrix/Messages.properties src/test/java/hudson/matrix/AxisDescriptorTest.java src/test/java/hudson/matrix/AxisTest.java http://jenkins-ci.org/commit/matrix-project-plugin/1bdbe10c552928ce2547df3fc180c1c5db4d9588 Log: Merge pull request #14 from olivergondza/validate-axes [FIXED JENKINS-9277 JENKINS-25448 JENKINS-23614] Disallow special chars in axis names and values Compare: https://github.com/jenkinsci/matrix-project-plugin/compare/6be15fe17421...1bdbe10c5529

          People

            olivergondza Oliver Gondža
            matt3o12 Matteo Kloiber
            Votes:
            1 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: