[JENKINS-23772] Percent for image width attribute - Jenkins Jira

XML

Word

Printable

Details

Type: Improvement
Status: Closed (View Workflow)
Priority: Major
Resolution: Fixed
Component/s: image-gallery-plugin
Labels:
None

Similar Issues:

Show

Description

Allow responsive value for "Image width" attribute. Eg.: "80%".
Plugin now allow only number in this filed.

Attachments

Activity

Ascending order - Click to sort in descending order

Bruno P. Kinoshita added a comment - 2015-09-14 00:22

Good idea. Implementing it today in the plug-in code

Will try my best to keep backward compatibility with some XStream-fu.

Thanks for reporting the issue.
Bruno

Bruno P. Kinoshita added a comment - 2015-09-14 00:22 Good idea. Implementing it today in the plug-in code Will try my best to keep backward compatibility with some XStream-fu. Thanks for reporting the issue. Bruno

SCM/JIRA link daemon added a comment - 2015-09-14 01:19

Code changed in jenkins
User: Bruno P. Kinoshita
Path:
src/main/java/org/jenkinsci/plugins/imagegallery/AbstractArchivedImagesGallery.java
src/main/java/org/jenkinsci/plugins/imagegallery/ImageGallery.java
src/main/java/org/jenkinsci/plugins/imagegallery/comparative/ComparativeArchivedImagesGallery.java
src/main/java/org/jenkinsci/plugins/imagegallery/comparative/ComparativeImagesGalleryBuildAction.java
src/main/java/org/jenkinsci/plugins/imagegallery/comparative/InFolderComparativeArchivedImagesGallery.java
src/main/java/org/jenkinsci/plugins/imagegallery/comparative/MultipleFolderComparativeArchivedImagesGallery.java
src/main/java/org/jenkinsci/plugins/imagegallery/imagegallery/ArchivedImagesGallery.java
src/main/java/org/jenkinsci/plugins/imagegallery/imagegallery/ArchivedImagesGalleryBuildAction.java
http://jenkins-ci.org/commit/image-gallery-plugin/d3512f0bad0df74011a5b3f9df8de7ee3ae1ec63
Log:
~~JENKINS-23772~~ Use String for image width rather than ints

SCM/JIRA link daemon added a comment - 2015-09-14 01:19 Code changed in jenkins User: Bruno P. Kinoshita Path: src/main/java/org/jenkinsci/plugins/imagegallery/AbstractArchivedImagesGallery.java src/main/java/org/jenkinsci/plugins/imagegallery/ImageGallery.java src/main/java/org/jenkinsci/plugins/imagegallery/comparative/ComparativeArchivedImagesGallery.java src/main/java/org/jenkinsci/plugins/imagegallery/comparative/ComparativeImagesGalleryBuildAction.java src/main/java/org/jenkinsci/plugins/imagegallery/comparative/InFolderComparativeArchivedImagesGallery.java src/main/java/org/jenkinsci/plugins/imagegallery/comparative/MultipleFolderComparativeArchivedImagesGallery.java src/main/java/org/jenkinsci/plugins/imagegallery/imagegallery/ArchivedImagesGallery.java src/main/java/org/jenkinsci/plugins/imagegallery/imagegallery/ArchivedImagesGalleryBuildAction.java http://jenkins-ci.org/commit/image-gallery-plugin/d3512f0bad0df74011a5b3f9df8de7ee3ae1ec63 Log: JENKINS-23772 Use String for image width rather than ints

SCM/JIRA link daemon added a comment - 2015-09-14 07:21

Code changed in jenkins
User: Bruno P. Kinoshita
Path:
src/main/java/org/jenkinsci/plugins/imagegallery/AbstractArchivedImagesGallery.java
src/main/java/org/jenkinsci/plugins/imagegallery/ImageGallery.java
src/main/java/org/jenkinsci/plugins/imagegallery/comparative/ComparativeArchivedImagesGallery.java
src/main/java/org/jenkinsci/plugins/imagegallery/comparative/ComparativeImagesGalleryBuildAction.java
src/main/java/org/jenkinsci/plugins/imagegallery/comparative/InFolderComparativeArchivedImagesGallery.java
src/main/java/org/jenkinsci/plugins/imagegallery/comparative/MultipleFolderComparativeArchivedImagesGallery.java
src/main/java/org/jenkinsci/plugins/imagegallery/imagegallery/ArchivedImagesGallery.java
src/main/java/org/jenkinsci/plugins/imagegallery/imagegallery/ArchivedImagesGalleryBuildAction.java
http://jenkins-ci.org/commit/image-gallery-plugin/a7eb7fd7b3e602c05e4da2a2a0896ffa695c6bf0
Log:
~~JENKINS-23772~~ Use String for image width rather than ints

SCM/JIRA link daemon added a comment - 2015-09-14 07:21 Code changed in jenkins User: Bruno P. Kinoshita Path: src/main/java/org/jenkinsci/plugins/imagegallery/AbstractArchivedImagesGallery.java src/main/java/org/jenkinsci/plugins/imagegallery/ImageGallery.java src/main/java/org/jenkinsci/plugins/imagegallery/comparative/ComparativeArchivedImagesGallery.java src/main/java/org/jenkinsci/plugins/imagegallery/comparative/ComparativeImagesGalleryBuildAction.java src/main/java/org/jenkinsci/plugins/imagegallery/comparative/InFolderComparativeArchivedImagesGallery.java src/main/java/org/jenkinsci/plugins/imagegallery/comparative/MultipleFolderComparativeArchivedImagesGallery.java src/main/java/org/jenkinsci/plugins/imagegallery/imagegallery/ArchivedImagesGallery.java src/main/java/org/jenkinsci/plugins/imagegallery/imagegallery/ArchivedImagesGalleryBuildAction.java http://jenkins-ci.org/commit/image-gallery-plugin/a7eb7fd7b3e602c05e4da2a2a0896ffa695c6bf0 Log: JENKINS-23772 Use String for image width rather than ints

SCM/JIRA link daemon added a comment - 2015-09-14 09:14

Code changed in jenkins
User: Bruno P. Kinoshita
Path:
src/main/java/org/jenkinsci/plugins/imagegallery/comparative/ComparativeImagesGalleryBuildAction.java
src/main/java/org/jenkinsci/plugins/imagegallery/comparative/InFolderComparativeArchivedImagesGallery.java
src/main/java/org/jenkinsci/plugins/imagegallery/comparative/MultipleFolderComparativeArchivedImagesGallery.java
src/main/java/org/jenkinsci/plugins/imagegallery/imagegallery/ArchivedImagesGallery.java
src/main/java/org/jenkinsci/plugins/imagegallery/imagegallery/ArchivedImagesGalleryBuildAction.java
src/main/resources/org/jenkinsci/plugins/imagegallery/comparative/ComparativeImagesGalleryBuildAction/filetree.jelly
src/main/resources/org/jenkinsci/plugins/imagegallery/comparative/ComparativeImagesGalleryBuildAction/summary.jelly
src/main/resources/org/jenkinsci/plugins/imagegallery/imagegallery/ArchivedImagesGalleryBuildAction/summary.jelly
src/main/resources/org/jenkinsci/plugins/imagegallery/imagegallery/ComparativeArchivedImagesGalleryBuildAction/summary.jelly
http://jenkins-ci.org/commit/image-gallery-plugin/8128c33bc10535cf801ede131b6f188265da9736
Log:
[FIXED JENKINS-23772] Fix jelly views

SCM/JIRA link daemon added a comment - 2015-09-14 09:14 Code changed in jenkins User: Bruno P. Kinoshita Path: src/main/java/org/jenkinsci/plugins/imagegallery/comparative/ComparativeImagesGalleryBuildAction.java src/main/java/org/jenkinsci/plugins/imagegallery/comparative/InFolderComparativeArchivedImagesGallery.java src/main/java/org/jenkinsci/plugins/imagegallery/comparative/MultipleFolderComparativeArchivedImagesGallery.java src/main/java/org/jenkinsci/plugins/imagegallery/imagegallery/ArchivedImagesGallery.java src/main/java/org/jenkinsci/plugins/imagegallery/imagegallery/ArchivedImagesGalleryBuildAction.java src/main/resources/org/jenkinsci/plugins/imagegallery/comparative/ComparativeImagesGalleryBuildAction/filetree.jelly src/main/resources/org/jenkinsci/plugins/imagegallery/comparative/ComparativeImagesGalleryBuildAction/summary.jelly src/main/resources/org/jenkinsci/plugins/imagegallery/imagegallery/ArchivedImagesGalleryBuildAction/summary.jelly src/main/resources/org/jenkinsci/plugins/imagegallery/imagegallery/ComparativeArchivedImagesGalleryBuildAction/summary.jelly http://jenkins-ci.org/commit/image-gallery-plugin/8128c33bc10535cf801ede131b6f188265da9736 Log: [FIXED JENKINS-23772] Fix jelly views

Balint Kovacs added a comment - 2015-09-15 07:47

Great, thank you!

Balint Kovacs added a comment - 2015-09-15 07:47 Great, thank you!

Bruno P. Kinoshita added a comment - 2015-09-17 05:03

Fixed in 1.2

Bruno P. Kinoshita added a comment - 2015-09-17 05:03 Fixed in 1.2

People

Assignee:: Bruno P. Kinoshita

Reporter:: Balint Kovacs

Votes:: 0 Vote for this issue

Watchers:: 3 Start watching this issue

Dates

Created:: 2014-07-14 09:12

Updated:: 2015-09-17 05:03

Resolved:: 2015-09-14 09:14