Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-24170

Provide icon spec/class alternative to the getIconFileName() method on Action/ManagementLink

XMLWordPrintable

    • Icon: Improvement Improvement
    • Resolution: Fixed
    • Icon: Major Major
    • core

      This will help us eliminate the use of file names for icons and instead move to a CSS class spec type model.

      I think this should be done by adding a new interface in the icons-set module (located in the icon-shim plugin repo https://github.com/jenkinsci/icon-shim-plugin). This will allow plugins maintain backward compatibility with older versions of Jenkins core.

      e.g.

       
      interface IconSpec {
          String getIconClassName();
      }
      

      Then... plugin extension points that implement/extend Action/ManagementLink can also implement this interface.

      Then... jelly scripts that use 'iconFileName' (e.g. core/src/main/resources/jenkins/model/Jenkins/manage.jelly) can be changed to use 'iconClassName', falling back to 'iconFileName' if 'iconClassName' not available.

            tfennelly Tom FENNELLY
            tfennelly Tom FENNELLY
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated:
              Resolved: