Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-24256

Fail build for missing / erroneous valgrind publisher XMLs

XMLWordPrintable

    • Icon: Improvement Improvement
    • Resolution: Fixed
    • Icon: Minor Minor
    • valgrind-plugin
    • None

      I've been using the valgrind publisher in an environment where
      valgrind under some circumstances is not executed correctly leading to either missing, or malformed xml files.

      Under normal conditions, valgrind reports errors for the project rather rarely (and the trend usually is at 0 for several builds).

      This leads to a situation where errors can be missed, because it's not
      easily visible if valgrind reported 0 errors, or if the publisher failed to read the valgrind output.

      Hence, I've got a suggestion to improve the publisher plugin:
      Would it be possible to add an option which fails the build in case no valgrind xml reports were found, or if one or more reports couldn't be parsed.

          [JENKINS-24256] Fail build for missing / erroneous valgrind publisher XMLs

          Johannes Ohlemacher added a comment -

          Sounds reasonable and should be easy to integrate. I am pretty busy right now, but i will try to look into it within the next couple of days.

          Johannes Ohlemacher added a comment - Sounds reasonable and should be easy to integrate. I am pretty busy right now, but i will try to look into it within the next couple of days.

          SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Johannes Ohlemacher
          Path:
          src/main/java/org/jenkinsci/plugins/valgrind/ValgrindPublisher.java
          src/main/java/org/jenkinsci/plugins/valgrind/config/ValgrindPublisherConfig.java
          src/main/resources/org/jenkinsci/plugins/valgrind/ValgrindPublisher/config.jelly
          http://jenkins-ci.org/commit/valgrind-plugin/9ec3eb12b292923e40b59585791817d39ec3cee7
          Log:
          JENKINS-24256: added option to fail build on missing xml reports

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Johannes Ohlemacher Path: src/main/java/org/jenkinsci/plugins/valgrind/ValgrindPublisher.java src/main/java/org/jenkinsci/plugins/valgrind/config/ValgrindPublisherConfig.java src/main/resources/org/jenkinsci/plugins/valgrind/ValgrindPublisher/config.jelly http://jenkins-ci.org/commit/valgrind-plugin/9ec3eb12b292923e40b59585791817d39ec3cee7 Log: JENKINS-24256 : added option to fail build on missing xml reports

          SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Johannes Ohlemacher
          Path:
          src/main/java/org/jenkinsci/plugins/valgrind/ValgrindPublisher.java
          src/main/java/org/jenkinsci/plugins/valgrind/ValgrindResult.java
          src/main/java/org/jenkinsci/plugins/valgrind/config/ValgrindPublisherConfig.java
          src/main/java/org/jenkinsci/plugins/valgrind/model/ValgrindReport.java
          src/main/java/org/jenkinsci/plugins/valgrind/parser/ValgrindParserResult.java
          src/main/java/org/jenkinsci/plugins/valgrind/parser/ValgrindSaxParser.java
          src/main/java/org/jenkinsci/plugins/valgrind/util/ValgrindEvaluator.java
          src/main/resources/org/jenkinsci/plugins/valgrind/ValgrindPublisher/config.jelly
          http://jenkins-ci.org/commit/valgrind-plugin/66a39a978b63b090528a78934d304e9731fd7207
          Log:
          JENKINS-24256: added option to fail build on invalid/malformed xml
          reports

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Johannes Ohlemacher Path: src/main/java/org/jenkinsci/plugins/valgrind/ValgrindPublisher.java src/main/java/org/jenkinsci/plugins/valgrind/ValgrindResult.java src/main/java/org/jenkinsci/plugins/valgrind/config/ValgrindPublisherConfig.java src/main/java/org/jenkinsci/plugins/valgrind/model/ValgrindReport.java src/main/java/org/jenkinsci/plugins/valgrind/parser/ValgrindParserResult.java src/main/java/org/jenkinsci/plugins/valgrind/parser/ValgrindSaxParser.java src/main/java/org/jenkinsci/plugins/valgrind/util/ValgrindEvaluator.java src/main/resources/org/jenkinsci/plugins/valgrind/ValgrindPublisher/config.jelly http://jenkins-ci.org/commit/valgrind-plugin/66a39a978b63b090528a78934d304e9731fd7207 Log: JENKINS-24256 : added option to fail build on invalid/malformed xml reports

          Christian Fetzer added a comment -

          Thanks for the quick implementation! I've tested v0.21 confirming that it behaves as intended.

          Christian Fetzer added a comment - Thanks for the quick implementation! I've tested v0.21 confirming that it behaves as intended.

          Johannes Ohlemacher added a comment - - edited

          fixed in version 0.21, added two new publisher options:

          • fail build on missing reports
          • fail build on invalid/malformed reports

          @Christian: Thanks for reporting and testing!

          Johannes Ohlemacher added a comment - - edited fixed in version 0.21, added two new publisher options: fail build on missing reports fail build on invalid/malformed reports @Christian: Thanks for reporting and testing!

            existence Johannes Ohlemacher
            fetzerch Christian Fetzer
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated:
              Resolved: