Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-24316

Plugin icons do not show in left navigation: duplicate slash before plugin path in image URL

      Since the update to 1.576, the icons generated by plugins on the left navigation bar no longer display. This is throughout the whole userinterface: homepage, job page,... (everywhere).

      The reason is that the image src URL is generated as "//plugin/...", which makes the browser resolve "plugin" as hostname. URLs starting with "//" mean "same protocol".

          [JENKINS-24316] Plugin icons do not show in left navigation: duplicate slash before plugin path in image URL

          Tested with latest git and the images are now properly displayed including the /static/xxxx prefix to help with caching.

          Thanks.

          Richard Mortimer added a comment - Tested with latest git and the images are now properly displayed including the /static/xxxx prefix to help with caching. Thanks.

          Shannon Kerr added a comment -

          I can confirm the same. My sandbox Jenkins is now functioning normally. Thanks for the quick fix implementation tfennelly. We all succumb to late night work bugs every once in a while.

          Shannon Kerr added a comment - I can confirm the same. My sandbox Jenkins is now functioning normally. Thanks for the quick fix implementation tfennelly . We all succumb to late night work bugs every once in a while.

          Uwe Schindler added a comment -

          Hi,
          replaced my WAR from the Ubuntu/Debian package in /usr/share/jenkins by the latest snapshot build -> works fine!
          Thanks!

          Uwe Schindler added a comment - Hi, replaced my WAR from the Ubuntu/Debian package in /usr/share/jenkins by the latest snapshot build -> works fine! Thanks!

          Code changed in jenkins
          User: tfennelly
          Path:
          core/src/main/resources/lib/layout/task.jelly
          test/src/test/java/lib/layout/IconTest.java
          test/src/test/resources/lib/layout/IconTest/01_testIcons.jelly
          test/src/test/resources/lib/layout/IconTest/03_testTask.jelly
          http://jenkins-ci.org/commit/jenkins/830a5e7f618a53a4ff3d1cad1127efc5fcc47601
          Log:
          [FIXED JENKINS-24316] Fixed unknown task icon src path construction

          (cherry picked from commit 286337ea39c0db6e056af61e616736bafc5f0581)

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: tfennelly Path: core/src/main/resources/lib/layout/task.jelly test/src/test/java/lib/layout/IconTest.java test/src/test/resources/lib/layout/IconTest/01_testIcons.jelly test/src/test/resources/lib/layout/IconTest/03_testTask.jelly http://jenkins-ci.org/commit/jenkins/830a5e7f618a53a4ff3d1cad1127efc5fcc47601 Log: [FIXED JENKINS-24316] Fixed unknown task icon src path construction (cherry picked from commit 286337ea39c0db6e056af61e616736bafc5f0581)

          Code changed in jenkins
          User: tfennelly
          Path:
          core/src/main/resources/lib/layout/task.jelly
          http://jenkins-ci.org/commit/jenkins/5b805fa16e240e3657a7f263eeef11281a393efa
          Log:
          Readd static resource path for task icons JENKINS-24316

          Missed this in previous commit - bad idea making even small changes late at night

          (cherry picked from commit 3daa6a97b02635d672e7646e83edb93abf50db06)

          Compare: https://github.com/jenkinsci/jenkins/compare/bce92ec53dde...5b805fa16e24

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: tfennelly Path: core/src/main/resources/lib/layout/task.jelly http://jenkins-ci.org/commit/jenkins/5b805fa16e240e3657a7f263eeef11281a393efa Log: Readd static resource path for task icons JENKINS-24316 Missed this in previous commit - bad idea making even small changes late at night (cherry picked from commit 3daa6a97b02635d672e7646e83edb93abf50db06) Compare: https://github.com/jenkinsci/jenkins/compare/bce92ec53dde...5b805fa16e24

          Code changed in jenkins
          User: Daniel Beck
          Path:
          changelog.html
          http://jenkins-ci.org/commit/jenkins/4c0cfe40c9ebbea81bf2b8a6931cda3513be1bfe
          Log:
          Noting RC merge of JENKINS-24316, JENKINS-24317

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Daniel Beck Path: changelog.html http://jenkins-ci.org/commit/jenkins/4c0cfe40c9ebbea81bf2b8a6931cda3513be1bfe Log: Noting RC merge of JENKINS-24316 , JENKINS-24317

          Daniel Beck added a comment -

          The fix will be in 1.577, scheduled to be released this weekend or so.

          Daniel Beck added a comment - The fix will be in 1.577, scheduled to be released this weekend or so.

          dogfood added a comment -

          Integrated in jenkins_main_trunk #3646
          [FIXED JENKINS-24316] Fixed unknown task icon src path construction (Revision 830a5e7f618a53a4ff3d1cad1127efc5fcc47601)
          Readd static resource path for task icons JENKINS-24316 (Revision 5b805fa16e240e3657a7f263eeef11281a393efa)

          Result = SUCCESS
          Jesse Glick : 830a5e7f618a53a4ff3d1cad1127efc5fcc47601
          Files :

          • test/src/test/resources/lib/layout/IconTest/03_testTask.jelly
          • test/src/test/java/lib/layout/IconTest.java
          • core/src/main/resources/lib/layout/task.jelly
          • test/src/test/resources/lib/layout/IconTest/01_testIcons.jelly

          Jesse Glick : 5b805fa16e240e3657a7f263eeef11281a393efa
          Files :

          • core/src/main/resources/lib/layout/task.jelly

          dogfood added a comment - Integrated in jenkins_main_trunk #3646 [FIXED JENKINS-24316] Fixed unknown task icon src path construction (Revision 830a5e7f618a53a4ff3d1cad1127efc5fcc47601) Readd static resource path for task icons JENKINS-24316 (Revision 5b805fa16e240e3657a7f263eeef11281a393efa) Result = SUCCESS Jesse Glick : 830a5e7f618a53a4ff3d1cad1127efc5fcc47601 Files : test/src/test/resources/lib/layout/IconTest/03_testTask.jelly test/src/test/java/lib/layout/IconTest.java core/src/main/resources/lib/layout/task.jelly test/src/test/resources/lib/layout/IconTest/01_testIcons.jelly Jesse Glick : 5b805fa16e240e3657a7f263eeef11281a393efa Files : core/src/main/resources/lib/layout/task.jelly

          Hi, I've found that some plugin ( config-file-provider ) , starts suffering from similar trouble ( rendering icons by \jenkins\core\src\main\resources\lib\layout\layout.jelly in main-panel-content ). if you can classify it for jenkins issue , or plugin issue, please, it would be nice

          Denis Shvedchenko added a comment - Hi, I've found that some plugin ( config-file-provider ) , starts suffering from similar trouble ( rendering icons by \jenkins\core\src\main\resources\lib\layout\layout.jelly in main-panel-content ). if you can classify it for jenkins issue , or plugin issue, please, it would be nice

          Daniel Beck added a comment -

          dshvedchenko: If this occurs in 1.576, we don't care since there was a fix since. If it occurs in 1.577, please file a new issue against core and the plugin it occurs in as components, we'll sort it out. Make sure to use the label "user-experience".

          Daniel Beck added a comment - dshvedchenko : If this occurs in 1.576, we don't care since there was a fix since. If it occurs in 1.577, please file a new issue against core and the plugin it occurs in as components, we'll sort it out. Make sure to use the label "user-experience".

            tfennelly Tom FENNELLY
            thetaphi Uwe Schindler
            Votes:
            12 Vote for this issue
            Watchers:
            14 Start watching this issue

              Created:
              Updated:
              Resolved: