Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-2461

Inconsistency in SVN error handling.

    XMLWordPrintable

    Details

    • Type: Patch
    • Status: Closed (View Workflow)
    • Priority: Critical
    • Resolution: Fixed
    • Component/s: subversion-plugin
    • Labels:
      None
    • Environment:
      Platform: All, OS: All
    • Similar Issues:

      Description

      Current Problem
      ---------------

      The current SVN update process involves two separate requests to the SVN
      repository. The first request updates the workspace, while the second produces
      the change log.

      If the first request fails then the build is marked as failed and processing
      ceases. However, if the change log request fails then the build continues and an
      empty change log is created. This is leading to confusion amongst a some end
      users as it is not obvious as to what changes are included in the build. The
      exact changes can only be identified by examining the console output which
      produces the output in attachment current-output.txt.

      Proposed Solution
      -----------------
      The ideal solution would be for this scenario to be treated in the same way as a
      failure to the workspace update, the result being a failed build. The attached
      patch contains a minor modification to the SubversionChangeLogBuilder in order
      to handle this scenario.

      If this solution is considered by the community to be too harsh then I would
      appreciate a compromise solution where the behaviour was configurable, giving
      the end user the ultimate choice as to how to handle this failure scenario.

        Attachments

          Activity

          Hide
          nigel_garner nigel_garner added a comment -

          Created an attachment (id=401)
          Proposed patch for issue

          Show
          nigel_garner nigel_garner added a comment - Created an attachment (id=401) Proposed patch for issue
          Hide
          nigel_garner nigel_garner added a comment -

          Created an attachment (id=402)
          Current behaviour example

          Show
          nigel_garner nigel_garner added a comment - Created an attachment (id=402) Current behaviour example
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in hudson
          User: : kohsuke
          Path:
          trunk/hudson/main/core/src/main/java/hudson/scm/SubversionChangeLogBuilder.java
          trunk/www/changelog.html
          http://fisheye4.cenqua.com/changelog/hudson/?cs=14395
          Log:
          [FIXED JENKINS-2461] Applied a slightly modified patch. Fixed in 1.274.

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in hudson User: : kohsuke Path: trunk/hudson/main/core/src/main/java/hudson/scm/SubversionChangeLogBuilder.java trunk/www/changelog.html http://fisheye4.cenqua.com/changelog/hudson/?cs=14395 Log: [FIXED JENKINS-2461] Applied a slightly modified patch. Fixed in 1.274.

            People

            Assignee:
            Unassigned Unassigned
            Reporter:
            nigel_garner nigel_garner
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved: