Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-24622

Upstream jobs have disapeared from job main page

      Since the version 2.17 upstream jobs have disappeared from job main page when paramterized-trigger plugin is used in a build step.

        1. screenshot-1.jpg
          screenshot-1.jpg
          46 kB
        2. screenshot-2.jpg
          screenshot-2.jpg
          27 kB
        3. screenshot-3.jpg
          screenshot-3.jpg
          22 kB
        4. screenshot-4.jpg
          screenshot-4.jpg
          23 kB

          [JENKINS-24622] Upstream jobs have disapeared from job main page

          Sylvain C. added a comment -

          Also since 2.17 the option "Block build when upstream project is building" doesn't work anymore when parameterized-trigger plugin is used in a build step.

          Sylvain C. added a comment - Also since 2.17 the option "Block build when upstream project is building" doesn't work anymore when parameterized-trigger plugin is used in a build step.

          ikedam added a comment -

          I started to maintain parameterized-trigger-plugin since 2.19,
          and I'm not sure the behavior you expect.
          I have to see how it worked before you upgrade parameterized-trigger plugin.

          • From what version did you upgrade parameterized-trigger-plugin?
          • Can you downgrade the plugin and attach the screenshot with that version?
          • Used in a build step, a upstream build is always running when triggered a downstream build. What's your expecting behavior with "Block build when upstream project is building"?
          • The latest version of parameterized-trigger-plugin is 2.25, and 2.17 is old version. On the other hand, Jenkins 1.565.1 is the latest LTS. That sounds strange to me.
            • Do you mean you found the problems in the latest parameterized-trigger-plugin and you found they occur not with 2.16 but with 2.17?
            • Let me know if you also upgraded Jenkins core.
              • As far as I know, parameterized-trigger-plugin doesn't handle displaying upstream projects nor "Block build when upstream project is building"?. They might be caused by upgrade of Jenkins core.

          ikedam added a comment - I started to maintain parameterized-trigger-plugin since 2.19, and I'm not sure the behavior you expect. I have to see how it worked before you upgrade parameterized-trigger plugin. From what version did you upgrade parameterized-trigger-plugin? Can you downgrade the plugin and attach the screenshot with that version? Used in a build step, a upstream build is always running when triggered a downstream build. What's your expecting behavior with "Block build when upstream project is building"? The latest version of parameterized-trigger-plugin is 2.25, and 2.17 is old version. On the other hand, Jenkins 1.565.1 is the latest LTS. That sounds strange to me. Do you mean you found the problems in the latest parameterized-trigger-plugin and you found they occur not with 2.16 but with 2.17? Let me know if you also upgraded Jenkins core. As far as I know, parameterized-trigger-plugin doesn't handle displaying upstream projects nor "Block build when upstream project is building"?. They might be caused by upgrade of Jenkins core.

          Sylvain C. added a comment -

          screenshot with 2.16 version

          Sylvain C. added a comment - screenshot with 2.16 version

          Sylvain C. added a comment -

          With LTS 1.565.1 and parameterized-trigger plugin 2.16, I have no issue. But since I upgraded to 2.17 and even 2.25 upstream jobs are no more displayed. I attach screenshot with 2.16 version.
          Usually I use the option "Block build when upstream project is building" to manage the triggering of my jobs in order to run only one installer. For example I have jobs A->B, A->C, B->D and C->D. Job D defined this option to run when B and D are finished. But since 2.17 D is started even if C or B are running.

          Sylvain C. added a comment - With LTS 1.565.1 and parameterized-trigger plugin 2.16, I have no issue. But since I upgraded to 2.17 and even 2.25 upstream jobs are no more displayed. I attach screenshot with 2.16 version. Usually I use the option "Block build when upstream project is building" to manage the triggering of my jobs in order to run only one installer. For example I have jobs A->B, A->C, B->D and C->D. Job D defined this option to run when B and D are finished. But since 2.17 D is started even if C or B are running.

          ikedam added a comment -

          Thanks for details.
          I'll test reproduction in my environment and see changes of codes in 2.17.

          ikedam added a comment - Thanks for details. I'll test reproduction in my environment and see changes of codes in 2.17.

          ikedam added a comment -

          I succeeded to reproduce the problem.

          Manage Jenkins > Script Console

          • With parameterized-trigger-2.16:
            Jenkins.instance.getItem("Job-B").upstreamProjects
            Result: [hudson.model.FreeStyleProject@76712b2f[Job-A]]
            
          • With parameterized-trigger-2.17:
            Jenkins.instance.getItem("Job-B").upstreamProjects
            Result: []
            

          It looks that DependencyGraph which notifies Jenkins project dependency is removed from TriggerBuilder since 2.17.
          https://github.com/jenkinsci/parameterized-trigger-plugin/commit/e2e678807107e579c4af42d912d3c62a0564abb0
          https://github.com/jenkinsci/parameterized-trigger-plugin/pull/19

          ikedam added a comment - I succeeded to reproduce the problem. Manage Jenkins > Script Console With parameterized-trigger-2.16: Jenkins.instance.getItem("Job-B").upstreamProjects Result: [hudson.model.FreeStyleProject@76712b2f[Job-A]] With parameterized-trigger-2.17: Jenkins.instance.getItem("Job-B").upstreamProjects Result: [] It looks that DependencyGraph which notifies Jenkins project dependency is removed from TriggerBuilder since 2.17. https://github.com/jenkinsci/parameterized-trigger-plugin/commit/e2e678807107e579c4af42d912d3c62a0564abb0 https://github.com/jenkinsci/parameterized-trigger-plugin/pull/19

          ikedam added a comment -

          Though I think that was a quite thouhtless change, it's a current feature and reverting would affect many users.
          I think adding an option to declare project dependency which defaults to false (compatible with current behavior), that provides a behavior compatible to 2.16.

          I can't get why they merged this pull request instead.
          https://github.com/jenkinsci/parameterized-trigger-plugin/pull/26

          ikedam added a comment - Though I think that was a quite thouhtless change, it's a current feature and reverting would affect many users. I think adding an option to declare project dependency which defaults to false (compatible with current behavior), that provides a behavior compatible to 2.16. I can't get why they merged this pull request instead. https://github.com/jenkinsci/parameterized-trigger-plugin/pull/26

          Sylvain C. added a comment -

          Thanks for your test but I don't understand why "it's a current feature" and not a regression ?

          Sylvain C. added a comment - Thanks for your test but I don't understand why "it's a current feature" and not a regression ?

          ikedam added a comment -

          Please have a look at the discussion in https://github.com/jenkinsci/parameterized-trigger-plugin/pull/19 .
          Behaviors you pointed are not ones introduced by mistake, but ones that maintainer at that time accepted.

          Parameterized-trigger 2.17 was released in Feb 2013 (more than one year ago!) and many users already use parameterized-plugin > 2.16.
          Simply reverting changes in 2.17 would cause a regression for many users and we should introduce another feature to work as 2.16.

          ikedam added a comment - Please have a look at the discussion in https://github.com/jenkinsci/parameterized-trigger-plugin/pull/19 . Behaviors you pointed are not ones introduced by mistake, but ones that maintainer at that time accepted. Parameterized-trigger 2.17 was released in Feb 2013 (more than one year ago!) and many users already use parameterized-plugin > 2.16. Simply reverting changes in 2.17 would cause a regression for many users and we should introduce another feature to work as 2.16.

          Sylvain C. added a comment -

          I understand the discussion and adding an option is a good solution.
          Thanks

          Sylvain C. added a comment - I understand the discussion and adding an option is a good solution. Thanks

            huybrechts huybrechts
            sylvainc Sylvain C.
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated: