Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-24703

Search box background color (white) not matching navbar backround (black)

        [JENKINS-24703] Search box background color (white) not matching navbar backround (black)

        Tom FENNELLY added a comment -

        Caused by commit 143581e67fbcf971bfdadf2ad42535a6912caf73 which relates to JENKINS-24625.

        I don't think explicitly setting the background-color is the answer to JENKINS-24625.

        Tom FENNELLY added a comment - Caused by commit 143581e67fbcf971bfdadf2ad42535a6912caf73 which relates to JENKINS-24625 . I don't think explicitly setting the background-color is the answer to JENKINS-24625 .

        I fixed the issue with the search bar by specifically targeting the input elements instead:

        https://github.com/jenkinsci/jenkins/pull/1396

        Another solution I can think of is not setting the foreground color of inputs, then the background colors don't have to be set either.

        Ceesjan Luiten added a comment - I fixed the issue with the search bar by specifically targeting the input elements instead: https://github.com/jenkinsci/jenkins/pull/1396 Another solution I can think of is not setting the foreground color of inputs, then the background colors don't have to be set either.

        Tom FENNELLY added a comment -

        Assuming it works, I would go with the later of your two fixes listed above i.e. remove the setting of the font color on the input. I was not able to test this the other day because I did not know how you were changing your colour scheme to cause the original problem you were trying to fix.

        Tom FENNELLY added a comment - Assuming it works, I would go with the later of your two fixes listed above i.e. remove the setting of the font color on the input. I was not able to test this the other day because I did not know how you were changing your colour scheme to cause the original problem you were trying to fix.

        Thanks for the feedback Tom.

        I've implemented your suggestion:

        https://github.com/quinox/jenkins/commit/78d222c607d31bdcfd5df7c20dbefe3ec937f3de

        The differences for most people will be subtle, instead of #333-on-white you get <default text color (#000)>-on-white. You shouldn't see any other changes. For me the change is significant, I get usable input fields again.

        I looked at a few CSS frameworks yesterday, some follow the road of color-style-everything (fe. Bootstrap) while others don't color-style input elements at all (fe. Yahoo!'s Pure CSS)

        Ceesjan Luiten added a comment - Thanks for the feedback Tom. I've implemented your suggestion: https://github.com/quinox/jenkins/commit/78d222c607d31bdcfd5df7c20dbefe3ec937f3de The differences for most people will be subtle, instead of #333-on-white you get <default text color (#000)>-on-white. You shouldn't see any other changes. For me the change is significant, I get usable input fields again. I looked at a few CSS frameworks yesterday, some follow the road of color-style-everything (fe. Bootstrap) while others don't color-style input elements at all (fe. Yahoo!'s Pure CSS)

        Daniel Beck added a comment -

        Tom, I'd like to see this fixed this week – if you're busy I'd just revert the bad change for JENKINS-24625 for now. Please let me know.

        Daniel Beck added a comment - Tom, I'd like to see this fixed this week – if you're busy I'd just revert the bad change for JENKINS-24625 for now. Please let me know.

        Tom FENNELLY added a comment -

        Sorry Daniel. I merged this and created a PR at https://github.com/jenkinsci/jenkins/pull/1423. We will merge upstream shortly (assuming it passes the build).

        Tom FENNELLY added a comment - Sorry Daniel. I merged this and created a PR at https://github.com/jenkinsci/jenkins/pull/1423 . We will merge upstream shortly (assuming it passes the build).

        Daniel Beck added a comment -

        Great, thanks Tom!

        Daniel Beck added a comment - Great, thanks Tom!

        Code changed in jenkins
        User: quinox
        Path:
        war/src/main/webapp/css/style.css
        http://jenkins-ci.org/commit/jenkins/f98699fa487e8479a4c3bca4cf651bdb9ef28004
        Log:
        [FIXED JENKINS-24703] Do not set any colors for input elements

        SCM/JIRA link daemon added a comment - Code changed in jenkins User: quinox Path: war/src/main/webapp/css/style.css http://jenkins-ci.org/commit/jenkins/f98699fa487e8479a4c3bca4cf651bdb9ef28004 Log: [FIXED JENKINS-24703] Do not set any colors for input elements

        Code changed in jenkins
        User: Tom Fennelly
        Path:
        war/src/main/webapp/css/style.css
        http://jenkins-ci.org/commit/jenkins/4eefff9f95570ed8be4b98ab4ae683004dc65de8
        Log:
        Merge pull request #1423 from tfennelly/JENKINS-24703

        [FIXED JENKINS-24703] Do not set any colors for input elements

        Compare: https://github.com/jenkinsci/jenkins/compare/e72c11ae4b2a...4eefff9f9557

        SCM/JIRA link daemon added a comment - Code changed in jenkins User: Tom Fennelly Path: war/src/main/webapp/css/style.css http://jenkins-ci.org/commit/jenkins/4eefff9f95570ed8be4b98ab4ae683004dc65de8 Log: Merge pull request #1423 from tfennelly/ JENKINS-24703 [FIXED JENKINS-24703] Do not set any colors for input elements Compare: https://github.com/jenkinsci/jenkins/compare/e72c11ae4b2a...4eefff9f9557

        dogfood added a comment -

        Integrated in jenkins_main_trunk #3729
        [FIXED JENKINS-24703] Do not set any colors for input elements (Revision f98699fa487e8479a4c3bca4cf651bdb9ef28004)

        Result = SUCCESS
        tom.fennelly : f98699fa487e8479a4c3bca4cf651bdb9ef28004
        Files :

        • war/src/main/webapp/css/style.css

        dogfood added a comment - Integrated in jenkins_main_trunk #3729 [FIXED JENKINS-24703] Do not set any colors for input elements (Revision f98699fa487e8479a4c3bca4cf651bdb9ef28004) Result = SUCCESS tom.fennelly : f98699fa487e8479a4c3bca4cf651bdb9ef28004 Files : war/src/main/webapp/css/style.css

          tfennelly Tom FENNELLY
          tfennelly Tom FENNELLY
          Votes:
          0 Vote for this issue
          Watchers:
          4 Start watching this issue

            Created:
            Updated:
            Resolved: