Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-24625

style.css should define background color for input fields

      Currently style.css sets the foreground color but doesn't set the background color; this renders all input fields unreadable for people with certain color schemes.

      https://github.com/jenkinsci/jenkins/blob/7cdb85d09c0a709c59694de7b009cb2d0117578b/war/src/main/webapp/css/style.css#L115

      To reproduce on Windows: Switch the Windows theme to High Contract and open a job configuration page.

      To reproduce on Linux: Switch your theme to one where you have dark backgrounds and light text.

      To solve this, add 'background-color: #fff' to the same definition.

          [JENKINS-24625] style.css should define background color for input fields

          Daniel Beck added a comment -

          That would probably be a good idea (Tom, who's working on Jenkins UX, is currently on vacation). For advice related to that, see:
          https://wiki.jenkins-ci.org/display/JENKINS/Governance+Document#GovernanceDocument-Usingpullrequests
          https://wiki.jenkins-ci.org/display/JENKINS/Pull+Request+to+Repositories

          Daniel Beck added a comment - That would probably be a good idea (Tom, who's working on Jenkins UX, is currently on vacation). For advice related to that, see: https://wiki.jenkins-ci.org/display/JENKINS/Governance+Document#GovernanceDocument-Usingpullrequests https://wiki.jenkins-ci.org/display/JENKINS/Pull+Request+to+Repositories

          Thanks for the help Daniel, made the pull request.

          For those who want to reproduce the bug: After switching your theme you might need to restart your browser before the color scheme becomes fully active (the window decoration changes right away). Also, Chrome/Chromium isn't affected by it because they seem to ignore the user's theme completely.

          There's no testcase; if these kinds of issues should be intercepted in the future Jenkins could incorporate some kind of CSS Lint in the validation process.

          Ceesjan Luiten added a comment - Thanks for the help Daniel, made the pull request. For those who want to reproduce the bug: After switching your theme you might need to restart your browser before the color scheme becomes fully active (the window decoration changes right away). Also, Chrome/Chromium isn't affected by it because they seem to ignore the user's theme completely. There's no testcase; if these kinds of issues should be intercepted in the future Jenkins could incorporate some kind of CSS Lint in the validation process.

          Code changed in jenkins
          User: quinox
          Path:
          war/src/main/webapp/css/style.css
          http://jenkins-ci.org/commit/jenkins/143581e67fbcf971bfdadf2ad42535a6912caf73
          Log:
          [FIXED JENKINS-24625] Set background color on input elements

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: quinox Path: war/src/main/webapp/css/style.css http://jenkins-ci.org/commit/jenkins/143581e67fbcf971bfdadf2ad42535a6912caf73 Log: [FIXED JENKINS-24625] Set background color on input elements

          Code changed in jenkins
          User: Daniel Beck
          Path:
          war/src/main/webapp/css/style.css
          http://jenkins-ci.org/commit/jenkins/2753fac18d6ead74d8f446abcebda659eab29155
          Log:
          Merge pull request #1394 from quinox/master

          [FIXED JENKINS-24625] Set background color on input elements

          Compare: https://github.com/jenkinsci/jenkins/compare/8cbd2b57a8e2...2753fac18d6e

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Daniel Beck Path: war/src/main/webapp/css/style.css http://jenkins-ci.org/commit/jenkins/2753fac18d6ead74d8f446abcebda659eab29155 Log: Merge pull request #1394 from quinox/master [FIXED JENKINS-24625] Set background color on input elements Compare: https://github.com/jenkinsci/jenkins/compare/8cbd2b57a8e2...2753fac18d6e

          dogfood added a comment -

          Integrated in jenkins_main_trunk #3678
          [FIXED JENKINS-24625] Set background color on input elements (Revision 143581e67fbcf971bfdadf2ad42535a6912caf73)

          Result = SUCCESS
          quinox : 143581e67fbcf971bfdadf2ad42535a6912caf73
          Files :

          • war/src/main/webapp/css/style.css

          dogfood added a comment - Integrated in jenkins_main_trunk #3678 [FIXED JENKINS-24625] Set background color on input elements (Revision 143581e67fbcf971bfdadf2ad42535a6912caf73) Result = SUCCESS quinox : 143581e67fbcf971bfdadf2ad42535a6912caf73 Files : war/src/main/webapp/css/style.css

          Tom FENNELLY added a comment -

          This change causes other small issues. Please see JENKINS-24703.

          Tom FENNELLY added a comment - This change causes other small issues. Please see JENKINS-24703 .

          Tom FENNELLY added a comment -

          The description of this JIRA just says "Switch your theme to...". Where exactly did you go to switch the theme?

          Tom FENNELLY added a comment - The description of this JIRA just says "Switch your theme to...". Where exactly did you go to switch the theme?

          Daniel Beck added a comment -

          Cannot reproduce on Windows 8.1 with any of the four high contrast themes in IE 11 or Firefox 32. How can this be reproduced?

          Daniel Beck added a comment - Cannot reproduce on Windows 8.1 with any of the four high contrast themes in IE 11 or Firefox 32. How can this be reproduced?

          I cannot reproduce it either on Windows 8.1 nor on Vista with Firefox/IE. Firefox 32 on Windows XP does have the problem:

          http://ghost.qtea.nl/tmp/jenkins-colors-winxp-firefox32.png

          Linux deals with this less well than Windows it seems, with both KDE and Gnome suffering from it.

          Re JENKINS-24703: Instead of my previous solution (the merged pull request) the background color can also be set on the body element: I still get good readable inputs.

          Ceesjan Luiten added a comment - I cannot reproduce it either on Windows 8.1 nor on Vista with Firefox/IE. Firefox 32 on Windows XP does have the problem: http://ghost.qtea.nl/tmp/jenkins-colors-winxp-firefox32.png Linux deals with this less well than Windows it seems, with both KDE and Gnome suffering from it. Re JENKINS-24703 : Instead of my previous solution (the merged pull request) the background color can also be set on the body element: I still get good readable inputs.

          Code changed in jenkins
          User: Michal Turek
          Path:
          src/main/resources/org/jenkinsci/plugins/cppcheck/CppcheckResult/details.jelly
          src/main/resources/org/jenkinsci/plugins/cppcheck/CppcheckResult/index.jelly
          src/main/resources/org/jenkinsci/plugins/cppcheck/CppcheckSourceAll/index.jelly
          http://jenkins-ci.org/commit/cppcheck-plugin/cb9f0426890e0b938ca711d18698a0007a8e9fb5
          Log:
          JENKINS-24834 CPP check report background colours not displaying for new or resolved issues since upgrade

          • White background color was set to all TD elements in core's JENKINS-24625 which overwrote settings of outer TR.
          • Missing mandatory "title" element added to l:layout.

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Michal Turek Path: src/main/resources/org/jenkinsci/plugins/cppcheck/CppcheckResult/details.jelly src/main/resources/org/jenkinsci/plugins/cppcheck/CppcheckResult/index.jelly src/main/resources/org/jenkinsci/plugins/cppcheck/CppcheckSourceAll/index.jelly http://jenkins-ci.org/commit/cppcheck-plugin/cb9f0426890e0b938ca711d18698a0007a8e9fb5 Log: JENKINS-24834 CPP check report background colours not displaying for new or resolved issues since upgrade White background color was set to all TD elements in core's JENKINS-24625 which overwrote settings of outer TR. Missing mandatory "title" element added to l:layout.

            Unassigned Unassigned
            quinox Ceesjan Luiten
            Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

              Created:
              Updated:
              Resolved: