Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-24773

Allocated and blacklisted display number are shared accross all slaves

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Major Major
    • xvnc-plugin
    • None

      With enough slaves, every now and then, available display number are exhausted presumably because one display allocator is shared by all slaves. Random build then fail with:

      FATAL: All available display numbers are allocated or blacklisted.
      allocated: [10, 11, 12, 13, 14, 15, 17, 16, 19, 18, 21, 20, 23, 22, 25, 24, 27, 26, 29, 28, 31, 30, 34, 35, 32, 33, 38, 39, 36, 37, 42, 43, 40, 41, 46, 47, 44, 45, 51, 50, 49, 48, 55, 54, 53, 52, 59, 58, 57, 56, 63, 62, 61, 60, 68, 69, 70, 71, 64, 65, 66, 67, 76, 77, 78, 79, 72, 73, 74, 75, 85, 84, 87, 86, 81, 80, 83, 82, 93, 92, 95, 94, 89, 88, 91, 90, 98, 99, 96, 97]
      blacklisted: []
      java.lang.RuntimeException: All available display numbers are allocated or blacklisted.
      allocated: [10, 11, 12, 13, 14, 15, 17, 16, 19, 18, 21, 20, 23, 22, 25, 24, 27, 26, 29, 28, 31, 30, 34, 35, 32, 33, 38, 39, 36, 37, 42, 43, 40, 41, 46, 47, 44, 45, 51, 50, 49, 48, 55, 54, 53, 52, 59, 58, 57, 56, 63, 62, 61, 60, 68, 69, 70, 71, 64, 65, 66, 67, 76, 77, 78, 79, 72, 73, 74, 75, 85, 84, 87, 86, 81, 80, 83, 82, 93, 92, 95, 94, 89, 88, 91, 90, 98, 99, 96, 97]
      blacklisted: []
       at hudson.plugins.xvnc.DisplayAllocator.allocate(DisplayAllocator.java:35)
       at hudson.plugins.xvnc.Xvnc.doSetUp(Xvnc.java:86)
       at hudson.plugins.xvnc.Xvnc.setUp(Xvnc.java:78)
       at hudson.model.Build$BuildExecution.doRun(Build.java:154)
       at hudson.model.AbstractBuild$AbstractBuildExecution.run(AbstractBuild.java:566)
       at hudson.model.Run.execute(Run.java:1665)
       at hudson.matrix.MatrixRun.run(MatrixRun.java:146)
       at hudson.model.ResourceController.execute(ResourceController.java:88)
       at hudson.model.Executor.run(Executor.java:246)
      

      Introduced in: https://github.com/jenkinsci/xvnc-plugin/commit/6bdd6098c1d5f2a5aeb52fd05fa2f82d85782f96

          [JENKINS-24773] Allocated and blacklisted display number are shared accross all slaves

          Oliver Gondža added a comment - Fix proposed: https://github.com/jenkinsci/xvnc-plugin/pull/3

          Code changed in jenkins
          User: Oliver Gondža
          Path:
          src/main/java/hudson/plugins/xvnc/DisplayAllocator.java
          src/main/java/hudson/plugins/xvnc/Xvnc.java
          src/test/java/hudson/plugins/xvnc/XvncTest.java
          http://jenkins-ci.org/commit/xvnc-plugin/3627859ad1076ed279b1b731f2fb009a58cca368
          Log:
          [FIXED JENKINS-24773] Allocated and blacklisted display number are shared accross all slaves

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Oliver Gondža Path: src/main/java/hudson/plugins/xvnc/DisplayAllocator.java src/main/java/hudson/plugins/xvnc/Xvnc.java src/test/java/hudson/plugins/xvnc/XvncTest.java http://jenkins-ci.org/commit/xvnc-plugin/3627859ad1076ed279b1b731f2fb009a58cca368 Log: [FIXED JENKINS-24773] Allocated and blacklisted display number are shared accross all slaves

          Code changed in jenkins
          User: Oliver Gondža
          Path:
          src/main/java/hudson/plugins/xvnc/DisplayAllocator.java
          src/test/java/hudson/plugins/xvnc/XvncTest.java
          http://jenkins-ci.org/commit/xvnc-plugin/b354e193f566d4b15c9bdd89a309f6233ff3eb71
          Log:
          JENKINS-24773 Avoid NPE

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Oliver Gondža Path: src/main/java/hudson/plugins/xvnc/DisplayAllocator.java src/test/java/hudson/plugins/xvnc/XvncTest.java http://jenkins-ci.org/commit/xvnc-plugin/b354e193f566d4b15c9bdd89a309f6233ff3eb71 Log: JENKINS-24773 Avoid NPE

          Code changed in jenkins
          User: Oliver Gondža
          Path:
          src/main/java/hudson/plugins/xvnc/DisplayAllocator.java
          src/main/java/hudson/plugins/xvnc/Xvnc.java
          src/test/java/hudson/plugins/xvnc/XvncTest.java
          http://jenkins-ci.org/commit/xvnc-plugin/4b8fec958390bec6fd8993d94c1fb901201da437
          Log:
          Merge pull request #3 from olivergondza/slave-specific-alocator

          [FIXED JENKINS-24773] Allocated and blacklisted display number are shared accross all slaves

          Compare: https://github.com/jenkinsci/xvnc-plugin/compare/cbdcafe4f5b1...4b8fec958390

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Oliver Gondža Path: src/main/java/hudson/plugins/xvnc/DisplayAllocator.java src/main/java/hudson/plugins/xvnc/Xvnc.java src/test/java/hudson/plugins/xvnc/XvncTest.java http://jenkins-ci.org/commit/xvnc-plugin/4b8fec958390bec6fd8993d94c1fb901201da437 Log: Merge pull request #3 from olivergondza/slave-specific-alocator [FIXED JENKINS-24773] Allocated and blacklisted display number are shared accross all slaves Compare: https://github.com/jenkinsci/xvnc-plugin/compare/cbdcafe4f5b1...4b8fec958390

          Thomas Mortagne added a comment - - edited

          I seems to reproduce this issue with Jenkins 2.138.1 (but I had it with 2.121.3 too). I don't remember upgrading the XVNC plugin recently but according to https://wiki.jenkins.io/display/JENKINS/Xvnc+Plugin the last version is pretty old now.

          I have a hard time understanding why the plugin would need to maintain such a list (shared or not) in the fist place since xvnc is doing it already.

          Thomas Mortagne added a comment - - edited I seems to reproduce this issue with Jenkins 2.138.1 (but I had it with 2.121.3 too). I don't remember upgrading the XVNC plugin recently but according to https://wiki.jenkins.io/display/JENKINS/Xvnc+Plugin the last version is pretty old now. I have a hard time understanding why the plugin would need to maintain such a list (shared or not) in the fist place since xvnc is doing it already.

            olivergondza Oliver Gondža
            olivergondza Oliver Gondža
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated:
              Resolved: