Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-24905

Tab and source layout broken after Jenkins UI improvements

      After Jenkins UI improvement pull requests the layout of the YUI tabs (https://github.com/jenkinsci/analysis-core-plugin/blob/master/src/main/resources/result/main.jelly) and the source code view is somewhat broken.

      Seems that some of the new CSS styles conflict with the style of the analysis plugins. The tabs and tables inside the tabs look weird. Moreover, the highlighting of the current source code line is missing now.

          [JENKINS-24905] Tab and source layout broken after Jenkins UI improvements

          Code changed in jenkins
          User: Ulli Hafner
          Path:
          .gitignore
          src/main/java/hudson/plugins/analysis/views/ConsoleDetail.java
          src/main/java/hudson/plugins/analysis/views/SourceDetail.java
          src/test/resources/hudson/plugins/analysis/views/ExpectedRendering-2-Ranges.html
          src/test/resources/hudson/plugins/analysis/views/ExpectedRendering-Line6-12.html
          src/test/resources/hudson/plugins/analysis/views/ExpectedRendering-Line6.html
          http://jenkins-ci.org/commit/analysis-core-plugin/3d2410ff40cc7bf931fcdf22b30c9627aa62cdca
          Log:
          Merge pull request #23 from yohanesgultom/master

          Replace bgcolor with background-color to comply html5. Fixes partly JENKINS-24905.

          Compare: https://github.com/jenkinsci/analysis-core-plugin/compare/1d1eb5b17cc4...3d2410ff40cc

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Ulli Hafner Path: .gitignore src/main/java/hudson/plugins/analysis/views/ConsoleDetail.java src/main/java/hudson/plugins/analysis/views/SourceDetail.java src/test/resources/hudson/plugins/analysis/views/ExpectedRendering-2-Ranges.html src/test/resources/hudson/plugins/analysis/views/ExpectedRendering-Line6-12.html src/test/resources/hudson/plugins/analysis/views/ExpectedRendering-Line6.html http://jenkins-ci.org/commit/analysis-core-plugin/3d2410ff40cc7bf931fcdf22b30c9627aa62cdca Log: Merge pull request #23 from yohanesgultom/master Replace bgcolor with background-color to comply html5. Fixes partly JENKINS-24905 . Compare: https://github.com/jenkinsci/analysis-core-plugin/compare/1d1eb5b17cc4...3d2410ff40cc

          Tom FENNELLY added a comment -

          Ulli, what is the status of this? I see a commit against it but the issue is still unresolved?

          Tom FENNELLY added a comment - Ulli, what is the status of this? I see a commit against it but the issue is still unresolved?

          Ulli Hafner added a comment -

          Actually I never started to work on this, my CSS experience is quite limited... The commit is from a pull request that fixed the broken highlighting of the current line in the source overview. If you are interested in helping out I would be very happy

          Ulli Hafner added a comment - Actually I never started to work on this, my CSS experience is quite limited... The commit is from a pull request that fixed the broken highlighting of the current line in the source overview. If you are interested in helping out I would be very happy

            drulli Ulli Hafner
            drulli Ulli Hafner
            Votes:
            1 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated:
              Resolved: