Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-25075

Weather column should render asynchronously

    XMLWordPrintable

Details

    Description

      Job.getBuildHealthReports can be expensive, especially with Maven projects (see JENKINS-19392). Putting jobs into folders does not help, because Folder.getBuildHealthReports recursively traverses them, and the default WorstChildHealthMetric checks the result of each leaf. It should not be called synchronously during page rendering. Rather, WeatherColumn/column.jelly should use an AJAX callback of some kind, effective while the page is fronted. So you would get a quick page load, with some icons filling in progressively. Still puts load on the server but potentially much less.

      Attachments

        Issue Links

          depends on

          Bug - A problem which impairs or prevents the functions of the product. JENKINS-25081 Memory leak in ProgressiveRendering

          • Major - Major loss of function.
          • Resolved
          is duplicated by

          Bug - A problem which impairs or prevents the functions of the product. JENKINS-20731 Dashboard rendering spends too much time in WeatherColumn

          • Major - Major loss of function.
          • Resolved
          is related to

          Bug - A problem which impairs or prevents the functions of the product. JENKINS-19392 First-time display with many Maven jobs blocked in FingerprintAction.compact

          • Critical - Crashes, loss of data, severe memory leak.
          • Resolved

          Bug - A problem which impairs or prevents the functions of the product. JENKINS-18895 MavenModuleSetBuild.getResult is expensive

          • Major - Major loss of function.
          • Resolved

          Bug - A problem which impairs or prevents the functions of the product. JENKINS-25073 Double-counting of health reports from child folders

          • Major - Major loss of function.
          • Resolved

          Bug - A problem which impairs or prevents the functions of the product. JENKINS-25074 Build health computed twice per job

          • Major - Major loss of function.
          • Resolved

          Task - A task that needs to be done. JENKINS-19828 Kill or rework auto refresh

          • Major - Major loss of function.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. JENKINS-25078 Default health metric is potentially expensive

          • Major - Major loss of function.
          • Closed

          Improvement - An improvement or enhancement to an existing feature or task. JENKINS-36629 Use the run map to optimize calculating recent build health

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Closed
          relates to

          Epic - Created by Jira Software - do not edit or delete. Issue type for a big user story that needs to be broken down. JENKINS-18377 Improve the performance when listing many jobs (GSoC 2019, coding phase 2)

          • Major - Major loss of function.
          • In Progress

          Activity

            Ascending order - Click to sort in descending order
            jglick Jesse Glick added a comment -

            Auto refresh makes everything that much worse.

            jglick Jesse Glick added a comment - Auto refresh makes everything that much worse.
            jglick Jesse Glick added a comment -

            Looked into implementing this. Tricky to render HTML content from existing column.jelly scripts but ought to be possible. (l:renderOnDemand is not suitable since that makes one HTTP request per response, and is insensitive to page activity. Really want ProgressiveRendering, but this does not yet support HTML output, only JSON, meaning that buildHealth.jelly could not be reused.)

            The real trouble is JENKINS-16341: even creating a single ProgressiveRendering per list view render would add a new entry to BoundObjectTable per page load, which would quickly add up to a huge amount of memory consumed by the server if you have lots of active sessions browsing Jenkins repeatedly.

            jglick Jesse Glick added a comment - Looked into implementing this. Tricky to render HTML content from existing column.jelly scripts but ought to be possible. ( l:renderOnDemand is not suitable since that makes one HTTP request per response, and is insensitive to page activity. Really want ProgressiveRendering , but this does not yet support HTML output, only JSON, meaning that buildHealth.jelly could not be reused.) The real trouble is JENKINS-16341 : even creating a single ProgressiveRendering per list view render would add a new entry to BoundObjectTable per page load, which would quickly add up to a huge amount of memory consumed by the server if you have lots of active sessions browsing Jenkins repeatedly.
            jglick Jesse Glick added a comment -

            Depends on more tractable special case JENKINS-25081.

            jglick Jesse Glick added a comment - Depends on more tractable special case JENKINS-25081 .

            People

              Unassigned Unassigned
              jglick Jesse Glick
              Votes:
              3 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated: