Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-25197

Implement scm-api's new parentRevisions() and parentHeads() methods

    XMLWordPrintable

Details

    • New Feature
    • Status: Open (View Workflow)
    • Major
    • Resolution: Unresolved
    • git-plugin
    • None

    Description

      Version 0.3 of the scm-api plugin [1] will have new methods to look up the parent head / revision(s) of a commit [2], which is a prerequisite for obtaining the correct reference build for various trends / statistics. Please implement these to unblock [3].

      [1] https://wiki.jenkins-ci.org/display/JENKINS/SCM+API+Plugin
      [2] https://github.com/jenkinsci/scm-api-plugin/commit/dfd212743862b9d1f7a12255723f8358bbb1bf78
      [3] https://issues.jenkins-ci.org/browse/JENKINS-13056

      Attachments

        Issue Links

          Activity

            markewaite Mark Waite added a comment -

            I don't think we can release a version of the git plugin which depends on scm-api 0.3 until scm-api 0.3 is released.

            markewaite Mark Waite added a comment - I don't think we can release a version of the git plugin which depends on scm-api 0.3 until scm-api 0.3 is released.

            Of course not. But you could already implement the methods in a branch which depends on scm-api 0.3-SNAPSHOT, but no merge the branch until scm-api 0.3 is released. You could even implement the methods in master but omit @Override from them until you can depend on the released scm-api 0.3.

            Anyway, I've asked scm-api for a release.

            sschuberth Sebastian Schuberth added a comment - Of course not. But you could already implement the methods in a branch which depends on scm-api 0.3-SNAPSHOT, but no merge the branch until scm-api 0.3 is released. You could even implement the methods in master but omit @Override from them until you can depend on the released scm-api 0.3. Anyway, I've asked scm-api for a release.
            dirmeier dirmeier added a comment -

            markewaite JENKINS-21007 is release for some time, is this already open in git-plugin? Could you give me a hint how to implement it?

            dirmeier dirmeier added a comment - markewaite JENKINS-21007 is release for some time, is this already open in git-plugin? Could you give me a hint how to implement it?
            markewaite Mark Waite added a comment - - edited

            I assume you would add an implementation of parentRevisions and parentHeads to a forked copy of GitSCMSource, along with unit tests to confirm the methods are behaving as expected.

            Once the unit tests are passing, you'd perform integration testing to verify the results appear as expected in a running Jenkins.

            After you've completed the unit tests and the integration testing, then you'd submit a pull request to propose your change to the official repository.

            markewaite Mark Waite added a comment - - edited I assume you would add an implementation of parentRevisions and parentHeads to a forked copy of GitSCMSource , along with unit tests to confirm the methods are behaving as expected. Once the unit tests are passing, you'd perform integration testing to verify the results appear as expected in a running Jenkins. After you've completed the unit tests and the integration testing, then you'd submit a pull request to propose your change to the official repository.

            People

              Unassigned Unassigned
              sschuberth Sebastian Schuberth
              Votes:
              1 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated: