Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-25314

QueueTaskFuture doesn't report cancellation properly

    XMLWordPrintable

Details

    • Bug
    • Status: Resolved (View Workflow)
    • Major
    • Resolution: Fixed
    • core
    • None

    Description

      rsandell reported while developing his plugin that when a task is cancelled, its QueueTaskFuture doesn't correctly report itself as cancelled.

      This is reported against 1.554.

      Attachments

        Activity

          Turns out JENKINS-21932 had fixed the key part of the problem.

          kohsuke Kohsuke Kawaguchi added a comment - Turns out JENKINS-21932 had fixed the key part of the problem.

          Code changed in jenkins
          User: Kohsuke Kawaguchi
          Path:
          changelog.html
          core/src/main/java/hudson/model/Queue.java
          http://jenkins-ci.org/commit/jenkins/9b36e2ae8dbbd2a7ab0d9d4bc9e24e305e33ecbc
          Log:
          [FIXED JENKINS-25314]

          The original fix was made in 0c3d67097a3394fee7f0eb895c4350ea96887a02.
          In this fix, I'm also moving the code that creates LeftItem.

          It makes no sense that there's Item.cancel(Queue) and Queue.cancel(Item)
          and they do different things!

          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Kohsuke Kawaguchi Path: changelog.html core/src/main/java/hudson/model/Queue.java http://jenkins-ci.org/commit/jenkins/9b36e2ae8dbbd2a7ab0d9d4bc9e24e305e33ecbc Log: [FIXED JENKINS-25314] The original fix was made in 0c3d67097a3394fee7f0eb895c4350ea96887a02. In this fix, I'm also moving the code that creates LeftItem. It makes no sense that there's Item.cancel(Queue) and Queue.cancel(Item) and they do different things!
          dogfood dogfood added a comment -

          Integrated in jenkins_main_trunk #3777
          [FIXED JENKINS-25314] (Revision 9b36e2ae8dbbd2a7ab0d9d4bc9e24e305e33ecbc)

          Result = SUCCESS
          kohsuke : 9b36e2ae8dbbd2a7ab0d9d4bc9e24e305e33ecbc
          Files :

          • changelog.html
          • core/src/main/java/hudson/model/Queue.java
          dogfood dogfood added a comment - Integrated in jenkins_main_trunk #3777 [FIXED JENKINS-25314] (Revision 9b36e2ae8dbbd2a7ab0d9d4bc9e24e305e33ecbc) Result = SUCCESS kohsuke : 9b36e2ae8dbbd2a7ab0d9d4bc9e24e305e33ecbc Files : changelog.html core/src/main/java/hudson/model/Queue.java

          People

            kohsuke Kohsuke Kawaguchi
            kohsuke Kohsuke Kawaguchi
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: