Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-25528

Reboot dialog displayed during MSI installation when upgrading

    XMLWordPrintable

Details

    Description

      Upgrading Jenkins using an MSI package while a previous version of Jenkins is running will open a dialog saying "... a reboot will be required to complete the setup." To reproduce, double-click jenkins-1.587.msi and complete the installation, then double-click jenkins-1.589.msi to upgrade.

      I do not believe a reboot should actually be necessary. The dialog is not displayed if the user manually stops the service before running the newer MSI, but that workaround is not user-friendly. If the MSI installer would stop the service early on during the upgrade, I suspect the dialog would not be shown.

      I'm not sure if the ServiceControl element defined in https://github.com/jenkinsci/jenkins/blob/master/msi/jenkins.wxs is supposed to stop the service during upgrades. I also don't know if this is a problem with the WiX definition or a winsw issue. Another app I know of also uses winsw and WiX and has the same issue.

      Attachments

        Activity

          I discovered that if I make the MSI installation non-interactive by removing all UI elements from the .wxs file, the installation will not prompt for a reboot and will stop the previously running service as expected.

          malliina Michael Skogberg added a comment - I discovered that if I make the MSI installation non-interactive by removing all UI elements from the .wxs file, the installation will not prompt for a reboot and will stop the previously running service as expected.
          slide_o_mix Alex Earl added a comment -

          We're probably going to disable upgrades using the installer. The preferred method is to use the internal upgrade utility to upgrade the WAR.

          slide_o_mix Alex Earl added a comment - We're probably going to disable upgrades using the installer. The preferred method is to use the internal upgrade utility to upgrade the WAR.

          People

            slide_o_mix Alex Earl
            malliina Michael Skogberg
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated: