Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-25655

AbstractLazyLoadRunMap.entrySet improperly cached

    XMLWordPrintable

Details

    Description

      JENKINS-18065 introduced a layer of caching which caused stale data to be reported under some conditions.

      Attachments

        Issue Links

          is blocking

          Bug - A problem which impairs or prevents the functions of the product. JENKINS-18065 AbstractLazyLoadRunMap.iterator() calls .all()

          • Critical - Crashes, loss of data, severe memory leak.
          • Resolved

          Activity

            Ascending order - Click to sort in descending order
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Jesse Glick
            Path:
            core/src/main/java/jenkins/model/lazy/AbstractLazyLoadRunMap.java
            core/src/main/java/jenkins/model/lazy/LazyLoadRunMapEntrySet.java
            core/src/test/java/jenkins/model/lazy/AbstractLazyLoadRunMapTest.java
            http://jenkins-ci.org/commit/jenkins/b76e7bf9988ebf5b3b7e2c5e588d5ce6dbde957e
            Log:
            [FIXED JENKINS-25655] Incorrect caching from entrySet sometimes caused incorrect results.
            Caused a failure in hudson.plugins.promoted_builds.conditions.ManualConditionTest.testManualPromotionProcessViaWebClient when run against 1.580.1.

            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: core/src/main/java/jenkins/model/lazy/AbstractLazyLoadRunMap.java core/src/main/java/jenkins/model/lazy/LazyLoadRunMapEntrySet.java core/src/test/java/jenkins/model/lazy/AbstractLazyLoadRunMapTest.java http://jenkins-ci.org/commit/jenkins/b76e7bf9988ebf5b3b7e2c5e588d5ce6dbde957e Log: [FIXED JENKINS-25655] Incorrect caching from entrySet sometimes caused incorrect results. Caused a failure in hudson.plugins.promoted_builds.conditions.ManualConditionTest.testManualPromotionProcessViaWebClient when run against 1.580.1.
            dogfood dogfood added a comment -

            Integrated in jenkins_main_trunk #3825
            [FIXED JENKINS-25655] Incorrect caching from entrySet sometimes caused incorrect results. (Revision b76e7bf9988ebf5b3b7e2c5e588d5ce6dbde957e)

            Result = SUCCESS
            jesse glick : b76e7bf9988ebf5b3b7e2c5e588d5ce6dbde957e
            Files :

            • core/src/main/java/jenkins/model/lazy/LazyLoadRunMapEntrySet.java
            • core/src/test/java/jenkins/model/lazy/AbstractLazyLoadRunMapTest.java
            • core/src/main/java/jenkins/model/lazy/AbstractLazyLoadRunMap.java
            dogfood dogfood added a comment - Integrated in jenkins_main_trunk #3825 [FIXED JENKINS-25655] Incorrect caching from entrySet sometimes caused incorrect results. (Revision b76e7bf9988ebf5b3b7e2c5e588d5ce6dbde957e) Result = SUCCESS jesse glick : b76e7bf9988ebf5b3b7e2c5e588d5ce6dbde957e Files : core/src/main/java/jenkins/model/lazy/LazyLoadRunMapEntrySet.java core/src/test/java/jenkins/model/lazy/AbstractLazyLoadRunMapTest.java core/src/main/java/jenkins/model/lazy/AbstractLazyLoadRunMap.java
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Jesse Glick
            Path:
            core/src/main/java/jenkins/model/lazy/AbstractLazyLoadRunMap.java
            core/src/main/java/jenkins/model/lazy/LazyLoadRunMapEntrySet.java
            core/src/test/java/jenkins/model/lazy/AbstractLazyLoadRunMapTest.java
            http://jenkins-ci.org/commit/jenkins/bd0453fe98e33cd99df9920c822210e49ad5cb6e
            Log:
            [FIXED JENKINS-25655] Incorrect caching from entrySet sometimes caused incorrect results.
            Caused a failure in hudson.plugins.promoted_builds.conditions.ManualConditionTest.testManualPromotionProcessViaWebClient when run against 1.580.1.
            (cherry picked from commit b76e7bf9988ebf5b3b7e2c5e588d5ce6dbde957e)

            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: core/src/main/java/jenkins/model/lazy/AbstractLazyLoadRunMap.java core/src/main/java/jenkins/model/lazy/LazyLoadRunMapEntrySet.java core/src/test/java/jenkins/model/lazy/AbstractLazyLoadRunMapTest.java http://jenkins-ci.org/commit/jenkins/bd0453fe98e33cd99df9920c822210e49ad5cb6e Log: [FIXED JENKINS-25655] Incorrect caching from entrySet sometimes caused incorrect results. Caused a failure in hudson.plugins.promoted_builds.conditions.ManualConditionTest.testManualPromotionProcessViaWebClient when run against 1.580.1. (cherry picked from commit b76e7bf9988ebf5b3b7e2c5e588d5ce6dbde957e)
            dogfood dogfood added a comment -

            Integrated in jenkins_main_trunk #4292
            [FIXED JENKINS-25655] Incorrect caching from entrySet sometimes caused incorrect results. (Revision bd0453fe98e33cd99df9920c822210e49ad5cb6e)

            Result = UNSTABLE
            ogondza : bd0453fe98e33cd99df9920c822210e49ad5cb6e
            Files :

            • core/src/main/java/jenkins/model/lazy/LazyLoadRunMapEntrySet.java
            • core/src/main/java/jenkins/model/lazy/AbstractLazyLoadRunMap.java
            • core/src/test/java/jenkins/model/lazy/AbstractLazyLoadRunMapTest.java
            dogfood dogfood added a comment - Integrated in jenkins_main_trunk #4292 [FIXED JENKINS-25655] Incorrect caching from entrySet sometimes caused incorrect results. (Revision bd0453fe98e33cd99df9920c822210e49ad5cb6e) Result = UNSTABLE ogondza : bd0453fe98e33cd99df9920c822210e49ad5cb6e Files : core/src/main/java/jenkins/model/lazy/LazyLoadRunMapEntrySet.java core/src/main/java/jenkins/model/lazy/AbstractLazyLoadRunMap.java core/src/test/java/jenkins/model/lazy/AbstractLazyLoadRunMapTest.java

            People

              jglick Jesse Glick
              jglick Jesse Glick
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: