Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-25655

AbstractLazyLoadRunMap.entrySet improperly cached

XMLWordPrintable

      JENKINS-18065 introduced a layer of caching which caused stale data to be reported under some conditions.

          [JENKINS-25655] AbstractLazyLoadRunMap.entrySet improperly cached

          Jesse Glick created issue -
          Jesse Glick made changes -
          Link New: This issue is blocking JENKINS-18065 [ JENKINS-18065 ]
          Jesse Glick made changes -
          Assignee New: Jesse Glick [ jglick ]
          Jesse Glick made changes -
          Status Original: Open [ 1 ] New: In Progress [ 3 ]
          Jesse Glick made changes -
          Labels Original: lazy-loading regression New: lazy-loading lts-candidate regression

          SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Jesse Glick
          Path:
          core/src/main/java/jenkins/model/lazy/AbstractLazyLoadRunMap.java
          core/src/main/java/jenkins/model/lazy/LazyLoadRunMapEntrySet.java
          core/src/test/java/jenkins/model/lazy/AbstractLazyLoadRunMapTest.java
          http://jenkins-ci.org/commit/jenkins/b76e7bf9988ebf5b3b7e2c5e588d5ce6dbde957e
          Log:
          [FIXED JENKINS-25655] Incorrect caching from entrySet sometimes caused incorrect results.
          Caused a failure in hudson.plugins.promoted_builds.conditions.ManualConditionTest.testManualPromotionProcessViaWebClient when run against 1.580.1.

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: core/src/main/java/jenkins/model/lazy/AbstractLazyLoadRunMap.java core/src/main/java/jenkins/model/lazy/LazyLoadRunMapEntrySet.java core/src/test/java/jenkins/model/lazy/AbstractLazyLoadRunMapTest.java http://jenkins-ci.org/commit/jenkins/b76e7bf9988ebf5b3b7e2c5e588d5ce6dbde957e Log: [FIXED JENKINS-25655] Incorrect caching from entrySet sometimes caused incorrect results. Caused a failure in hudson.plugins.promoted_builds.conditions.ManualConditionTest.testManualPromotionProcessViaWebClient when run against 1.580.1.
          SCM/JIRA link daemon made changes -
          Resolution New: Fixed [ 1 ]
          Status Original: In Progress [ 3 ] New: Resolved [ 5 ]

          dogfood added a comment -

          Integrated in jenkins_main_trunk #3825
          [FIXED JENKINS-25655] Incorrect caching from entrySet sometimes caused incorrect results. (Revision b76e7bf9988ebf5b3b7e2c5e588d5ce6dbde957e)

          Result = SUCCESS
          jesse glick : b76e7bf9988ebf5b3b7e2c5e588d5ce6dbde957e
          Files :

          • core/src/main/java/jenkins/model/lazy/LazyLoadRunMapEntrySet.java
          • core/src/test/java/jenkins/model/lazy/AbstractLazyLoadRunMapTest.java
          • core/src/main/java/jenkins/model/lazy/AbstractLazyLoadRunMap.java

          dogfood added a comment - Integrated in jenkins_main_trunk #3825 [FIXED JENKINS-25655] Incorrect caching from entrySet sometimes caused incorrect results. (Revision b76e7bf9988ebf5b3b7e2c5e588d5ce6dbde957e) Result = SUCCESS jesse glick : b76e7bf9988ebf5b3b7e2c5e588d5ce6dbde957e Files : core/src/main/java/jenkins/model/lazy/LazyLoadRunMapEntrySet.java core/src/test/java/jenkins/model/lazy/AbstractLazyLoadRunMapTest.java core/src/main/java/jenkins/model/lazy/AbstractLazyLoadRunMap.java
          Oliver Gondža made changes -
          Labels Original: lazy-loading lts-candidate regression New: 1.580.3-fixed lazy-loading regression

          SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Jesse Glick
          Path:
          core/src/main/java/jenkins/model/lazy/AbstractLazyLoadRunMap.java
          core/src/main/java/jenkins/model/lazy/LazyLoadRunMapEntrySet.java
          core/src/test/java/jenkins/model/lazy/AbstractLazyLoadRunMapTest.java
          http://jenkins-ci.org/commit/jenkins/bd0453fe98e33cd99df9920c822210e49ad5cb6e
          Log:
          [FIXED JENKINS-25655] Incorrect caching from entrySet sometimes caused incorrect results.
          Caused a failure in hudson.plugins.promoted_builds.conditions.ManualConditionTest.testManualPromotionProcessViaWebClient when run against 1.580.1.
          (cherry picked from commit b76e7bf9988ebf5b3b7e2c5e588d5ce6dbde957e)

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: core/src/main/java/jenkins/model/lazy/AbstractLazyLoadRunMap.java core/src/main/java/jenkins/model/lazy/LazyLoadRunMapEntrySet.java core/src/test/java/jenkins/model/lazy/AbstractLazyLoadRunMapTest.java http://jenkins-ci.org/commit/jenkins/bd0453fe98e33cd99df9920c822210e49ad5cb6e Log: [FIXED JENKINS-25655] Incorrect caching from entrySet sometimes caused incorrect results. Caused a failure in hudson.plugins.promoted_builds.conditions.ManualConditionTest.testManualPromotionProcessViaWebClient when run against 1.580.1. (cherry picked from commit b76e7bf9988ebf5b3b7e2c5e588d5ce6dbde957e)

            jglick Jesse Glick
            jglick Jesse Glick
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated:
              Resolved: