Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-2580

"Email Notification" action does not work as a Promotion plugin action

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Major Major
    • mailer-plugin
    • None
    • Platform: All, OS: All

      If you configure "E-mail Notification" as an action for a promotion it does not
      actually occur when the promotion occurs.

      Cause: Mailer extends Publisher extends BuildStepCompatibilityLayer without
      overriding BuildStepCompatibilityLayer's version of perform(AbstractBuild...)
      therefore perform() does nothing except return true.

      Fix: Override the new perform signature in Mailer.

      Getting this to work involved removing a whole swag of pointless generics in
      MailSender which doesn't actually care about the specific type of AbstractBuild
      or AbstractProject so wildcards can be used, simplifying things quite a lot.

        1. promotion_action_mailer.patch
          9 kB

          [JENKINS-2580] "Email Notification" action does not work as a Promotion plugin action

          brucechapman added a comment -

          Created an attachment (id=426)
          Patch relative to trunk

          brucechapman added a comment - Created an attachment (id=426) Patch relative to trunk

          brucechapman added a comment -

          patch attached

          brucechapman added a comment - patch attached

          SCM/JIRA link daemon added a comment -

          Code changed in hudson
          User: : brucechapman
          Path:
          trunk/hudson/main/core/src/main/java/hudson/maven/reporters/MavenMailer.java
          trunk/hudson/main/core/src/main/java/hudson/tasks/MailSender.java
          trunk/hudson/main/core/src/main/java/hudson/tasks/Mailer.java
          http://fisheye4.cenqua.com/changelog/hudson/?cs=14253
          Log:
          [FIX JENKINS-2580] "Email Notification" action does not work as a Promotion plugin action

          SCM/JIRA link daemon added a comment - Code changed in hudson User: : brucechapman Path: trunk/hudson/main/core/src/main/java/hudson/maven/reporters/MavenMailer.java trunk/hudson/main/core/src/main/java/hudson/tasks/MailSender.java trunk/hudson/main/core/src/main/java/hudson/tasks/Mailer.java http://fisheye4.cenqua.com/changelog/hudson/?cs=14253 Log: [FIX JENKINS-2580] "Email Notification" action does not work as a Promotion plugin action

          brucechapman added a comment -

          Patch applied

          brucechapman added a comment - Patch applied

            Unassigned Unassigned
            brucechapman brucechapman
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

              Created:
              Updated:
              Resolved: