Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-25889

InputStepExecution.node is null after restart

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Major Major
    • pipeline
    • None

      Restart Jenkins while it is paused at input, then click the Proceed link.

      java.lang.NullPointerException
	at org.jenkinsci.plugins.workflow.support.actions.PauseAction.getPauseActions(PauseAction.java:144)
	at org.jenkinsci.plugins.workflow.support.actions.PauseAction.getCurrentPause(PauseAction.java:102)
	at org.jenkinsci.plugins.workflow.support.actions.PauseAction.endCurrentPause(PauseAction.java:112)
	at org.jenkinsci.plugins.workflow.support.steps.input.InputStepExecution.postSettlement(InputStepExecution.java:201)
	at org.jenkinsci.plugins.workflow.support.steps.input.InputStepExecution.proceed(InputStepExecution.java:152)
	at org.jenkinsci.plugins.workflow.support.steps.input.InputStepExecution.doProceedEmpty(InputStepExecution.java:164)

      Somehow the FlowNode node is not getting reinjected.

          [JENKINS-25889] InputStepExecution.node is null after restart

          Jesse Glick created issue -

          Jesse Glick added a comment -

          Observed in WorkflowPluginTest.linearFlow, for example.

          Jesse Glick added a comment - Observed in WorkflowPluginTest.linearFlow , for example.
          Jesse Glick made changes -
          Assignee Original: Kohsuke Kawaguchi [ kohsuke ] New: Jesse Glick [ jglick ]
          Jesse Glick made changes -
          Status Original: Open [ 1 ] New: In Progress [ 3 ]
          Jesse Glick made changes -
          Remote Link New: This issue links to "PR 252 (Web Link)" [ 13537 ]

          Jesse Glick added a comment -

          node is getting reinjected in onResume, but there are two copies of the InputStepExecution.

          Jesse Glick added a comment - node is getting reinjected in onResume , but there are two copies of the InputStepExecution .

          Jesse Glick added a comment -

          The problem is InputAction.executions. This field is bogus. It should be storing just a list of IDs and looking up the InputStepExecution instances using some other API, probably FlowExecution.getCurrentExecutions.

          Jesse Glick added a comment - The problem is InputAction.executions . This field is bogus. It should be storing just a list of IDs and looking up the InputStepExecution instances using some other API, probably FlowExecution.getCurrentExecutions .

          SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Jesse Glick
          Path:
          CHANGES.md
          aggregator/src/test/java/org/jenkinsci/plugins/workflow/steps/input/InputStepRestartTest.java
          support/src/main/java/org/jenkinsci/plugins/workflow/support/steps/input/InputStepExecution.java
          http://jenkins-ci.org/commit/workflow-plugin/48ec7487f8b148e366c2ec9827c412b047eca651
          Log:
          JENKINS-25889 Ameliorated by reducing to a warning. Not a full fix.

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: CHANGES.md aggregator/src/test/java/org/jenkinsci/plugins/workflow/steps/input/InputStepRestartTest.java support/src/main/java/org/jenkinsci/plugins/workflow/support/steps/input/InputStepExecution.java http://jenkins-ci.org/commit/workflow-plugin/48ec7487f8b148e366c2ec9827c412b047eca651 Log: JENKINS-25889 Ameliorated by reducing to a warning. Not a full fix.

          SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Jesse Glick
          Path:
          aggregator/src/test/java/org/jenkinsci/plugins/workflow/steps/input/InputStepRestartTest.java
          aggregator/src/test/resources/org/jenkinsci/plugins/workflow/steps/input/InputStepRestartTest/oldFlow.zip
          support/src/main/java/org/jenkinsci/plugins/workflow/support/steps/input/InputAction.java
          support/src/main/java/org/jenkinsci/plugins/workflow/support/steps/input/InputStepExecution.java
          http://jenkins-ci.org/commit/workflow-plugin/92a1a756870e7fd7c9f44382eaf48ade880e8c79
          Log:
          [FIXED JENKINS-25889] InputAction was improperly storing InputStepExecution instances, which should only have been stored in the program data file, never XStream.
          (Arguably it should have no state at all—FlowExecution knows the running input steps; but that could have threading issues.)

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: aggregator/src/test/java/org/jenkinsci/plugins/workflow/steps/input/InputStepRestartTest.java aggregator/src/test/resources/org/jenkinsci/plugins/workflow/steps/input/InputStepRestartTest/oldFlow.zip support/src/main/java/org/jenkinsci/plugins/workflow/support/steps/input/InputAction.java support/src/main/java/org/jenkinsci/plugins/workflow/support/steps/input/InputStepExecution.java http://jenkins-ci.org/commit/workflow-plugin/92a1a756870e7fd7c9f44382eaf48ade880e8c79 Log: [FIXED JENKINS-25889] InputAction was improperly storing InputStepExecution instances, which should only have been stored in the program data file, never XStream. (Arguably it should have no state at all—FlowExecution knows the running input steps; but that could have threading issues.)
          SCM/JIRA link daemon made changes -
          Resolution New: Fixed [ 1 ]
          Status Original: In Progress [ 3 ] New: Resolved [ 5 ]

            jglick Jesse Glick
            jglick Jesse Glick
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated:
              Resolved: