Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-25889

InputStepExecution.node is null after restart

    XMLWordPrintable

Details

    • Bug
    • Status: Resolved (View Workflow)
    • Major
    • Resolution: Fixed
    • pipeline
    • None

    Description

      Restart Jenkins while it is paused at input, then click the Proceed link.

      java.lang.NullPointerException
      	at org.jenkinsci.plugins.workflow.support.actions.PauseAction.getPauseActions(PauseAction.java:144)
      	at org.jenkinsci.plugins.workflow.support.actions.PauseAction.getCurrentPause(PauseAction.java:102)
      	at org.jenkinsci.plugins.workflow.support.actions.PauseAction.endCurrentPause(PauseAction.java:112)
      	at org.jenkinsci.plugins.workflow.support.steps.input.InputStepExecution.postSettlement(InputStepExecution.java:201)
      	at org.jenkinsci.plugins.workflow.support.steps.input.InputStepExecution.proceed(InputStepExecution.java:152)
      	at org.jenkinsci.plugins.workflow.support.steps.input.InputStepExecution.doProceedEmpty(InputStepExecution.java:164)
      

      Somehow the FlowNode node is not getting reinjected.

      Attachments

        Issue Links

          Activity

            Code changed in jenkins
            User: Jesse Glick
            Path:
            CHANGES.md
            aggregator/src/test/java/org/jenkinsci/plugins/workflow/steps/input/InputStepRestartTest.java
            aggregator/src/test/resources/org/jenkinsci/plugins/workflow/steps/input/InputStepRestartTest/oldFlow.zip
            support/src/main/java/org/jenkinsci/plugins/workflow/support/steps/input/InputAction.java
            support/src/main/java/org/jenkinsci/plugins/workflow/support/steps/input/InputStepExecution.java
            http://jenkins-ci.org/commit/workflow-plugin/e175d3c8af43424c0f38ba4fec843d5871321058
            Log:
            Merge pull request #252 from jglick/JENKINS-25889

            JENKINS-25889 InputStepExecution.node null after restart

            Compare: https://github.com/jenkinsci/workflow-plugin/compare/00e510865fb8...e175d3c8af43

            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: CHANGES.md aggregator/src/test/java/org/jenkinsci/plugins/workflow/steps/input/InputStepRestartTest.java aggregator/src/test/resources/org/jenkinsci/plugins/workflow/steps/input/InputStepRestartTest/oldFlow.zip support/src/main/java/org/jenkinsci/plugins/workflow/support/steps/input/InputAction.java support/src/main/java/org/jenkinsci/plugins/workflow/support/steps/input/InputStepExecution.java http://jenkins-ci.org/commit/workflow-plugin/e175d3c8af43424c0f38ba4fec843d5871321058 Log: Merge pull request #252 from jglick/ JENKINS-25889 JENKINS-25889 InputStepExecution.node null after restart Compare: https://github.com/jenkinsci/workflow-plugin/compare/00e510865fb8...e175d3c8af43

            Code changed in jenkins
            User: Jesse Glick
            Path:
            support/src/main/java/org/jenkinsci/plugins/workflow/support/actions/PauseAction.java
            http://jenkins-ci.org/commit/workflow-support-plugin/bfc249a652644c0bde5b3bd210223cf665c9b712
            Log:
            JENKINS-25889 Annotations related to an NPE.
            Originally-Committed-As: 54ac1d186d94dd7af10bd0dd11aed478ad1ffc65

            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: support/src/main/java/org/jenkinsci/plugins/workflow/support/actions/PauseAction.java http://jenkins-ci.org/commit/workflow-support-plugin/bfc249a652644c0bde5b3bd210223cf665c9b712 Log: JENKINS-25889 Annotations related to an NPE. Originally-Committed-As: 54ac1d186d94dd7af10bd0dd11aed478ad1ffc65

            Code changed in jenkins
            User: Jesse Glick
            Path:
            aggregator/src/test/java/org/jenkinsci/plugins/workflow/steps/input/InputStepRestartTest.java
            support/src/main/java/org/jenkinsci/plugins/workflow/support/steps/input/InputStep.java
            support/src/main/java/org/jenkinsci/plugins/workflow/support/steps/input/InputStepExecution.java
            http://jenkins-ci.org/commit/pipeline-input-step-plugin/df6b20c9cbbdb5279139d29f0450bb603cb07ed9
            Log:
            Actually fixing restartability of input step.
            (Turns out an injected Step is not resumed, so you need to clone it if you need it later!)
            JENKINS-25889 still broken but this does not seem to be critical.
            Originally-Committed-As: f1ea316dd7af44170f7f0745bf20167774b212a6

            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: aggregator/src/test/java/org/jenkinsci/plugins/workflow/steps/input/InputStepRestartTest.java support/src/main/java/org/jenkinsci/plugins/workflow/support/steps/input/InputStep.java support/src/main/java/org/jenkinsci/plugins/workflow/support/steps/input/InputStepExecution.java http://jenkins-ci.org/commit/pipeline-input-step-plugin/df6b20c9cbbdb5279139d29f0450bb603cb07ed9 Log: Actually fixing restartability of input step. (Turns out an injected Step is not resumed, so you need to clone it if you need it later!) JENKINS-25889 still broken but this does not seem to be critical. Originally-Committed-As: f1ea316dd7af44170f7f0745bf20167774b212a6

            Code changed in jenkins
            User: Jesse Glick
            Path:
            aggregator/src/test/java/org/jenkinsci/plugins/workflow/steps/input/InputStepRestartTest.java
            support/src/main/java/org/jenkinsci/plugins/workflow/support/steps/input/InputStepExecution.java
            http://jenkins-ci.org/commit/pipeline-input-step-plugin/5cc9b9130fa2cecbffa1ed34347fae0618483d91
            Log:
            JENKINS-25889 Ameliorated by reducing to a warning. Not a full fix.
            Originally-Committed-As: 48ec7487f8b148e366c2ec9827c412b047eca651

            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: aggregator/src/test/java/org/jenkinsci/plugins/workflow/steps/input/InputStepRestartTest.java support/src/main/java/org/jenkinsci/plugins/workflow/support/steps/input/InputStepExecution.java http://jenkins-ci.org/commit/pipeline-input-step-plugin/5cc9b9130fa2cecbffa1ed34347fae0618483d91 Log: JENKINS-25889 Ameliorated by reducing to a warning. Not a full fix. Originally-Committed-As: 48ec7487f8b148e366c2ec9827c412b047eca651

            Code changed in jenkins
            User: Jesse Glick
            Path:
            aggregator/src/test/java/org/jenkinsci/plugins/workflow/steps/input/InputStepRestartTest.java
            aggregator/src/test/resources/org/jenkinsci/plugins/workflow/steps/input/InputStepRestartTest/oldFlow.zip
            support/src/main/java/org/jenkinsci/plugins/workflow/support/steps/input/InputAction.java
            support/src/main/java/org/jenkinsci/plugins/workflow/support/steps/input/InputStepExecution.java
            http://jenkins-ci.org/commit/pipeline-input-step-plugin/acb1337ec4677ec6808bcdb03bfe4f9d675f1a4c
            Log:
            [FIXED JENKINS-25889] InputAction was improperly storing InputStepExecution instances, which should only have been stored in the program data file, never XStream.
            (Arguably it should have no state at all—FlowExecution knows the running input steps; but that could have threading issues.)
            Originally-Committed-As: 92a1a756870e7fd7c9f44382eaf48ade880e8c79

            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: aggregator/src/test/java/org/jenkinsci/plugins/workflow/steps/input/InputStepRestartTest.java aggregator/src/test/resources/org/jenkinsci/plugins/workflow/steps/input/InputStepRestartTest/oldFlow.zip support/src/main/java/org/jenkinsci/plugins/workflow/support/steps/input/InputAction.java support/src/main/java/org/jenkinsci/plugins/workflow/support/steps/input/InputStepExecution.java http://jenkins-ci.org/commit/pipeline-input-step-plugin/acb1337ec4677ec6808bcdb03bfe4f9d675f1a4c Log: [FIXED JENKINS-25889] InputAction was improperly storing InputStepExecution instances, which should only have been stored in the program data file, never XStream. (Arguably it should have no state at all—FlowExecution knows the running input steps; but that could have threading issues.) Originally-Committed-As: 92a1a756870e7fd7c9f44382eaf48ade880e8c79

            People

              jglick Jesse Glick
              jglick Jesse Glick
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: