Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-25953

Layout - Tabs in job view are layouted in wrong way

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Major Major
    • core
    • Jenkins ver. 1.580.1. Mac. Chrome browser

      Take a look at screen shots, when I select tab "test4" there is extra padding in whole next line, "test7" begin just after "test4" in second line.
      When "test6" is selected it looks fine.

        1. Screen Shot 2014-12-07 at 13.36.22.png
          Screen Shot 2014-12-07 at 13.36.22.png
          84 kB
        2. Screen Shot 2014-12-07 at 13.36.38.png
          Screen Shot 2014-12-07 at 13.36.38.png
          83 kB
        3. Screen Shot 2014-12-07 at 13.55.50.png
          Screen Shot 2014-12-07 at 13.55.50.png
          166 kB

          [JENKINS-25953] Layout - Tabs in job view are layouted in wrong way

          Piotr Wielgołaski added a comment -

          Fix in pull request https://github.com/jenkinsci/jenkins/pull/1483

          Piotr Wielgołaski added a comment - Fix in pull request https://github.com/jenkinsci/jenkins/pull/1483

          Baskaran D added a comment -

          @PiotrWielgolaski - Tested your fix and it didnt work for me. I have updated the code @ https://github.com/jenkinsci/jenkins/pull/1544. Please take a look at it.

          Baskaran D added a comment - @PiotrWielgolaski - Tested your fix and it didnt work for me. I have updated the code @ https://github.com/jenkinsci/jenkins/pull/1544 . Please take a look at it.

          Danilo Saita added a comment - - edited

          I have the same problem on 1.596 - Chrome Version 39.0.2171.71 (64-bit)

          Is the issue really in progress?

          Danilo Saita added a comment - - edited I have the same problem on 1.596 - Chrome Version 39.0.2171.71 (64-bit) Is the issue really in progress?

          Baskaran D added a comment -

          The fix is under code review. Its yet to be merged.

          Baskaran D added a comment - The fix is under code review. Its yet to be merged.

          Baskaran D added a comment -

          Closed https://github.com/jenkinsci/jenkins/pull/1544.

          @PiotrWielgolaski's Pull request should work fine. - https://github.com/jenkinsci/jenkins/pull/1483

          Baskaran D added a comment - Closed https://github.com/jenkinsci/jenkins/pull/1544 . @PiotrWielgolaski's Pull request should work fine. - https://github.com/jenkinsci/jenkins/pull/1483

          SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Piotr Wielgolaski
          Path:
          war/src/main/webapp/css/style.css
          http://jenkins-ci.org/commit/jenkins/70613202f1177ce83e1d9d724a8b21ca9c222cd3
          Log:
          JENKINS-25953Tabs in job view are layouted in wrong way

          make equal height of tab regardless if selected or not

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Piotr Wielgolaski Path: war/src/main/webapp/css/style.css http://jenkins-ci.org/commit/jenkins/70613202f1177ce83e1d9d724a8b21ca9c222cd3 Log: JENKINS-25953 Tabs in job view are layouted in wrong way make equal height of tab regardless if selected or not

          SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Daniel Beck
          Path:
          war/src/main/webapp/css/style.css
          http://jenkins-ci.org/commit/jenkins/27dbc6bc588b2a6b44fda7238207994c197a5e2d
          Log:
          Merge pull request #1483 from pwielgolaski/JENKINS-25953

          [FIXED JENKINS-25953]Tabs in job view are layouted in wrong way

          Compare: https://github.com/jenkinsci/jenkins/compare/17baaf7151fb...27dbc6bc588b

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Daniel Beck Path: war/src/main/webapp/css/style.css http://jenkins-ci.org/commit/jenkins/27dbc6bc588b2a6b44fda7238207994c197a5e2d Log: Merge pull request #1483 from pwielgolaski/ JENKINS-25953 [FIXED JENKINS-25953] Tabs in job view are layouted in wrong way Compare: https://github.com/jenkinsci/jenkins/compare/17baaf7151fb...27dbc6bc588b

          dogfood added a comment -

          Integrated in jenkins_main_trunk #3971
          JENKINS-25953Tabs in job view are layouted in wrong way (Revision 70613202f1177ce83e1d9d724a8b21ca9c222cd3)

          Result = SUCCESS
          pwielgolaski : 70613202f1177ce83e1d9d724a8b21ca9c222cd3
          Files :

          • war/src/main/webapp/css/style.css

          dogfood added a comment - Integrated in jenkins_main_trunk #3971 JENKINS-25953 Tabs in job view are layouted in wrong way (Revision 70613202f1177ce83e1d9d724a8b21ca9c222cd3) Result = SUCCESS pwielgolaski : 70613202f1177ce83e1d9d724a8b21ca9c222cd3 Files : war/src/main/webapp/css/style.css

          SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Piotr Wielgolaski
          Path:
          war/src/main/webapp/css/style.css
          http://jenkins-ci.org/commit/jenkins/f624aab02251fa7d4d97b05d41954d5dc34575a0
          Log:
          JENKINS-25953Tabs in job view are layouted in wrong way

          make equal height of tab regardless if selected or not

          (cherry picked from commit 70613202f1177ce83e1d9d724a8b21ca9c222cd3)

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Piotr Wielgolaski Path: war/src/main/webapp/css/style.css http://jenkins-ci.org/commit/jenkins/f624aab02251fa7d4d97b05d41954d5dc34575a0 Log: JENKINS-25953 Tabs in job view are layouted in wrong way make equal height of tab regardless if selected or not (cherry picked from commit 70613202f1177ce83e1d9d724a8b21ca9c222cd3)

          dogfood added a comment -

          Integrated in jenkins_main_trunk #4292
          JENKINS-25953Tabs in job view are layouted in wrong way (Revision f624aab02251fa7d4d97b05d41954d5dc34575a0)

          Result = UNSTABLE
          ogondza : f624aab02251fa7d4d97b05d41954d5dc34575a0
          Files :

          • war/src/main/webapp/css/style.css

          dogfood added a comment - Integrated in jenkins_main_trunk #4292 JENKINS-25953 Tabs in job view are layouted in wrong way (Revision f624aab02251fa7d4d97b05d41954d5dc34575a0) Result = UNSTABLE ogondza : f624aab02251fa7d4d97b05d41954d5dc34575a0 Files : war/src/main/webapp/css/style.css

            Unassigned Unassigned
            pwielgolaski Piotr Wielgołaski
            Votes:
            3 Vote for this issue
            Watchers:
            7 Start watching this issue

              Created:
              Updated:
              Resolved: