Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-26050

Workflow integration for Parameterized Trigger

    XMLWordPrintable

Details

    Description

      Currently hudson.plugins.parameterizedtrigger.BuildTriggerConfig and related classes is designed to assume that the downstream project is an AbstractProject, preventing it from triggering a WorkflowJob in schedule (see also perform, perform2, DescriptorImpl.doCheckProjects, etc.).

      This could probably be relaxed by just checking for a Job & Queue.Task from which you can schedule a job with a little difficulty (check ParameterizedJob.getQuietPeriod and Job.isBuildable); or perhaps SCMTriggerItem whose scheduleBuild2 is more convenient.

      Should work smoothly for TriggerBuilder. For BuildTrigger, can work to the extent that canDeclare is made to be false, so that the triggering is done explicitly rather than via DependencyDeclarer (and thus the DependencyGraph, which at least for now is restricted to AbstractProject).

      Attachments

        Issue Links

          depends on

          Bug - A problem which impairs or prevents the functions of the product. JENKINS-30040 Parameterised Trigger Plugin succeeds, then reports failure for workflow jobs.

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Resolved
          is duplicated by

          Improvement - An improvement or enhancement to an existing feature or task. JENKINS-27965 Can't trigger workflow job as job from freestyle or multijob project

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Resolved
          is related to

          Task - A task that needs to be done. JENKINS-29913 Generalize DependencyGraph to Job (or ParameterizedJobMixIn)

          • Major - Major loss of function.
          • Open

          Bug - A problem which impairs or prevents the functions of the product. JENKINS-26009 Cannot trigger workflow projects using parameterized-trigger-plugin

          • Major - Major loss of function.
          • Resolved

          Bug - A problem which impairs or prevents the functions of the product. JENKINS-28071 BuildCommand limited to AbstractProject

          • Major - Major loss of function.
          • Resolved

          Bug - A problem which impairs or prevents the functions of the product. JENKINS-28113 BuildTrigger should accept any ParameterizedJob downstream

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Resolved
          links to

          Web Link In-progress PR

          Activity

            Ascending order - Click to sort in descending order
            View 6 older comments
            svanoort Sam Van Oort added a comment -

            Resolved with https://github.com/jenkinsci/parameterized-trigger-plugin/pull/87
            As of version 2.28

            svanoort Sam Van Oort added a comment - Resolved with https://github.com/jenkinsci/parameterized-trigger-plugin/pull/87 As of version 2.28
            veen Vegard Endresen added a comment -

            Version 2.28 works, nice!

            As a comment the upstream/downstream relationships is not visible in the web browser/API. I think this would be nice to have.

            veen Vegard Endresen added a comment - Version 2.28 works, nice! As a comment the upstream/downstream relationships is not visible in the web browser/API. I think this would be nice to have.
            jglick Jesse Glick added a comment -

            the upstream/downstream relationships is not visible in the web browser/API

            This is not possible from the plugin currently since DependencyGraph is currently limited to AbstractProject. I filed JENKINS-29913 to track it.

            jglick Jesse Glick added a comment - the upstream/downstream relationships is not visible in the web browser/API This is not possible from the plugin currently since DependencyGraph is currently limited to AbstractProject . I filed JENKINS-29913 to track it.
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Jesse Glick
            Path:
            COMPATIBILITY.md
            http://jenkins-ci.org/commit/workflow-plugin/ad0ae293d06a22284930bf6bb4f7096b2f357771
            Log:
            JENKINS-26050 Noting release.

            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: COMPATIBILITY.md http://jenkins-ci.org/commit/workflow-plugin/ad0ae293d06a22284930bf6bb4f7096b2f357771 Log: JENKINS-26050 Noting release.
            qtruong77 Quang Truong added a comment -

            Should we add update to BuildInfoExporterAction.java to support for Workflow too? We still use AbstractProject and AbstractBuild instead of Job and Run so BuildInfoExporterAction.getTriggeredProjects() and BuildInfoExporterAction.getTriggeredBuilds() will return a non-empty list but the workflow item is a null item.

            qtruong77 Quang Truong added a comment - Should we add update to BuildInfoExporterAction.java to support for Workflow too? We still use AbstractProject and AbstractBuild instead of Job and Run so BuildInfoExporterAction.getTriggeredProjects() and BuildInfoExporterAction.getTriggeredBuilds() will return a non-empty list but the workflow item is a null item.

            People

              svanoort Sam Van Oort
              jglick Jesse Glick
              Votes:
              15 Vote for this issue
              Watchers:
              22 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: