Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-28113

BuildTrigger should accept any ParameterizedJob downstream

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Minor Minor
    • core

      ReverseBuildTrigger supports any ParameterizedJob, behaving as a DependencyDeclarer if both sides are AbstractProject, behaving as a simple Trigger otherwise. BuildTrigger should do the same, behaving as a DependencyDeclarer as now if both sides are AbstractProject, behaving as a simple Notifier otherwise.

      Would allow Build other projects to select a workflow job. Workarounds: JENKINS-26050, if implemented; use of ReverseBuildTrigger, in the common case that it does not matter which side declares the trigger (but not when Item.CONFIGURE is restricted on one side, job templates are in use, etc.).

          [JENKINS-28113] BuildTrigger should accept any ParameterizedJob downstream

          Code changed in jenkins
          User: Jesse Glick
          Path:
          core/src/main/java/hudson/model/AbstractProject.java
          core/src/main/java/hudson/tasks/BuildTrigger.java
          http://jenkins-ci.org/commit/jenkins/f1a26582c1b25c470989d19b25378cff5c6d2497
          Log:
          JENKINS-28113 Allow freestyle builds to trigger downstream Pipeline builds (#2873)

          • Offering default methods on ParameterizedJob.
          • Javadoc typo.
          • Cleaner use of default methods in ParameterizedJob.
          • Sketch of pulling disabled functionality into ParameterizedJob.
          • EnableJobCommandTest.groovy → EnableJobCommandTest.java, and replacing deprecated Remoting-based CLI calls with CLICommandInvoker.
          • All CLI commands could be broken by a missing CLI.*.shortDescription key on just one!
          • Forgot to move CLI method short descriptions to new package.
          • Needed a @CLIResolver for ParameterizedJob. Adding an OptionHandler while we are here.
          • Trying to fix up access-modifier versions; started failing in CI today for unknown reasons.
          • Introduced <p:makeDisabled/> by analogy with <p:config-disableBuild/>.
          • Using new type bounds.
          • access-modifier 1.11 released.
          • MatrixProject and MavenModuleSet both expect to have access to makeDisabled.jelly.
          • Trying to generalize some more.
          • Minor simplification.
          • isBuildable
          • Obsolete comment.
          • Updated comments.
          • bridge-method-injector 1.17
          • Unfortunately AbstractProject.schedulePolling cannot delegate to SCMTriggerItem.
          • [FIXED JENKINS-28113] Generalize BuildTrigger to be able to trigger non-AbstractProject downstream ParameterizedJob’s without DependencyGraph.
          • JENKINS-22949 Dropping QueueItemAuthenticator trickiness, as in #2881.

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: core/src/main/java/hudson/model/AbstractProject.java core/src/main/java/hudson/tasks/BuildTrigger.java http://jenkins-ci.org/commit/jenkins/f1a26582c1b25c470989d19b25378cff5c6d2497 Log: JENKINS-28113 Allow freestyle builds to trigger downstream Pipeline builds (#2873) Offering default methods on ParameterizedJob. Javadoc typo. Cleaner use of default methods in ParameterizedJob. Need to pick up https://github.com/infradna/bridge-method-injector/pull/15 to be able to build. Sketch of pulling disabled functionality into ParameterizedJob. EnableJobCommandTest.groovy → EnableJobCommandTest.java, and replacing deprecated Remoting-based CLI calls with CLICommandInvoker. All CLI commands could be broken by a missing CLI.*.shortDescription key on just one! Forgot to move CLI method short descriptions to new package. Needed a @CLIResolver for ParameterizedJob. Adding an OptionHandler while we are here. Trying to fix up access-modifier versions; started failing in CI today for unknown reasons. Introduced <p:makeDisabled/> by analogy with <p:config-disableBuild/>. Using new type bounds. access-modifier 1.11 released. MatrixProject and MavenModuleSet both expect to have access to makeDisabled.jelly. Trying to generalize some more. Minor simplification. JENKINS-34716 Generalizing doPolling and schedulePolling. isBuildable Obsolete comment. Updated comments. bridge-method-injector 1.17 Unfortunately AbstractProject.schedulePolling cannot delegate to SCMTriggerItem. [FIXED JENKINS-28113] Generalize BuildTrigger to be able to trigger non-AbstractProject downstream ParameterizedJob’s without DependencyGraph. JENKINS-22949 Dropping QueueItemAuthenticator trickiness, as in #2881.

          Daniel Beck added a comment -

          Fixed towards 2.61.

          Daniel Beck added a comment - Fixed towards 2.61.

          Code changed in jenkins
          User: Jesse Glick
          Path:
          pom.xml
          src/test/java/org/jenkinsci/plugins/workflow/job/BuildTriggerTest.java
          src/test/java/org/jenkinsci/plugins/workflow/job/ReverseBuildTriggerTest.java
          http://jenkins-ci.org/commit/workflow-job-plugin/f4e8795cd27578cdf904c91b187e5b8975584d80
          Log:
          JENKINS-28113 Integration test of BuildTrigger with WorkflowJob downstream.

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: pom.xml src/test/java/org/jenkinsci/plugins/workflow/job/BuildTriggerTest.java src/test/java/org/jenkinsci/plugins/workflow/job/ReverseBuildTriggerTest.java http://jenkins-ci.org/commit/workflow-job-plugin/f4e8795cd27578cdf904c91b187e5b8975584d80 Log: JENKINS-28113 Integration test of BuildTrigger with WorkflowJob downstream.

          Code changed in jenkins
          User: Jesse Glick
          Path:
          src/test/java/org/jenkinsci/plugins/workflow/job/BuildTriggerTest.java
          src/test/java/org/jenkinsci/plugins/workflow/job/ReverseBuildTriggerTest.java
          http://jenkins-ci.org/commit/workflow-job-plugin/33944ba447655c594796a294bce379041ea48f5f
          Log:
          Merge pull request #48 from jglick/BuildTrigger-ParameterizedJob-JENKINS-28113

          JENKINS-28113 BuildTrigger integration test

          Compare: https://github.com/jenkinsci/workflow-job-plugin/compare/8da02e98393c...33944ba44765

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: src/test/java/org/jenkinsci/plugins/workflow/job/BuildTriggerTest.java src/test/java/org/jenkinsci/plugins/workflow/job/ReverseBuildTriggerTest.java http://jenkins-ci.org/commit/workflow-job-plugin/33944ba447655c594796a294bce379041ea48f5f Log: Merge pull request #48 from jglick/BuildTrigger-ParameterizedJob- JENKINS-28113 JENKINS-28113 BuildTrigger integration test Compare: https://github.com/jenkinsci/workflow-job-plugin/compare/8da02e98393c...33944ba44765

            jglick Jesse Glick
            jglick Jesse Glick
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated:
              Resolved: