A replacement for SecretBuildWrapper that is a Step (with invokeBodyLater) rather than a BuildWrapper, probably returning the binding(s) in a map.

      Means some API changes to Binding. bind must take a FilePath workspace (and maybe Run run) rather than AbstractBuild build. And Environment must be declared Serializable, since unbind may be called in another session.

          [JENKINS-26051] Workflow integration for Credentials Binding

          Code changed in jenkins
          User: Jesse Glick
          Path:
          pom.xml
          src/main/java/org/jenkinsci/plugins/credentialsbinding/Binding.java
          src/main/java/org/jenkinsci/plugins/credentialsbinding/MultiBinding.java
          src/main/java/org/jenkinsci/plugins/credentialsbinding/impl/BindingStep.java
          src/main/java/org/jenkinsci/plugins/credentialsbinding/impl/FileBinding.java
          src/main/java/org/jenkinsci/plugins/credentialsbinding/impl/SecretBuildWrapper.java
          src/main/java/org/jenkinsci/plugins/credentialsbinding/impl/StringBinding.java
          src/main/java/org/jenkinsci/plugins/credentialsbinding/impl/UsernamePasswordBinding.java
          src/main/java/org/jenkinsci/plugins/credentialsbinding/impl/UsernamePasswordMultiBinding.java
          src/main/resources/org/jenkinsci/plugins/credentialsbinding/impl/BindingStep/config.jelly
          src/main/resources/org/jenkinsci/plugins/credentialsbinding/impl/BindingStep/help-bindings.html
          src/main/resources/org/jenkinsci/plugins/credentialsbinding/impl/BindingStep/help.html
          http://jenkins-ci.org/commit/credentials-binding-plugin/f23dd15d1098d1d2873f6f8c1c97a9cee82c9c53
          Log:
          JENKINS-26051 First draft of withCredentials step.

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: pom.xml src/main/java/org/jenkinsci/plugins/credentialsbinding/Binding.java src/main/java/org/jenkinsci/plugins/credentialsbinding/MultiBinding.java src/main/java/org/jenkinsci/plugins/credentialsbinding/impl/BindingStep.java src/main/java/org/jenkinsci/plugins/credentialsbinding/impl/FileBinding.java src/main/java/org/jenkinsci/plugins/credentialsbinding/impl/SecretBuildWrapper.java src/main/java/org/jenkinsci/plugins/credentialsbinding/impl/StringBinding.java src/main/java/org/jenkinsci/plugins/credentialsbinding/impl/UsernamePasswordBinding.java src/main/java/org/jenkinsci/plugins/credentialsbinding/impl/UsernamePasswordMultiBinding.java src/main/resources/org/jenkinsci/plugins/credentialsbinding/impl/BindingStep/config.jelly src/main/resources/org/jenkinsci/plugins/credentialsbinding/impl/BindingStep/help-bindings.html src/main/resources/org/jenkinsci/plugins/credentialsbinding/impl/BindingStep/help.html http://jenkins-ci.org/commit/credentials-binding-plugin/f23dd15d1098d1d2873f6f8c1c97a9cee82c9c53 Log: JENKINS-26051 First draft of withCredentials step.

          Code changed in jenkins
          User: Jesse Glick
          Path:
          pom.xml
          src/test/java/org/jenkinsci/plugins/credentialsbinding/impl/BindingStepTest.java
          http://jenkins-ci.org/commit/credentials-binding-plugin/707c1d82c1efa0c42e8daff6d487196c2c6dacbd
          Log:
          Trying to test JENKINS-26051 across restarts but blocked by JENKINS-26137.

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: pom.xml src/test/java/org/jenkinsci/plugins/credentialsbinding/impl/BindingStepTest.java http://jenkins-ci.org/commit/credentials-binding-plugin/707c1d82c1efa0c42e8daff6d487196c2c6dacbd Log: Trying to test JENKINS-26051 across restarts but blocked by JENKINS-26137 .

          Code changed in jenkins
          User: Jesse Glick
          Path:
          aggregator/src/test/java/org/jenkinsci/plugins/workflow/steps/PushdStepTest.java
          support/src/main/java/org/jenkinsci/plugins/workflow/support/pickles/serialization/RiverWriter.java
          http://jenkins-ci.org/commit/workflow-plugin/3d3fa348ed9c34e4492b2733802bc47416824e30
          Log:
          JENKINS-26137 At least during restarting tests, serialization errors seem to be due to there being no PickleFactory’s installed.
          Merely calling PickleFactory.all() from the RiverWriter constructor, rather than later, seems to let PushdStepTest.restarting pass (JENKINS-26051).
          Additionally asserting that there are in fact some factories loaded, since there is sure to be trouble if there are not.
          Also need to wait for the build to finish (JENKINS-26399).

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: aggregator/src/test/java/org/jenkinsci/plugins/workflow/steps/PushdStepTest.java support/src/main/java/org/jenkinsci/plugins/workflow/support/pickles/serialization/RiverWriter.java http://jenkins-ci.org/commit/workflow-plugin/3d3fa348ed9c34e4492b2733802bc47416824e30 Log: JENKINS-26137 At least during restarting tests, serialization errors seem to be due to there being no PickleFactory’s installed. Merely calling PickleFactory.all() from the RiverWriter constructor, rather than later, seems to let PushdStepTest.restarting pass ( JENKINS-26051 ). Additionally asserting that there are in fact some factories loaded, since there is sure to be trouble if there are not. Also need to wait for the build to finish ( JENKINS-26399 ).

          Code changed in jenkins
          User: Jesse Glick
          Path:
          pom.xml
          src/main/java/org/jenkinsci/plugins/credentialsbinding/Binding.java
          src/main/java/org/jenkinsci/plugins/credentialsbinding/MultiBinding.java
          src/main/java/org/jenkinsci/plugins/credentialsbinding/impl/BindingStep.java
          src/main/java/org/jenkinsci/plugins/credentialsbinding/impl/FileBinding.java
          src/main/java/org/jenkinsci/plugins/credentialsbinding/impl/SecretBuildWrapper.java
          src/main/java/org/jenkinsci/plugins/credentialsbinding/impl/StringBinding.java
          src/main/java/org/jenkinsci/plugins/credentialsbinding/impl/UsernamePasswordBinding.java
          src/main/java/org/jenkinsci/plugins/credentialsbinding/impl/UsernamePasswordMultiBinding.java
          src/main/resources/org/jenkinsci/plugins/credentialsbinding/impl/BindingStep/config.jelly
          src/main/resources/org/jenkinsci/plugins/credentialsbinding/impl/BindingStep/help.html
          src/test/java/org/jenkinsci/plugins/credentialsbinding/impl/BindingStepTest.java
          http://jenkins-ci.org/commit/credentials-binding-plugin/15908dbe49b8184ba327b3d480ac10ba2a09e6b4
          Log:
          Merge pull request #3 from jenkinsci/workflow-JENKINS-26051

          [FIXED JENKINS-26051] withCredentials step

          Compare: https://github.com/jenkinsci/credentials-binding-plugin/compare/91e5d8e1a9af...15908dbe49b8

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: pom.xml src/main/java/org/jenkinsci/plugins/credentialsbinding/Binding.java src/main/java/org/jenkinsci/plugins/credentialsbinding/MultiBinding.java src/main/java/org/jenkinsci/plugins/credentialsbinding/impl/BindingStep.java src/main/java/org/jenkinsci/plugins/credentialsbinding/impl/FileBinding.java src/main/java/org/jenkinsci/plugins/credentialsbinding/impl/SecretBuildWrapper.java src/main/java/org/jenkinsci/plugins/credentialsbinding/impl/StringBinding.java src/main/java/org/jenkinsci/plugins/credentialsbinding/impl/UsernamePasswordBinding.java src/main/java/org/jenkinsci/plugins/credentialsbinding/impl/UsernamePasswordMultiBinding.java src/main/resources/org/jenkinsci/plugins/credentialsbinding/impl/BindingStep/config.jelly src/main/resources/org/jenkinsci/plugins/credentialsbinding/impl/BindingStep/help.html src/test/java/org/jenkinsci/plugins/credentialsbinding/impl/BindingStepTest.java http://jenkins-ci.org/commit/credentials-binding-plugin/15908dbe49b8184ba327b3d480ac10ba2a09e6b4 Log: Merge pull request #3 from jenkinsci/workflow- JENKINS-26051 [FIXED JENKINS-26051] withCredentials step Compare: https://github.com/jenkinsci/credentials-binding-plugin/compare/91e5d8e1a9af...15908dbe49b8

          Code changed in jenkins
          User: Jesse Glick
          Path:
          COMPATIBILITY.md
          http://jenkins-ci.org/commit/workflow-plugin/5a9ae5b6704a95e548db86333ebccbbaceba56f3
          Log:
          JENKINS-26051 Noting.

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: COMPATIBILITY.md http://jenkins-ci.org/commit/workflow-plugin/5a9ae5b6704a95e548db86333ebccbbaceba56f3 Log: JENKINS-26051 Noting.

          Code changed in jenkins
          User: Jesse Glick
          Path:
          support/src/main/java/org/jenkinsci/plugins/workflow/support/pickles/serialization/RiverWriter.java
          http://jenkins-ci.org/commit/workflow-support-plugin/18ad074331b663f565633bf4fa8523ac68dc1a69
          Log:
          JENKINS-26137 At least during restarting tests, serialization errors seem to be due to there being no PickleFactory’s installed.
          Merely calling PickleFactory.all() from the RiverWriter constructor, rather than later, seems to let PushdStepTest.restarting pass (JENKINS-26051).
          Additionally asserting that there are in fact some factories loaded, since there is sure to be trouble if there are not.
          Also need to wait for the build to finish (JENKINS-26399).
          Originally-Committed-As: 3d3fa348ed9c34e4492b2733802bc47416824e30

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: support/src/main/java/org/jenkinsci/plugins/workflow/support/pickles/serialization/RiverWriter.java http://jenkins-ci.org/commit/workflow-support-plugin/18ad074331b663f565633bf4fa8523ac68dc1a69 Log: JENKINS-26137 At least during restarting tests, serialization errors seem to be due to there being no PickleFactory’s installed. Merely calling PickleFactory.all() from the RiverWriter constructor, rather than later, seems to let PushdStepTest.restarting pass ( JENKINS-26051 ). Additionally asserting that there are in fact some factories loaded, since there is sure to be trouble if there are not. Also need to wait for the build to finish ( JENKINS-26399 ). Originally-Committed-As: 3d3fa348ed9c34e4492b2733802bc47416824e30

          Code changed in jenkins
          User: Jesse Glick
          Path:
          aggregator/src/test/java/org/jenkinsci/plugins/workflow/steps/PushdStepTest.java
          http://jenkins-ci.org/commit/workflow-basic-steps-plugin/85812e78a3ab6c837b59002082e30bdc16294688
          Log:
          JENKINS-26137 At least during restarting tests, serialization errors seem to be due to there being no PickleFactory’s installed.
          Merely calling PickleFactory.all() from the RiverWriter constructor, rather than later, seems to let PushdStepTest.restarting pass (JENKINS-26051).
          Additionally asserting that there are in fact some factories loaded, since there is sure to be trouble if there are not.
          Also need to wait for the build to finish (JENKINS-26399).
          Originally-Committed-As: 3d3fa348ed9c34e4492b2733802bc47416824e30

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: aggregator/src/test/java/org/jenkinsci/plugins/workflow/steps/PushdStepTest.java http://jenkins-ci.org/commit/workflow-basic-steps-plugin/85812e78a3ab6c837b59002082e30bdc16294688 Log: JENKINS-26137 At least during restarting tests, serialization errors seem to be due to there being no PickleFactory’s installed. Merely calling PickleFactory.all() from the RiverWriter constructor, rather than later, seems to let PushdStepTest.restarting pass ( JENKINS-26051 ). Additionally asserting that there are in fact some factories loaded, since there is sure to be trouble if there are not. Also need to wait for the build to finish ( JENKINS-26399 ). Originally-Committed-As: 3d3fa348ed9c34e4492b2733802bc47416824e30

          Code changed in jenkins
          User: Jesse Glick
          Path:
          aggregator/src/test/java/org/jenkinsci/plugins/workflow/steps/PushdStepTest.java
          http://jenkins-ci.org/commit/workflow-scm-step-plugin/7583bf18eda2968bebc10024b52aee00a3614149
          Log:
          JENKINS-26137 At least during restarting tests, serialization errors seem to be due to there being no PickleFactory’s installed.
          Merely calling PickleFactory.all() from the RiverWriter constructor, rather than later, seems to let PushdStepTest.restarting pass (JENKINS-26051).
          Additionally asserting that there are in fact some factories loaded, since there is sure to be trouble if there are not.
          Also need to wait for the build to finish (JENKINS-26399).
          Originally-Committed-As: 3d3fa348ed9c34e4492b2733802bc47416824e30

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: aggregator/src/test/java/org/jenkinsci/plugins/workflow/steps/PushdStepTest.java http://jenkins-ci.org/commit/workflow-scm-step-plugin/7583bf18eda2968bebc10024b52aee00a3614149 Log: JENKINS-26137 At least during restarting tests, serialization errors seem to be due to there being no PickleFactory’s installed. Merely calling PickleFactory.all() from the RiverWriter constructor, rather than later, seems to let PushdStepTest.restarting pass ( JENKINS-26051 ). Additionally asserting that there are in fact some factories loaded, since there is sure to be trouble if there are not. Also need to wait for the build to finish ( JENKINS-26399 ). Originally-Committed-As: 3d3fa348ed9c34e4492b2733802bc47416824e30

          Code changed in jenkins
          User: Jesse Glick
          Path:
          aggregator/src/test/java/org/jenkinsci/plugins/workflow/steps/PushdStepTest.java
          http://jenkins-ci.org/commit/workflow-cps-plugin/89c28b4fca0eb81cf369ff699f7a4d801fc83e83
          Log:
          JENKINS-26137 At least during restarting tests, serialization errors seem to be due to there being no PickleFactory’s installed.
          Merely calling PickleFactory.all() from the RiverWriter constructor, rather than later, seems to let PushdStepTest.restarting pass (JENKINS-26051).
          Additionally asserting that there are in fact some factories loaded, since there is sure to be trouble if there are not.
          Also need to wait for the build to finish (JENKINS-26399).
          Originally-Committed-As: 3d3fa348ed9c34e4492b2733802bc47416824e30

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: aggregator/src/test/java/org/jenkinsci/plugins/workflow/steps/PushdStepTest.java http://jenkins-ci.org/commit/workflow-cps-plugin/89c28b4fca0eb81cf369ff699f7a4d801fc83e83 Log: JENKINS-26137 At least during restarting tests, serialization errors seem to be due to there being no PickleFactory’s installed. Merely calling PickleFactory.all() from the RiverWriter constructor, rather than later, seems to let PushdStepTest.restarting pass ( JENKINS-26051 ). Additionally asserting that there are in fact some factories loaded, since there is sure to be trouble if there are not. Also need to wait for the build to finish ( JENKINS-26399 ). Originally-Committed-As: 3d3fa348ed9c34e4492b2733802bc47416824e30

          Code changed in jenkins
          User: Jesse Glick
          Path:
          aggregator/src/test/java/org/jenkinsci/plugins/workflow/steps/PushdStepTest.java
          http://jenkins-ci.org/commit/workflow-multibranch-plugin/fe863c4a5ba855d65cd68588a71e5293f0bdf641
          Log:
          JENKINS-26137 At least during restarting tests, serialization errors seem to be due to there being no PickleFactory’s installed.
          Merely calling PickleFactory.all() from the RiverWriter constructor, rather than later, seems to let PushdStepTest.restarting pass (JENKINS-26051).
          Additionally asserting that there are in fact some factories loaded, since there is sure to be trouble if there are not.
          Also need to wait for the build to finish (JENKINS-26399).
          Originally-Committed-As: 3d3fa348ed9c34e4492b2733802bc47416824e30

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: aggregator/src/test/java/org/jenkinsci/plugins/workflow/steps/PushdStepTest.java http://jenkins-ci.org/commit/workflow-multibranch-plugin/fe863c4a5ba855d65cd68588a71e5293f0bdf641 Log: JENKINS-26137 At least during restarting tests, serialization errors seem to be due to there being no PickleFactory’s installed. Merely calling PickleFactory.all() from the RiverWriter constructor, rather than later, seems to let PushdStepTest.restarting pass ( JENKINS-26051 ). Additionally asserting that there are in fact some factories loaded, since there is sure to be trouble if there are not. Also need to wait for the build to finish ( JENKINS-26399 ). Originally-Committed-As: 3d3fa348ed9c34e4492b2733802bc47416824e30

            jglick Jesse Glick
            jglick Jesse Glick
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated:
              Resolved: