Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-26093

Code snippet generation for BuildTriggerStep.parameters

    • Icon: Improvement Improvement
    • Resolution: Fixed
    • Icon: Major Major
    • pipeline
    • None

      Should ideally look up the Job from the job field and dynamically include a list of value.jelly blocks; just not sure how to wire up the JavaScript for this.

      A potential alternative (requiring a core change) would be for ParameterValue, not just ParameterDefinition, to be Describable (where config.jelly just calls value.jelly, passing it = instance), and these would all have a Descriptor, so that <f:repeatableHeteroProperty field="parameters"/> would suffice to configure a List<ParameterValue>. Not as nice for the user, though.

      kohsuke also originally suggested adding ParameterDefinition.createValue(Object) as yet another alternative, but again this is not as friendly to snippet generation.

          [JENKINS-26093] Code snippet generation for BuildTriggerStep.parameters

          Jesse Glick added a comment -

          This and JENKINS-26143 could probably be worked around in DescribableHelper until a fix is available in core.

          Jesse Glick added a comment - This and JENKINS-26143 could probably be worked around in DescribableHelper until a fix is available in core.

          Code changed in jenkins
          User: Jesse Glick
          Path:
          CHANGES.md
          aggregator/src/test/java/org/jenkinsci/plugins/workflow/steps/build/BuildTriggerStepTest.java
          cps/src/test/java/org/jenkinsci/plugins/workflow/cps/SnippetizerTest.java
          step-api/src/main/java/org/jenkinsci/plugins/workflow/structs/DescribableHelper.java
          step-api/src/test/java/org/jenkinsci/plugins/workflow/structs/DescribableHelperTest.java
          support/src/main/resources/org/jenkinsci/plugins/workflow/support/steps/build/BuildTriggerStep/config.jelly
          http://jenkins-ci.org/commit/workflow-plugin/72860e91d39712e1beecdab61d42427a4402f294
          Log:
          JENKINS-26093 Allow parameter values to be specified using standard $class syntax.

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: CHANGES.md aggregator/src/test/java/org/jenkinsci/plugins/workflow/steps/build/BuildTriggerStepTest.java cps/src/test/java/org/jenkinsci/plugins/workflow/cps/SnippetizerTest.java step-api/src/main/java/org/jenkinsci/plugins/workflow/structs/DescribableHelper.java step-api/src/test/java/org/jenkinsci/plugins/workflow/structs/DescribableHelperTest.java support/src/main/resources/org/jenkinsci/plugins/workflow/support/steps/build/BuildTriggerStep/config.jelly http://jenkins-ci.org/commit/workflow-plugin/72860e91d39712e1beecdab61d42427a4402f294 Log: JENKINS-26093 Allow parameter values to be specified using standard $class syntax.

          Code changed in jenkins
          User: Jesse Glick
          Path:
          CHANGES.md
          cps/src/main/java/org/jenkinsci/plugins/workflow/cps/Snippetizer.java
          support/src/main/java/org/jenkinsci/plugins/workflow/support/steps/build/BuildTriggerStep.java
          support/src/main/resources/org/jenkinsci/plugins/workflow/support/steps/build/BuildTriggerStep/DescriptorImpl/parameters.groovy
          support/src/main/resources/org/jenkinsci/plugins/workflow/support/steps/build/BuildTriggerStep/config.jelly
          http://jenkins-ci.org/commit/workflow-plugin/276eee3b7d552e031b73d440a2faf29d25dbc680
          Log:
          JENKINS-26093 Look up the downstream parameter definitions and show their index pages.

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: CHANGES.md cps/src/main/java/org/jenkinsci/plugins/workflow/cps/Snippetizer.java support/src/main/java/org/jenkinsci/plugins/workflow/support/steps/build/BuildTriggerStep.java support/src/main/resources/org/jenkinsci/plugins/workflow/support/steps/build/BuildTriggerStep/DescriptorImpl/parameters.groovy support/src/main/resources/org/jenkinsci/plugins/workflow/support/steps/build/BuildTriggerStep/config.jelly http://jenkins-ci.org/commit/workflow-plugin/276eee3b7d552e031b73d440a2faf29d25dbc680 Log: JENKINS-26093 Look up the downstream parameter definitions and show their index pages.

          Code changed in jenkins
          User: Jesse Glick
          Path:
          CHANGES.md
          aggregator/src/test/java/org/jenkinsci/plugins/workflow/steps/build/BuildTriggerStepTest.java
          cps/src/main/java/org/jenkinsci/plugins/workflow/cps/Snippetizer.java
          cps/src/test/java/org/jenkinsci/plugins/workflow/cps/SnippetizerTest.java
          step-api/src/main/java/org/jenkinsci/plugins/workflow/structs/DescribableHelper.java
          step-api/src/test/java/org/jenkinsci/plugins/workflow/structs/DescribableHelperTest.java
          support/src/main/java/org/jenkinsci/plugins/workflow/support/steps/build/BuildTriggerStep.java
          support/src/main/java/org/jenkinsci/plugins/workflow/support/steps/build/StaplerReferer.java
          support/src/main/resources/org/jenkinsci/plugins/workflow/support/steps/build/BuildTriggerStep/DescriptorImpl/parameters.groovy
          support/src/main/resources/org/jenkinsci/plugins/workflow/support/steps/build/BuildTriggerStep/config.jelly
          http://jenkins-ci.org/commit/workflow-plugin/59d5d337e70fc15a69cdc308ee052d79ab7ffbd1
          Log:
          [FIXED JENKINS-26093] Merging #69.

          Conflicts:
          CHANGES.md

          Compare: https://github.com/jenkinsci/workflow-plugin/compare/4948e6844e23...59d5d337e70f

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: CHANGES.md aggregator/src/test/java/org/jenkinsci/plugins/workflow/steps/build/BuildTriggerStepTest.java cps/src/main/java/org/jenkinsci/plugins/workflow/cps/Snippetizer.java cps/src/test/java/org/jenkinsci/plugins/workflow/cps/SnippetizerTest.java step-api/src/main/java/org/jenkinsci/plugins/workflow/structs/DescribableHelper.java step-api/src/test/java/org/jenkinsci/plugins/workflow/structs/DescribableHelperTest.java support/src/main/java/org/jenkinsci/plugins/workflow/support/steps/build/BuildTriggerStep.java support/src/main/java/org/jenkinsci/plugins/workflow/support/steps/build/StaplerReferer.java support/src/main/resources/org/jenkinsci/plugins/workflow/support/steps/build/BuildTriggerStep/DescriptorImpl/parameters.groovy support/src/main/resources/org/jenkinsci/plugins/workflow/support/steps/build/BuildTriggerStep/config.jelly http://jenkins-ci.org/commit/workflow-plugin/59d5d337e70fc15a69cdc308ee052d79ab7ffbd1 Log: [FIXED JENKINS-26093] Merging #69. Conflicts: CHANGES.md Compare: https://github.com/jenkinsci/workflow-plugin/compare/4948e6844e23...59d5d337e70f

          Code changed in jenkins
          User: Jesse Glick
          Path:
          aggregator/src/test/java/org/jenkinsci/plugins/workflow/steps/build/BuildTriggerStepTest.java
          support/src/main/resources/org/jenkinsci/plugins/workflow/support/steps/build/BuildTriggerStep/config.jelly
          http://jenkins-ci.org/commit/pipeline-build-step-plugin/da3bfa5bded2c209a380e3c3e69b687426170c4c
          Log:
          JENKINS-26093 Allow parameter values to be specified using standard $class syntax.
          Originally-Committed-As: 72860e91d39712e1beecdab61d42427a4402f294

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: aggregator/src/test/java/org/jenkinsci/plugins/workflow/steps/build/BuildTriggerStepTest.java support/src/main/resources/org/jenkinsci/plugins/workflow/support/steps/build/BuildTriggerStep/config.jelly http://jenkins-ci.org/commit/pipeline-build-step-plugin/da3bfa5bded2c209a380e3c3e69b687426170c4c Log: JENKINS-26093 Allow parameter values to be specified using standard $class syntax. Originally-Committed-As: 72860e91d39712e1beecdab61d42427a4402f294

          Code changed in jenkins
          User: Jesse Glick
          Path:
          support/src/main/java/org/jenkinsci/plugins/workflow/support/steps/build/BuildTriggerStep.java
          support/src/main/resources/org/jenkinsci/plugins/workflow/support/steps/build/BuildTriggerStep/DescriptorImpl/parameters.groovy
          support/src/main/resources/org/jenkinsci/plugins/workflow/support/steps/build/BuildTriggerStep/config.jelly
          http://jenkins-ci.org/commit/pipeline-build-step-plugin/c5155cbcbb7e97d437ba5d28c540adfb0ebaa039
          Log:
          JENKINS-26093 Look up the downstream parameter definitions and show their index pages.
          Originally-Committed-As: 276eee3b7d552e031b73d440a2faf29d25dbc680

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: support/src/main/java/org/jenkinsci/plugins/workflow/support/steps/build/BuildTriggerStep.java support/src/main/resources/org/jenkinsci/plugins/workflow/support/steps/build/BuildTriggerStep/DescriptorImpl/parameters.groovy support/src/main/resources/org/jenkinsci/plugins/workflow/support/steps/build/BuildTriggerStep/config.jelly http://jenkins-ci.org/commit/pipeline-build-step-plugin/c5155cbcbb7e97d437ba5d28c540adfb0ebaa039 Log: JENKINS-26093 Look up the downstream parameter definitions and show their index pages. Originally-Committed-As: 276eee3b7d552e031b73d440a2faf29d25dbc680

          Code changed in jenkins
          User: Jesse Glick
          Path:
          cps/src/test/java/org/jenkinsci/plugins/workflow/cps/SnippetizerTest.java
          http://jenkins-ci.org/commit/workflow-cps-plugin/a1b5def0bac7a2360ad2b471d45c81ded1fc7c49
          Log:
          JENKINS-26093 Allow parameter values to be specified using standard $class syntax.
          Originally-Committed-As: 72860e91d39712e1beecdab61d42427a4402f294

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: cps/src/test/java/org/jenkinsci/plugins/workflow/cps/SnippetizerTest.java http://jenkins-ci.org/commit/workflow-cps-plugin/a1b5def0bac7a2360ad2b471d45c81ded1fc7c49 Log: JENKINS-26093 Allow parameter values to be specified using standard $class syntax. Originally-Committed-As: 72860e91d39712e1beecdab61d42427a4402f294

          Code changed in jenkins
          User: Jesse Glick
          Path:
          cps/src/main/java/org/jenkinsci/plugins/workflow/cps/Snippetizer.java
          http://jenkins-ci.org/commit/workflow-cps-plugin/a08a617d45341bcce412c1fbe88faa0efa60c427
          Log:
          JENKINS-26093 Look up the downstream parameter definitions and show their index pages.
          Originally-Committed-As: 276eee3b7d552e031b73d440a2faf29d25dbc680

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: cps/src/main/java/org/jenkinsci/plugins/workflow/cps/Snippetizer.java http://jenkins-ci.org/commit/workflow-cps-plugin/a08a617d45341bcce412c1fbe88faa0efa60c427 Log: JENKINS-26093 Look up the downstream parameter definitions and show their index pages. Originally-Committed-As: 276eee3b7d552e031b73d440a2faf29d25dbc680

          Code changed in jenkins
          User: Jesse Glick
          Path:
          cps/src/main/java/org/jenkinsci/plugins/workflow/cps/Snippetizer.java
          cps/src/test/java/org/jenkinsci/plugins/workflow/cps/SnippetizerTest.java
          http://jenkins-ci.org/commit/workflow-cps-plugin/ae3e6888dc097b68dd564b785bae021d3135c364
          Log:
          [FIXED JENKINS-26093] Merging #69.

          Conflicts:
          CHANGES.md

          Originally-Committed-As: 59d5d337e70fc15a69cdc308ee052d79ab7ffbd1

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: cps/src/main/java/org/jenkinsci/plugins/workflow/cps/Snippetizer.java cps/src/test/java/org/jenkinsci/plugins/workflow/cps/SnippetizerTest.java http://jenkins-ci.org/commit/workflow-cps-plugin/ae3e6888dc097b68dd564b785bae021d3135c364 Log: [FIXED JENKINS-26093] Merging #69. Conflicts: CHANGES.md Originally-Committed-As: 59d5d337e70fc15a69cdc308ee052d79ab7ffbd1

          Code changed in jenkins
          User: Jesse Glick
          Path:
          plugin/src/main/java/org/jenkinsci/plugins/structs/SymbolLookup.java
          plugin/src/main/java/org/jenkinsci/plugins/structs/describable/DescribableModel.java
          plugin/src/test/java/org/jenkinsci/plugins/structs/SymbolLookupTest.java
          plugin/src/test/java/org/jenkinsci/plugins/structs/describable/DescribableModelTest.java
          http://jenkins-ci.org/commit/structs-plugin/8d4446fe64ce79fa476345d49cdbb100307af76c
          Log:
          JENKINS-26093 Extending ParameterValue symbol handling to SymbolLookup where it belongs anyway.

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: plugin/src/main/java/org/jenkinsci/plugins/structs/SymbolLookup.java plugin/src/main/java/org/jenkinsci/plugins/structs/describable/DescribableModel.java plugin/src/test/java/org/jenkinsci/plugins/structs/SymbolLookupTest.java plugin/src/test/java/org/jenkinsci/plugins/structs/describable/DescribableModelTest.java http://jenkins-ci.org/commit/structs-plugin/8d4446fe64ce79fa476345d49cdbb100307af76c Log: JENKINS-26093 Extending ParameterValue symbol handling to SymbolLookup where it belongs anyway.

            jglick Jesse Glick
            jglick Jesse Glick
            Votes:
            1 Vote for this issue
            Watchers:
            7 Start watching this issue

              Created:
              Updated:
              Resolved: