Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-26121

Input step should maintain audit record

XMLWordPrintable

    • Icon: Improvement Improvement
    • Resolution: Fixed
    • Icon: Minor Minor
    • pipeline

      Should save something to the build record saying who approved (or rejected) it, such as an Action which is an @ExportedBean.

          [JENKINS-26121] Input step should maintain audit record

          SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Valentina Armenise
          Path:
          aggregator/src/test/java/org/jenkinsci/plugins/workflow/steps/input/InputStepTest.java
          support/src/main/java/org/jenkinsci/plugins/workflow/support/steps/input/ApproverAction.java
          support/src/main/java/org/jenkinsci/plugins/workflow/support/steps/input/InputStepExecution.java
          support/src/main/resources/org/jenkinsci/plugins/workflow/support/steps/input/ApproverAction/summary.jelly
          support/src/main/resources/org/jenkinsci/plugins/workflow/support/steps/input/ApproverAction/summary.properties
          http://jenkins-ci.org/commit/workflow-plugin/36571033f4ec39bd107cd492875607b7f59e1237
          Log:
          JENKINS-26121 - Approver Logged

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Valentina Armenise Path: aggregator/src/test/java/org/jenkinsci/plugins/workflow/steps/input/InputStepTest.java support/src/main/java/org/jenkinsci/plugins/workflow/support/steps/input/ApproverAction.java support/src/main/java/org/jenkinsci/plugins/workflow/support/steps/input/InputStepExecution.java support/src/main/resources/org/jenkinsci/plugins/workflow/support/steps/input/ApproverAction/summary.jelly support/src/main/resources/org/jenkinsci/plugins/workflow/support/steps/input/ApproverAction/summary.properties http://jenkins-ci.org/commit/workflow-plugin/36571033f4ec39bd107cd492875607b7f59e1237 Log: JENKINS-26121 - Approver Logged

          SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Jesse Glick
          Path:
          aggregator/src/test/java/org/jenkinsci/plugins/workflow/steps/input/InputStepTest.java
          support/src/main/java/org/jenkinsci/plugins/workflow/support/steps/input/ApproverAction.java
          support/src/main/java/org/jenkinsci/plugins/workflow/support/steps/input/InputStepExecution.java
          support/src/main/resources/org/jenkinsci/plugins/workflow/support/steps/input/ApproverAction/summary.jelly
          support/src/main/resources/org/jenkinsci/plugins/workflow/support/steps/input/ApproverAction/summary.properties
          http://jenkins-ci.org/commit/workflow-plugin/f88042c300e8639dc8e51fa38f989e94638c4ec1
          Log:
          Merge pull request #47 from varmenise/JENKINS-26121

          JENKINS-26121 Approver Logged

          Compare: https://github.com/jenkinsci/workflow-plugin/compare/a5c5bf6fee6a...f88042c300e8

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: aggregator/src/test/java/org/jenkinsci/plugins/workflow/steps/input/InputStepTest.java support/src/main/java/org/jenkinsci/plugins/workflow/support/steps/input/ApproverAction.java support/src/main/java/org/jenkinsci/plugins/workflow/support/steps/input/InputStepExecution.java support/src/main/resources/org/jenkinsci/plugins/workflow/support/steps/input/ApproverAction/summary.jelly support/src/main/resources/org/jenkinsci/plugins/workflow/support/steps/input/ApproverAction/summary.properties http://jenkins-ci.org/commit/workflow-plugin/f88042c300e8639dc8e51fa38f989e94638c4ec1 Log: Merge pull request #47 from varmenise/ JENKINS-26121 JENKINS-26121 Approver Logged Compare: https://github.com/jenkinsci/workflow-plugin/compare/a5c5bf6fee6a...f88042c300e8

          SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Jesse Glick
          Path:
          CHANGES.md
          http://jenkins-ci.org/commit/workflow-plugin/f2593795afcbf9908f52adca694f4c58b2387b5b
          Log:
          JENKINS-26121 Noting merge of #47.

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: CHANGES.md http://jenkins-ci.org/commit/workflow-plugin/f2593795afcbf9908f52adca694f4c58b2387b5b Log: JENKINS-26121 Noting merge of #47.

          J Knurek added a comment -

          From the PR https://github.com/jenkinsci/workflow-plugin/pull/47/files
          it doesn't appear that this change logs the user who "rejected" the step

          J Knurek added a comment - From the PR https://github.com/jenkinsci/workflow-plugin/pull/47/files it doesn't appear that this change logs the user who "rejected" the step

          valentina armenise added a comment - - edited

          The rejected action was already audited in the summary UI since it extends the CauseOfInterruption:

          https://github.com/jenkinsci/workflow-plugin/blob/0294f3305d665170931c781abca47aa40f46c25a/support/src/main/java/org/jenkinsci/plugins/workflow/support/steps/input/Rejection.java#L12

          which is in the core:

          https://github.com/jenkinsci/jenkins/blob/68b383e0b2cdd2b1403a13a4284dc1a2d3e03e12/core/src/main/resources/jenkins/model/CauseOfInterruption/summary.groovy

          The rejected action was also logged by the FlowInterruptedExpection class:

          https://github.com/jenkinsci/workflow-plugin/blob/master/support/src/main/java/org/jenkinsci/plugins/workflow/support/steps/input/InputStepExecution.java#L179

          valentina armenise added a comment - - edited The rejected action was already audited in the summary UI since it extends the CauseOfInterruption: https://github.com/jenkinsci/workflow-plugin/blob/0294f3305d665170931c781abca47aa40f46c25a/support/src/main/java/org/jenkinsci/plugins/workflow/support/steps/input/Rejection.java#L12 which is in the core: https://github.com/jenkinsci/jenkins/blob/68b383e0b2cdd2b1403a13a4284dc1a2d3e03e12/core/src/main/resources/jenkins/model/CauseOfInterruption/summary.groovy The rejected action was also logged by the FlowInterruptedExpection class: https://github.com/jenkinsci/workflow-plugin/blob/master/support/src/main/java/org/jenkinsci/plugins/workflow/support/steps/input/InputStepExecution.java#L179

          SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Valentina Armenise
          Path:
          aggregator/src/test/java/org/jenkinsci/plugins/workflow/steps/input/InputStepTest.java
          support/src/main/java/org/jenkinsci/plugins/workflow/support/steps/input/ApproverAction.java
          support/src/main/java/org/jenkinsci/plugins/workflow/support/steps/input/InputStepExecution.java
          support/src/main/resources/org/jenkinsci/plugins/workflow/support/steps/input/ApproverAction/summary.jelly
          support/src/main/resources/org/jenkinsci/plugins/workflow/support/steps/input/ApproverAction/summary.properties
          http://jenkins-ci.org/commit/pipeline-input-step-plugin/dbebf63e738f5aa7dca9b9de4826a32c58b00fa5
          Log:
          JENKINS-26121 - Approver Logged

          Originally-Committed-As: 36571033f4ec39bd107cd492875607b7f59e1237

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Valentina Armenise Path: aggregator/src/test/java/org/jenkinsci/plugins/workflow/steps/input/InputStepTest.java support/src/main/java/org/jenkinsci/plugins/workflow/support/steps/input/ApproverAction.java support/src/main/java/org/jenkinsci/plugins/workflow/support/steps/input/InputStepExecution.java support/src/main/resources/org/jenkinsci/plugins/workflow/support/steps/input/ApproverAction/summary.jelly support/src/main/resources/org/jenkinsci/plugins/workflow/support/steps/input/ApproverAction/summary.properties http://jenkins-ci.org/commit/pipeline-input-step-plugin/dbebf63e738f5aa7dca9b9de4826a32c58b00fa5 Log: JENKINS-26121 - Approver Logged Originally-Committed-As: 36571033f4ec39bd107cd492875607b7f59e1237

            varmenise valentina armenise
            jglick Jesse Glick
            Votes:
            1 Vote for this issue
            Watchers:
            6 Start watching this issue

              Created:
              Updated:
              Resolved: