• Icon: Improvement Improvement
    • Resolution: Fixed
    • Icon: Minor Minor
    • core

      This could be lifted up into ParameterizedJob. That would enable an AlternativeUiTextProvider to supply an alternate Build Now text for workflows.

      PRONOUN is already in AbstractItem so this is fine.

          [JENKINS-26147] Lift up AbstractProject.BUILD_NOW_TEXT

          Oleg Nenashev added a comment -

          I've taken the issue

          Oleg Nenashev added a comment - I've taken the issue

          Oleg Nenashev added a comment -

          After digging into the code I'd disagree with the propagation to AbstractItem.
          Not all items are buildable, to this text belongs to BuildableItem instead of AbstractItem.

          BTW, my god-feeling is that something is misdesigned in AlternativeUiTextProvider extensions engine. AlternativeUiTextProvider.Message is tasty, but it's non-object context becomes a PITA for migrations of such kind

          Oleg Nenashev added a comment - After digging into the code I'd disagree with the propagation to AbstractItem. Not all items are buildable, to this text belongs to BuildableItem instead of AbstractItem. BTW, my god-feeling is that something is misdesigned in AlternativeUiTextProvider extensions engine. AlternativeUiTextProvider.Message is tasty, but it's non-object context becomes a PITA for migrations of such kind

          Jesse Glick added a comment -

          Should be in ParameterizedJobMixIn.

          Jesse Glick added a comment - Should be in ParameterizedJobMixIn .

          Jesse Glick added a comment -

          Correct me if I am wrong, but I see no ongoing work to implement this RFE itself. Do you want me to take it? Needs to be done soon if it is going to get into the next LTS.

          Jesse Glick added a comment - Correct me if I am wrong, but I see no ongoing work to implement this RFE itself. Do you want me to take it? Needs to be done soon if it is going to get into the next LTS.

          Oleg Nenashev added a comment -

          Yes, previously I've briefly evaluated the feasibility of this change and decided that it does not worth to do it, because workflow-plugin would need to take a new Jenkins core version... again. So I've proposed another approach for workflow even if it was quite narrow-specific.

          If you think it's required to have a centralized localizer, feel free to go forward.

          Oleg Nenashev added a comment - Yes, previously I've briefly evaluated the feasibility of this change and decided that it does not worth to do it, because workflow-plugin would need to take a new Jenkins core version... again. So I've proposed another approach for workflow even if it was quite narrow-specific. If you think it's required to have a centralized localizer, feel free to go forward.

          Code changed in jenkins
          User: Jesse Glick
          Path:
          core/src/main/java/hudson/model/AbstractProject.java
          core/src/main/java/jenkins/model/ParameterizedJobMixIn.java
          test/src/test/java/hudson/util/AlternativeUiTextProviderTest.java
          http://jenkins-ci.org/commit/jenkins/3f7875c1509ee6d062891ac3904ce46ca6162fe5
          Log:
          [FIXED JENKINS-26147] Move BUILD_NOW_TEXT to ParameterizedJobMixIn.

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: core/src/main/java/hudson/model/AbstractProject.java core/src/main/java/jenkins/model/ParameterizedJobMixIn.java test/src/test/java/hudson/util/AlternativeUiTextProviderTest.java http://jenkins-ci.org/commit/jenkins/3f7875c1509ee6d062891ac3904ce46ca6162fe5 Log: [FIXED JENKINS-26147] Move BUILD_NOW_TEXT to ParameterizedJobMixIn.

          Code changed in jenkins
          User: Jesse Glick
          Path:
          core/src/main/java/hudson/model/AbstractProject.java
          core/src/main/java/jenkins/model/ParameterizedJobMixIn.java
          core/src/main/resources/hudson/model/Messages.properties
          core/src/main/resources/hudson/model/Messages_ca.properties
          core/src/main/resources/hudson/model/Messages_da.properties
          core/src/main/resources/hudson/model/Messages_de.properties
          core/src/main/resources/hudson/model/Messages_es.properties
          core/src/main/resources/hudson/model/Messages_fi.properties
          core/src/main/resources/hudson/model/Messages_fr.properties
          core/src/main/resources/hudson/model/Messages_hu.properties
          core/src/main/resources/hudson/model/Messages_it.properties
          core/src/main/resources/hudson/model/Messages_ja.properties
          core/src/main/resources/hudson/model/Messages_nl.properties
          core/src/main/resources/hudson/model/Messages_pt_BR.properties
          core/src/main/resources/hudson/model/Messages_ru.properties
          core/src/main/resources/hudson/model/Messages_sl.properties
          core/src/main/resources/hudson/model/Messages_sv_SE.properties
          core/src/main/resources/hudson/model/Messages_tr.properties
          core/src/main/resources/hudson/model/Messages_zh_CN.properties
          core/src/main/resources/hudson/model/Messages_zh_TW.properties
          core/src/main/resources/jenkins/model/Messages.properties
          core/src/main/resources/jenkins/model/Messages_ca.properties
          core/src/main/resources/jenkins/model/Messages_da.properties
          core/src/main/resources/jenkins/model/Messages_de.properties
          core/src/main/resources/jenkins/model/Messages_es.properties
          core/src/main/resources/jenkins/model/Messages_fi.properties
          core/src/main/resources/jenkins/model/Messages_fr.properties
          core/src/main/resources/jenkins/model/Messages_hu.properties
          core/src/main/resources/jenkins/model/Messages_it.properties
          core/src/main/resources/jenkins/model/Messages_ja.properties
          core/src/main/resources/jenkins/model/Messages_nl.properties
          core/src/main/resources/jenkins/model/Messages_pt_BR.properties
          core/src/main/resources/jenkins/model/Messages_ru.properties
          core/src/main/resources/jenkins/model/Messages_sl.properties
          core/src/main/resources/jenkins/model/Messages_sv_SE.properties
          core/src/main/resources/jenkins/model/Messages_tr.properties
          core/src/main/resources/jenkins/model/Messages_zh_CN.properties
          core/src/main/resources/jenkins/model/Messages_zh_TW.properties
          test/src/test/java/hudson/util/AlternativeUiTextProviderTest.java
          http://jenkins-ci.org/commit/jenkins/1fbc4fdac0401f76c1acbb39208d536a0bc4b011
          Log:
          Merge pull request #1779 from jglick/BUILD_NOW_TEXT-JENKINS-26147

          JENKINS-26147 New home for BUILD_NOW_TEXT

          Compare: https://github.com/jenkinsci/jenkins/compare/668cf95f262a...1fbc4fdac040

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: core/src/main/java/hudson/model/AbstractProject.java core/src/main/java/jenkins/model/ParameterizedJobMixIn.java core/src/main/resources/hudson/model/Messages.properties core/src/main/resources/hudson/model/Messages_ca.properties core/src/main/resources/hudson/model/Messages_da.properties core/src/main/resources/hudson/model/Messages_de.properties core/src/main/resources/hudson/model/Messages_es.properties core/src/main/resources/hudson/model/Messages_fi.properties core/src/main/resources/hudson/model/Messages_fr.properties core/src/main/resources/hudson/model/Messages_hu.properties core/src/main/resources/hudson/model/Messages_it.properties core/src/main/resources/hudson/model/Messages_ja.properties core/src/main/resources/hudson/model/Messages_nl.properties core/src/main/resources/hudson/model/Messages_pt_BR.properties core/src/main/resources/hudson/model/Messages_ru.properties core/src/main/resources/hudson/model/Messages_sl.properties core/src/main/resources/hudson/model/Messages_sv_SE.properties core/src/main/resources/hudson/model/Messages_tr.properties core/src/main/resources/hudson/model/Messages_zh_CN.properties core/src/main/resources/hudson/model/Messages_zh_TW.properties core/src/main/resources/jenkins/model/Messages.properties core/src/main/resources/jenkins/model/Messages_ca.properties core/src/main/resources/jenkins/model/Messages_da.properties core/src/main/resources/jenkins/model/Messages_de.properties core/src/main/resources/jenkins/model/Messages_es.properties core/src/main/resources/jenkins/model/Messages_fi.properties core/src/main/resources/jenkins/model/Messages_fr.properties core/src/main/resources/jenkins/model/Messages_hu.properties core/src/main/resources/jenkins/model/Messages_it.properties core/src/main/resources/jenkins/model/Messages_ja.properties core/src/main/resources/jenkins/model/Messages_nl.properties core/src/main/resources/jenkins/model/Messages_pt_BR.properties core/src/main/resources/jenkins/model/Messages_ru.properties core/src/main/resources/jenkins/model/Messages_sl.properties core/src/main/resources/jenkins/model/Messages_sv_SE.properties core/src/main/resources/jenkins/model/Messages_tr.properties core/src/main/resources/jenkins/model/Messages_zh_CN.properties core/src/main/resources/jenkins/model/Messages_zh_TW.properties test/src/test/java/hudson/util/AlternativeUiTextProviderTest.java http://jenkins-ci.org/commit/jenkins/1fbc4fdac0401f76c1acbb39208d536a0bc4b011 Log: Merge pull request #1779 from jglick/BUILD_NOW_TEXT- JENKINS-26147 JENKINS-26147 New home for BUILD_NOW_TEXT Compare: https://github.com/jenkinsci/jenkins/compare/668cf95f262a...1fbc4fdac040

          dogfood added a comment -

          Integrated in jenkins_main_trunk #4236
          [FIXED JENKINS-26147] Move BUILD_NOW_TEXT to ParameterizedJobMixIn. (Revision 3f7875c1509ee6d062891ac3904ce46ca6162fe5)

          Result = SUCCESS
          jesse glick : 3f7875c1509ee6d062891ac3904ce46ca6162fe5
          Files :

          • test/src/test/java/hudson/util/AlternativeUiTextProviderTest.java
          • core/src/main/java/jenkins/model/ParameterizedJobMixIn.java
          • core/src/main/java/hudson/model/AbstractProject.java

          dogfood added a comment - Integrated in jenkins_main_trunk #4236 [FIXED JENKINS-26147] Move BUILD_NOW_TEXT to ParameterizedJobMixIn. (Revision 3f7875c1509ee6d062891ac3904ce46ca6162fe5) Result = SUCCESS jesse glick : 3f7875c1509ee6d062891ac3904ce46ca6162fe5 Files : test/src/test/java/hudson/util/AlternativeUiTextProviderTest.java core/src/main/java/jenkins/model/ParameterizedJobMixIn.java core/src/main/java/hudson/model/AbstractProject.java

            jglick Jesse Glick
            jglick Jesse Glick
            Votes:
            1 Vote for this issue
            Watchers:
            4 Start watching this issue

              Created:
              Updated:
              Resolved: