Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-26208

Jenkins should not skip polling while quieting down

    • Icon: Improvement Improvement
    • Resolution: Fixed
    • Icon: Minor Minor
    • core
    • None

      Polling must die:

      http://kohsuke.org/2011/12/01/polling-must-die-triggering-jenkins-builds-from-a-git-hook/

      Unfortunately, Jenkins has this weird behavior to skip polling while in quiet-down mode.

      https://github.com/jenkinsci/jenkins/blob/608517e187cb5bd1566b1c3728a4df0f7ac4dd5c/core/src/main/java/hudson/triggers/SCMTrigger.java#L132

      Since anyone implementing post-commit hooks (as described e.g. on https://wiki.jenkins-ci.org/display/JENKINS/Subversion+Plugin for Subversion) will only perform actual polling very rarely, if at all.

      However, whenever Jenkins is quieting down (which can be for a number of reasons), polling is skipped and any post-commit notification, if implemented in terms of triggering polling, effectively discarded.

      For less active projects (few commits) this can result in builds being hours, to weeks, late, if at all.

      This behavior should be changed to not skip polling while quieting down. The affected projects can start building when Jenkins leaves quiet-down mode. And since Jenkins preserves the queue when shutting down, the affected projects can be built immediately after restart if that's the motivation for quieting down.

          [JENKINS-26208] Jenkins should not skip polling while quieting down

          Code changed in jenkins
          User: Daniel Beck
          Path:
          core/src/main/java/hudson/triggers/SCMTrigger.java
          http://jenkins-ci.org/commit/jenkins/e7e1bf87f39d47e993c16e78a7d8eeece3cc822f
          Log:
          [FIXED JENKINS-26208] Do not skip polling while quieting down

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Daniel Beck Path: core/src/main/java/hudson/triggers/SCMTrigger.java http://jenkins-ci.org/commit/jenkins/e7e1bf87f39d47e993c16e78a7d8eeece3cc822f Log: [FIXED JENKINS-26208] Do not skip polling while quieting down

          Code changed in jenkins
          User: Daniel Beck
          Path:
          core/src/main/java/hudson/triggers/SCMTrigger.java
          http://jenkins-ci.org/commit/jenkins/5e8939732ea319426b16994cf2ac4cd2609ab2ae
          Log:
          Merge pull request #1501 from daniel-beck/JENKINS-26208

          [FIXED JENKINS-26208] Do not skip polling while quieting down

          Compare: https://github.com/jenkinsci/jenkins/compare/c294ed8e93ed...5e8939732ea3

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Daniel Beck Path: core/src/main/java/hudson/triggers/SCMTrigger.java http://jenkins-ci.org/commit/jenkins/5e8939732ea319426b16994cf2ac4cd2609ab2ae Log: Merge pull request #1501 from daniel-beck/ JENKINS-26208 [FIXED JENKINS-26208] Do not skip polling while quieting down Compare: https://github.com/jenkinsci/jenkins/compare/c294ed8e93ed...5e8939732ea3

          dogfood added a comment -

          Integrated in jenkins_main_trunk #4065

          Result = SUCCESS

          dogfood added a comment - Integrated in jenkins_main_trunk #4065 Result = SUCCESS

            Unassigned Unassigned
            danielbeck Daniel Beck
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated:
              Resolved: