Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-26208

Jenkins should not skip polling while quieting down

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Resolved (View Workflow)
    • Priority: Minor
    • Resolution: Fixed
    • Component/s: core
    • Labels:
      None
    • Similar Issues:

      Description

      Polling must die:

      http://kohsuke.org/2011/12/01/polling-must-die-triggering-jenkins-builds-from-a-git-hook/

      Unfortunately, Jenkins has this weird behavior to skip polling while in quiet-down mode.

      https://github.com/jenkinsci/jenkins/blob/608517e187cb5bd1566b1c3728a4df0f7ac4dd5c/core/src/main/java/hudson/triggers/SCMTrigger.java#L132

      Since anyone implementing post-commit hooks (as described e.g. on https://wiki.jenkins-ci.org/display/JENKINS/Subversion+Plugin for Subversion) will only perform actual polling very rarely, if at all.

      However, whenever Jenkins is quieting down (which can be for a number of reasons), polling is skipped and any post-commit notification, if implemented in terms of triggering polling, effectively discarded.

      For less active projects (few commits) this can result in builds being hours, to weeks, late, if at all.

      This behavior should be changed to not skip polling while quieting down. The affected projects can start building when Jenkins leaves quiet-down mode. And since Jenkins preserves the queue when shutting down, the affected projects can be built immediately after restart if that's the motivation for quieting down.

        Attachments

          Issue Links

            Activity

            danielbeck Daniel Beck created issue -
            danielbeck Daniel Beck made changes -
            Field Original Value New Value
            Link This issue is related to JENKINS-24244 [ JENKINS-24244 ]
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Daniel Beck
            Path:
            core/src/main/java/hudson/triggers/SCMTrigger.java
            http://jenkins-ci.org/commit/jenkins/e7e1bf87f39d47e993c16e78a7d8eeece3cc822f
            Log:
            [FIXED JENKINS-26208] Do not skip polling while quieting down

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Daniel Beck Path: core/src/main/java/hudson/triggers/SCMTrigger.java http://jenkins-ci.org/commit/jenkins/e7e1bf87f39d47e993c16e78a7d8eeece3cc822f Log: [FIXED JENKINS-26208] Do not skip polling while quieting down
            scm_issue_link SCM/JIRA link daemon made changes -
            Resolution Fixed [ 1 ]
            Status Open [ 1 ] Resolved [ 5 ]
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Daniel Beck
            Path:
            core/src/main/java/hudson/triggers/SCMTrigger.java
            http://jenkins-ci.org/commit/jenkins/5e8939732ea319426b16994cf2ac4cd2609ab2ae
            Log:
            Merge pull request #1501 from daniel-beck/JENKINS-26208

            [FIXED JENKINS-26208] Do not skip polling while quieting down

            Compare: https://github.com/jenkinsci/jenkins/compare/c294ed8e93ed...5e8939732ea3

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Daniel Beck Path: core/src/main/java/hudson/triggers/SCMTrigger.java http://jenkins-ci.org/commit/jenkins/5e8939732ea319426b16994cf2ac4cd2609ab2ae Log: Merge pull request #1501 from daniel-beck/ JENKINS-26208 [FIXED JENKINS-26208] Do not skip polling while quieting down Compare: https://github.com/jenkinsci/jenkins/compare/c294ed8e93ed...5e8939732ea3
            Hide
            dogfood dogfood added a comment -

            Integrated in jenkins_main_trunk #4065

            Result = SUCCESS

            Show
            dogfood dogfood added a comment - Integrated in jenkins_main_trunk #4065 Result = SUCCESS
            rtyler R. Tyler Croy made changes -
            Workflow JNJira [ 160199 ] JNJira + In-Review [ 196362 ]

              People

              Assignee:
              Unassigned Unassigned
              Reporter:
              danielbeck Daniel Beck
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved: