Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-26331

WarExploder assumes build system uses target directory

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Minor Minor
    • core
    • None

      WarExploder assumes that the build system uses a target directory for build artifacts. This causes problems when using Gradle and the gradle-jpi-plugin since Gradle uses a build directory for build artifacts. See WarExploder.java#L91.

      When using core versions >1.544 and <1.592, builds will fail when the target directory does exist. This has been introduced in bc4c1326 and fixed in 9aaeb0a3.

          [JENKINS-26331] WarExploder assumes build system uses target directory

          Daniel Spilker added a comment - See https://github.com/jenkinsci/jenkins/pull/1519

          For the meantime I'm adding a workaround to the gradle-jpi-plugin. See https://github.com/jenkinsci/gradle-jpi-plugin/pull/38.

          Daniel Spilker added a comment - For the meantime I'm adding a workaround to the gradle-jpi-plugin. See https://github.com/jenkinsci/gradle-jpi-plugin/pull/38 .

          Code changed in jenkins
          User: Daniel Spilker
          Path:
          job-dsl-plugin/build.gradle
          http://jenkins-ci.org/commit/job-dsl-plugin/0e285397a2ff7338021529e5e4c3c80f2359a504
          Log:
          better workaround for JENKINS-26331

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Daniel Spilker Path: job-dsl-plugin/build.gradle http://jenkins-ci.org/commit/job-dsl-plugin/0e285397a2ff7338021529e5e4c3c80f2359a504 Log: better workaround for JENKINS-26331

          Code changed in jenkins
          User: Daniel Spilker
          Path:
          CHANGELOG.md
          src/main/groovy/org/jenkinsci/gradle/plugins/jpi/JpiExtension.groovy
          src/main/groovy/org/jenkinsci/gradle/plugins/jpi/JpiPlugin.groovy
          http://jenkins-ci.org/commit/gradle-jpi-plugin/b20a07b336614b2f422197e2a07b883a98d549af
          Log:
          create (for coreVersions >= 1.545 and < 1.592) and clean `target` directory used by `org.jvnet.hudson.test.WarExploder` as a workaround for JENKINS-26331

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Daniel Spilker Path: CHANGELOG.md src/main/groovy/org/jenkinsci/gradle/plugins/jpi/JpiExtension.groovy src/main/groovy/org/jenkinsci/gradle/plugins/jpi/JpiPlugin.groovy http://jenkins-ci.org/commit/gradle-jpi-plugin/b20a07b336614b2f422197e2a07b883a98d549af Log: create (for coreVersions >= 1.545 and < 1.592) and clean `target` directory used by `org.jvnet.hudson.test.WarExploder` as a workaround for JENKINS-26331

          Code changed in jenkins
          User: Daniel Spilker
          Path:
          test/src/main/java/org/jvnet/hudson/test/WarExploder.java
          http://jenkins-ci.org/commit/jenkins/1fae8c072a1e8da360cd10dca8b82d1cd1b00968
          Log:
          JENKINS-26331 use buildDirectory system property to configure target directory

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Daniel Spilker Path: test/src/main/java/org/jvnet/hudson/test/WarExploder.java http://jenkins-ci.org/commit/jenkins/1fae8c072a1e8da360cd10dca8b82d1cd1b00968 Log: JENKINS-26331 use buildDirectory system property to configure target directory

          Code changed in jenkins
          User: Jesse Glick
          Path:
          changelog.html
          test/src/main/java/org/jvnet/hudson/test/WarExploder.java
          http://jenkins-ci.org/commit/jenkins/75eeccf8668e49396477d19fae365cb23442d40a
          Log:
          [FIXED JENKINS-26331] Noting merge of #1519.

          Compare: https://github.com/jenkinsci/jenkins/compare/28984e5920c6...75eeccf8668e

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: changelog.html test/src/main/java/org/jvnet/hudson/test/WarExploder.java http://jenkins-ci.org/commit/jenkins/75eeccf8668e49396477d19fae365cb23442d40a Log: [FIXED JENKINS-26331] Noting merge of #1519. Compare: https://github.com/jenkinsci/jenkins/compare/28984e5920c6...75eeccf8668e

          dogfood added a comment -

          Integrated in jenkins_main_trunk #3922
          JENKINS-26331 use buildDirectory system property to configure target directory (Revision 1fae8c072a1e8da360cd10dca8b82d1cd1b00968)

          Result = SUCCESS
          daniel.spilker : 1fae8c072a1e8da360cd10dca8b82d1cd1b00968
          Files :

          • test/src/main/java/org/jvnet/hudson/test/WarExploder.java

          dogfood added a comment - Integrated in jenkins_main_trunk #3922 JENKINS-26331 use buildDirectory system property to configure target directory (Revision 1fae8c072a1e8da360cd10dca8b82d1cd1b00968) Result = SUCCESS daniel.spilker : 1fae8c072a1e8da360cd10dca8b82d1cd1b00968 Files : test/src/main/java/org/jvnet/hudson/test/WarExploder.java

          Code changed in jenkins
          User: Daniel Spilker
          Path:
          CHANGELOG.md
          src/main/groovy/org/jenkinsci/gradle/plugins/jpi/JpiExtension.groovy
          src/main/groovy/org/jenkinsci/gradle/plugins/jpi/JpiPlugin.groovy
          http://jenkins-ci.org/commit/gradle-jpi-plugin/69770cfc9ea76121faf951b879461e78c51933ef
          Log:
          set buildDirectory system property for Jenkins test harness, JENKINS-26331

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Daniel Spilker Path: CHANGELOG.md src/main/groovy/org/jenkinsci/gradle/plugins/jpi/JpiExtension.groovy src/main/groovy/org/jenkinsci/gradle/plugins/jpi/JpiPlugin.groovy http://jenkins-ci.org/commit/gradle-jpi-plugin/69770cfc9ea76121faf951b879461e78c51933ef Log: set buildDirectory system property for Jenkins test harness, JENKINS-26331

          Code changed in jenkins
          User: Daniel Spilker
          Path:
          job-dsl-plugin/build.gradle
          http://jenkins-ci.org/commit/job-dsl-plugin/724d3f31e6781e03b7989f6e48c08dca7119d313
          Log:
          updated Gradle JPI plugin to 0.8.1, removed workaround for JENKINS-26331

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Daniel Spilker Path: job-dsl-plugin/build.gradle http://jenkins-ci.org/commit/job-dsl-plugin/724d3f31e6781e03b7989f6e48c08dca7119d313 Log: updated Gradle JPI plugin to 0.8.1, removed workaround for JENKINS-26331

          Code changed in jenkins
          User: Daniel Spilker
          Path:
          test/src/main/java/org/jvnet/hudson/test/WarExploder.java
          http://jenkins-ci.org/commit/jenkins-test-harness/9e3aa988ae25824817622df394af21b604e5f5ca
          Log:
          JENKINS-26331 use buildDirectory system property to configure target directory

          Originally-Committed-As: 1fae8c072a1e8da360cd10dca8b82d1cd1b00968

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Daniel Spilker Path: test/src/main/java/org/jvnet/hudson/test/WarExploder.java http://jenkins-ci.org/commit/jenkins-test-harness/9e3aa988ae25824817622df394af21b604e5f5ca Log: JENKINS-26331 use buildDirectory system property to configure target directory Originally-Committed-As: 1fae8c072a1e8da360cd10dca8b82d1cd1b00968

            daspilker Daniel Spilker
            daspilker Daniel Spilker
            Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

              Created:
              Updated:
              Resolved: