• Icon: Bug Bug
    • Resolution: Unresolved
    • Icon: Critical Critical
    • accurev-plugin
    • None
    • Platform: All, OS: All

      I have Hudson set up with a large number of jobs, one per stream in my AccuRev
      stream hierarchy. If I check in or promote a documentation change to any stream,
      it will trigger Hudson to execute builds against that stream and all lower level
      (child / development) streams that the documentation change flows down to. I
      want this build behavior for code changes, but not for documentation updates. I
      don't see any way to allow for this in Hudson, and Hudson seems to ignore the
      AccuRev include/exclude rules set up on my lower-level development streams that
      exclude the documentation directories.

          [JENKINS-2637] AccuRev include/exclude rules are ignored

          bbarlow added a comment -

          Created an attachment (id=535)
          fix to acknowledge include/exclude rules

          bbarlow added a comment - Created an attachment (id=535) fix to acknowledge include/exclude rules

          bbarlow added a comment -

          I pretty much did a complete rewrite of the checkStreamForChanges() method.
          This primarily addresses include/exclude rules, but I also added some
          edge cases where changes are promoted directly into time basis streams.

          I've tested this modification with Hudson versions from 1.279 back to (about)
          1.270, and some scattered older releases, running on RHEL5 and Windows XP. I
          also use AccuRev 4.6.1, although none of the changes require anything specific
          to 4.6.X.

          If interested, I can also post a (manual) test procedure I used while working up
          the fix.

          bbarlow added a comment - I pretty much did a complete rewrite of the checkStreamForChanges() method. This primarily addresses include/exclude rules, but I also added some edge cases where changes are promoted directly into time basis streams. I've tested this modification with Hudson versions from 1.279 back to (about) 1.270, and some scattered older releases, running on RHEL5 and Windows XP. I also use AccuRev 4.6.1, although none of the changes require anything specific to 4.6.X. If interested, I can also post a (manual) test procedure I used while working up the fix.

          Code changed in hudson
          User: : stephenconnolly
          Path:
          trunk/hudson/plugins/accurev/src/main/java/hudson/plugins/accurev/AccurevSCM.java
          http://fisheye4.cenqua.com/changelog/hudson/?cs=14895
          Log:
          JENKINS-2637 Copy of some of the changes from the supplied code... I'd prefer changes as diffs rather than the whole file as it can get tricky to apply multiples.

          SCM/JIRA link daemon added a comment - Code changed in hudson User: : stephenconnolly Path: trunk/hudson/plugins/accurev/src/main/java/hudson/plugins/accurev/AccurevSCM.java http://fisheye4.cenqua.com/changelog/hudson/?cs=14895 Log: JENKINS-2637 Copy of some of the changes from the supplied code... I'd prefer changes as diffs rather than the whole file as it can get tricky to apply multiples.

          There are some incorrect assumptions in your patch.... I'll need to refactor the
          plugin to correct them

          Stephen Connolly added a comment - There are some incorrect assumptions in your patch.... I'll need to refactor the plugin to correct them

          Scott Tatum added a comment -

          Reassigning all unresolved AccuRev tickets to me.

          Scott Tatum added a comment - Reassigning all unresolved AccuRev tickets to me.

          Scott Tatum added a comment -

          Setting myself as the QA contact.

          Scott Tatum added a comment - Setting myself as the QA contact.

          Scott Tatum added a comment -

          Setting to unassigned as I have no access to Accurev, and am no longer the maintainer of this plugin.

          Scott Tatum added a comment - Setting to unassigned as I have no access to Accurev, and am no longer the maintainer of this plugin.

          Arno Moonen added a comment -

          @bbarlow: Is this still an issue that needs to be fixed? If so, can you send in a PR on GitHub?

          Arno Moonen added a comment - @ bbarlow : Is this still an issue that needs to be fixed? If so, can you send in a PR on GitHub?

            Unassigned Unassigned
            bbarlow bbarlow
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated: