[JENKINS-26391] getAssignedLabel in MavenModule is implemented with lazy loading - Jenkins Jira

XML

Word

Printable

Details

Type: Bug
Status: Resolved (View Workflow)
Priority: Critical
Resolution: Fixed
Component/s: maven-plugin
Labels:
- lazy-loading
- performance

Similar Issues:

Show

Description

getAssignedLabel function seems to be triggering lazy loading in MavenModule class which can then take some time to complete.

Maybe should use getSameNodeConstraint

https://github.com/jenkinsci/maven-plugin/blob/master/src/main/java/hudson/maven/MavenModule.java#L459

Append by Steven Christou

Stack trace snippet below:

 - hudson.model.RunMap.retrieve(java.io.File) @bci=21, line=218 (Interpreted frame)
 - hudson.model.RunMap.retrieve(java.io.File) @bci=2, line=56 (Interpreted frame)
 - jenkins.model.lazy.AbstractLazyLoadRunMap.load(java.io.File, jenkins.model.lazy.AbstractLazyLoadRunMap$Index) @bci=2, line=688 (Interpreted frame)
 - jenkins.model.lazy.AbstractLazyLoadRunMap.load(int, jenkins.model.lazy.AbstractLazyLoadRunMap$Index) @bci=36, line=650 (Compiled frame)
 - jenkins.model.lazy.AbstractLazyLoadRunMap.search(int, jenkins.model.lazy.AbstractLazyLoadRunMap$Direction) @bci=80, line=382 (Compiled frame)
 - jenkins.model.lazy.LazyBuildMixIn$RunMixIn.getPreviousBuild() @bci=78, line=366 (Interpreted frame)
 - hudson.model.AbstractBuild.getPreviousBuild() @bci=4, line=196 (Interpreted frame)
 - hudson.model.AbstractBuild.getPreviousBuild() @bci=1, line=104 (Interpreted frame)
 - hudson.tasks.Fingerprinter$FingerprintAction.compact() @bci=14, line=352 (Interpreted frame)
 - hudson.tasks.Fingerprinter$FingerprintAction.onLoad(hudson.model.Run) @bci=6, line=341 (Interpreted frame)
 - hudson.model.Run.onLoad() @bci=41, line=342 (Compiled frame)
 - hudson.maven.MavenModuleSetBuild.onLoad() @bci=1, line=151 (Interpreted frame)
 - hudson.model.RunMap.retrieve(java.io.File) @bci=28, line=219 (Interpreted frame)
 - hudson.model.RunMap.retrieve(java.io.File) @bci=2, line=56 (Interpreted frame)
 - jenkins.model.lazy.AbstractLazyLoadRunMap.load(java.io.File, jenkins.model.lazy.AbstractLazyLoadRunMap$Index) @bci=2, line=688 (Interpreted frame)
 - jenkins.model.lazy.AbstractLazyLoadRunMap.load(int, jenkins.model.lazy.AbstractLazyLoadRunMap$Index) @bci=36, line=650 (Compiled frame)
 - jenkins.model.lazy.AbstractLazyLoadRunMap.search(int, jenkins.model.lazy.AbstractLazyLoadRunMap$Direction) @bci=80, line=382 (Compiled frame)
 - jenkins.model.lazy.AbstractLazyLoadRunMap.getByNumber(int) @bci=5, line=547 (Compiled frame)
 - jenkins.model.lazy.AbstractLazyLoadRunMap.search(int, jenkins.model.lazy.AbstractLazyLoadRunMap$Direction) @bci=176, line=393 (Compiled frame)
 - jenkins.model.lazy.AbstractLazyLoadRunMap.newestBuild() @bci=6, line=335 (Compiled frame)
 - jenkins.model.lazy.LazyBuildMixIn.getLastBuild() @bci=4, line=249 (Compiled frame)
 - hudson.model.AbstractProject.getLastBuild() @bci=4, line=974 (Compiled frame)
 - hudson.model.AbstractProject.getLastBuiltOn() @bci=1, line=1038 (Compiled frame)
 - hudson.maven.MavenModule.getAssignedLabel() @bci=4, line=460 (Interpreted frame)
 - hudson.model.Label.getTiedJobCount() @bci=176, line=392 (Compiled frame)

Attachments

Issue Links

depends on

JENKINS-19392 First-time display with many Maven jobs blocked in FingerprintAction.compact

Resolved

links to

PR 38

Activity

Ascending order - Click to sort in descending order

Félix Belzunce Arcos created issue - 2015-01-12 13:07

Steven Christou made changes - 2015-02-02 22:06

Field	Original Value	New Value
Component/s	performance-plugin [ 15803 ]
Labels		lazy-loading performance

Hide

Permalink

Steven Christou added a comment - 2015-02-02 22:07

Upgrading priority to critical as something as simple as viewing the Labels build results can trigger this.

Show

Steven Christou added a comment - 2015-02-02 22:07 Upgrading priority to critical as something as simple as viewing the Labels build results can trigger this.

Steven Christou made changes - 2015-02-02 22:07

Priority

Minor [ 4 ]

Critical [ 2 ]

Steven Christou made changes - 2015-02-02 22:13

Assignee

Félix Belzunce Arcos [ fbelzunc ]

Steven Christou [ schristou ]

Steven Christou made changes - 2015-02-05 10:18

Remote Link

This issue links to "PR 38 (Web Link)" [ 12103 ]

Hide

Permalink

Jesse Glick added a comment - 2015-02-05 13:19

You should include a sample stack trace from a thread dump.

Show

Jesse Glick added a comment - 2015-02-05 13:19 You should include a sample stack trace from a thread dump.

Steven Christou made changes - 2015-02-05 22:10

Description

getAssignedLabel function seems to be triggering lazy loading in MavenModule class which can then take some time to complete.

Maybe should use getSameNodeConstraint

https://github.com/jenkinsci/maven-plugin/blob/master/src/main/java/hudson/maven/MavenModule.java#L459

Append by [~schristou]

Stack trace snippet below:

{noformat}
- hudson.model.RunMap.retrieve(java.io.File) @bci=21, line=218 (Interpreted frame)
- hudson.model.RunMap.retrieve(java.io.File) @bci=2, line=56 (Interpreted frame)
- jenkins.model.lazy.AbstractLazyLoadRunMap.load(java.io.File, jenkins.model.lazy.AbstractLazyLoadRunMap$Index) @bci=2, line=688 (Interpreted frame)
- jenkins.model.lazy.AbstractLazyLoadRunMap.load(int, jenkins.model.lazy.AbstractLazyLoadRunMap$Index) @bci=36, line=650 (Compiled frame)
- jenkins.model.lazy.AbstractLazyLoadRunMap.search(int, jenkins.model.lazy.AbstractLazyLoadRunMap$Direction) @bci=80, line=382 (Compiled frame)
- jenkins.model.lazy.LazyBuildMixIn$RunMixIn.getPreviousBuild() @bci=78, line=366 (Interpreted frame)
- hudson.model.AbstractBuild.getPreviousBuild() @bci=4, line=196 (Interpreted frame)
- hudson.model.AbstractBuild.getPreviousBuild() @bci=1, line=104 (Interpreted frame)
- hudson.tasks.Fingerprinter$FingerprintAction.compact() @bci=14, line=352 (Interpreted frame)
- hudson.tasks.Fingerprinter$FingerprintAction.onLoad(hudson.model.Run) @bci=6, line=341 (Interpreted frame)
- hudson.model.Run.onLoad() @bci=41, line=342 (Compiled frame)
- hudson.maven.MavenModuleSetBuild.onLoad() @bci=1, line=151 (Interpreted frame)
- hudson.model.RunMap.retrieve(java.io.File) @bci=28, line=219 (Interpreted frame)
- hudson.model.RunMap.retrieve(java.io.File) @bci=2, line=56 (Interpreted frame)
- jenkins.model.lazy.AbstractLazyLoadRunMap.load(java.io.File, jenkins.model.lazy.AbstractLazyLoadRunMap$Index) @bci=2, line=688 (Interpreted frame)
- jenkins.model.lazy.AbstractLazyLoadRunMap.load(int, jenkins.model.lazy.AbstractLazyLoadRunMap$Index) @bci=36, line=650 (Compiled frame)
- jenkins.model.lazy.AbstractLazyLoadRunMap.search(int, jenkins.model.lazy.AbstractLazyLoadRunMap$Direction) @bci=80, line=382 (Compiled frame)
- jenkins.model.lazy.AbstractLazyLoadRunMap.getByNumber(int) @bci=5, line=547 (Compiled frame)
- jenkins.model.lazy.AbstractLazyLoadRunMap.search(int, jenkins.model.lazy.AbstractLazyLoadRunMap$Direction) @bci=176, line=393 (Compiled frame)
- jenkins.model.lazy.AbstractLazyLoadRunMap.newestBuild() @bci=6, line=335 (Compiled frame)
- jenkins.model.lazy.LazyBuildMixIn.getLastBuild() @bci=4, line=249 (Compiled frame)
- hudson.model.AbstractProject.getLastBuild() @bci=4, line=974 (Compiled frame)
- hudson.model.AbstractProject.getLastBuiltOn() @bci=1, line=1038 (Compiled frame)
- hudson.maven.MavenModule.getAssignedLabel() @bci=4, line=460 (Interpreted frame)
- hudson.model.Label.getTiedJobCount() @bci=176, line=392 (Compiled frame)
{noformat}

Hide

Permalink

Jesse Glick added a comment - 2015-02-05 22:51

Note that the fix of ~~JENKINS-19392~~ probably would have helped here too.

Show

Jesse Glick added a comment - 2015-02-05 22:51 Note that the fix of JENKINS-19392 probably would have helped here too.

Jesse Glick made changes - 2015-02-05 22:51

Link

This issue depends on ~~JENKINS-19392~~ [ ~~JENKINS-19392~~ ]

Hide

Permalink

SCM/JIRA link daemon added a comment - 2015-03-27 09:37

Code changed in jenkins
User: christ66
Path:
core/src/main/java/hudson/model/Label.java
test/src/test/java/hudson/model/NodeTest.java
http://jenkins-ci.org/commit/jenkins/7a2dc32cc3b309a4391ada820732a550d9d4badc
Log:
~~JENKINS-26391~~ Prevent lazy loading operation when obtaining label information.

Show

SCM/JIRA link daemon added a comment - 2015-03-27 09:37 Code changed in jenkins User: christ66 Path: core/src/main/java/hudson/model/Label.java test/src/test/java/hudson/model/NodeTest.java http://jenkins-ci.org/commit/jenkins/7a2dc32cc3b309a4391ada820732a550d9d4badc Log: JENKINS-26391 Prevent lazy loading operation when obtaining label information.

Hide

Permalink

SCM/JIRA link daemon added a comment - 2015-03-27 10:34

Code changed in jenkins
User: Stephen Connolly
Path:
changelog.html
http://jenkins-ci.org/commit/jenkins/46dc6850edb1d7ef52592794b15e69db7dfbed1a
Log:
Noting merges

Fixing link text for JENKINS-6167

Show

SCM/JIRA link daemon added a comment - 2015-03-27 10:34 Code changed in jenkins User: Stephen Connolly Path: changelog.html http://jenkins-ci.org/commit/jenkins/46dc6850edb1d7ef52592794b15e69db7dfbed1a Log: Noting merges JENKINS-15355 JENKINS-21618 JENKINS-22941 JENKINS-25938 JENKINS-26391 JENKINS-26900 JENKINS-27476 JENKINS-27563 JENKINS-27564 JENKINS-27565 JENKINS-27566 Fixing link text for JENKINS-6167

Hide

Permalink

dogfood added a comment - 2015-03-27 10:59

Integrated in jenkins_main_trunk #4040
~~JENKINS-26391~~ Prevent lazy loading operation when obtaining label information. (Revision 7a2dc32cc3b309a4391ada820732a550d9d4badc)

Result = SUCCESS
schristou88 : 7a2dc32cc3b309a4391ada820732a550d9d4badc
Files :

core/src/main/java/hudson/model/Label.java
test/src/test/java/hudson/model/NodeTest.java

Show

dogfood added a comment - 2015-03-27 10:59 Integrated in jenkins_main_trunk #4040 JENKINS-26391 Prevent lazy loading operation when obtaining label information. (Revision 7a2dc32cc3b309a4391ada820732a550d9d4badc) Result = SUCCESS schristou88 : 7a2dc32cc3b309a4391ada820732a550d9d4badc Files : core/src/main/java/hudson/model/Label.java test/src/test/java/hudson/model/NodeTest.java

Hide

Permalink

SCM/JIRA link daemon added a comment - 2015-03-27 14:09

Code changed in jenkins
User: Stephen Connolly
Path:
core/src/main/java/hudson/model/Label.java
http://jenkins-ci.org/commit/jenkins/98605d0afb441f7953875097953e626128d31825
Log:
After ~~JENKINS-26391~~ we need to compare labels based on matching names not instance identity

Show

SCM/JIRA link daemon added a comment - 2015-03-27 14:09 Code changed in jenkins User: Stephen Connolly Path: core/src/main/java/hudson/model/Label.java http://jenkins-ci.org/commit/jenkins/98605d0afb441f7953875097953e626128d31825 Log: After JENKINS-26391 we need to compare labels based on matching names not instance identity

Hide

Permalink

Steven Christou added a comment - 2015-04-02 06:04

Marking as resolved. This was fixed as part of https://github.com/jenkinsci/jenkins/pull/1574 which is in 1.607+.

Show

Steven Christou added a comment - 2015-04-02 06:04 Marking as resolved. This was fixed as part of https://github.com/jenkinsci/jenkins/pull/1574 which is in 1.607+.

Steven Christou made changes - 2015-04-02 06:04

Resolution		Fixed [ 1 ]
Status	Open [ 1 ]	Resolved [ 5 ]

Ireneusz Makowski made changes - 2015-04-22 22:42

Labels

lazy-loading performance

lazy-loading lts-candidate performance

Oliver Gondža made changes - 2015-05-05 19:35

Labels

lazy-loading lts-candidate performance

lazy-loading performance

Hide

Permalink

Oliver Gondža added a comment - 2015-05-05 19:36

This is part of 1.609, will be in next LTS.

Show

Oliver Gondža added a comment - 2015-05-05 19:36 This is part of 1.609, will be in next LTS.

R. Tyler Croy made changes - 2016-07-25 23:56

Workflow

JNJira [ 160457 ]

JNJira + In-Review [ 196441 ]

People

Assignee:: Steven Christou

Reporter:: Félix Belzunce Arcos

Votes:: 0 Vote for this issue

Watchers:: 6 Start watching this issue

Dates

Created:: 2015-01-12 13:07

Updated:: 2015-05-05 19:36

Resolved:: 2015-04-02 06:04