Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-26406

Build history text field wrap fails when containing markup

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Minor Minor
    • core
    • Jenkins 1.596 with description-setter plugin 1.9 (and other plugins, including build-name-setter )

      Upgrading from 1.578 to 1.596, I find that all the links I have in the build descriptions don't work in the build history (they do work on the build's main page).

      I use the description-setter to set discriptions like:
      <a href="${JOB_URL}../compiler=vc12/${BUILD_NUMBER}/console">win console</a>
      to link directly to the console form each job. (And 3 more links, to the build results and then the same for the mac build of this Multi-configuration project). These links still show as links on job/myjob/xx/ but only the text shows in the build history 'sidebar'. I add these links mostly for use from the sidebar (to save clicks and page load time when going to the console and build artefacts for a specific build).

      Looking through the Jenkins Changelog, I'm guessing this may be the result of the change in 1.593 (or maybe issue 16184?). The plugin itself did not change. I'm not sure if this change was intentional or not, at least nothing in the changelog seems to indicate it was.

          [JENKINS-26406] Build history text field wrap fails when containing markup

          Daniel Beck added a comment -

          Arnt: Lame excuse. This is easy enough to test on a test instance. Download, java -jar jenkins.war and in two minutes you know whether it works.

          Daniel Beck added a comment - Arnt: Lame excuse. This is easy enough to test on a test instance. Download, java -jar jenkins.war and in two minutes you know whether it works.

          Code changed in jenkins
          User: tfennelly
          Path:
          war/src/main/webapp/css/style.css
          war/src/main/webapp/scripts/hudson-behavior.js
          http://jenkins-ci.org/commit/jenkins/b31bb1cc1c5a61a3e984e45e33cafa6130517938
          Log:
          [FIXED JENKINS-26406] Build history text field wrap fails when containing markup

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: tfennelly Path: war/src/main/webapp/css/style.css war/src/main/webapp/scripts/hudson-behavior.js http://jenkins-ci.org/commit/jenkins/b31bb1cc1c5a61a3e984e45e33cafa6130517938 Log: [FIXED JENKINS-26406] Build history text field wrap fails when containing markup

          Code changed in jenkins
          User: Tom Fennelly
          Path:
          war/src/main/webapp/css/style.css
          war/src/main/webapp/scripts/hudson-behavior.js
          http://jenkins-ci.org/commit/jenkins/a7a48abea71317a5a71335428e44e4db701cdb82
          Log:
          Merge pull request #1542 from tfennelly/JENKINS-26406

          [FIXED JENKINS-26406] Build history text field wrap fails when containing markup

          Compare: https://github.com/jenkinsci/jenkins/compare/a944634e4f2f...a7a48abea713

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Tom Fennelly Path: war/src/main/webapp/css/style.css war/src/main/webapp/scripts/hudson-behavior.js http://jenkins-ci.org/commit/jenkins/a7a48abea71317a5a71335428e44e4db701cdb82 Log: Merge pull request #1542 from tfennelly/ JENKINS-26406 [FIXED JENKINS-26406] Build history text field wrap fails when containing markup Compare: https://github.com/jenkinsci/jenkins/compare/a944634e4f2f...a7a48abea713

          Code changed in jenkins
          User: tfennelly
          Path:
          changelog.html
          http://jenkins-ci.org/commit/jenkins/c78d1519a12bc6e6dfd393926402f5083ddba0c2
          Log:
          Noting JENKINS-26406

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: tfennelly Path: changelog.html http://jenkins-ci.org/commit/jenkins/c78d1519a12bc6e6dfd393926402f5083ddba0c2 Log: Noting JENKINS-26406

          dogfood added a comment -

          Integrated in jenkins_main_trunk #3967
          [FIXED JENKINS-26406] Build history text field wrap fails when containing markup (Revision b31bb1cc1c5a61a3e984e45e33cafa6130517938)

          Result = SUCCESS
          tom.fennelly : b31bb1cc1c5a61a3e984e45e33cafa6130517938
          Files :

          • war/src/main/webapp/css/style.css
          • war/src/main/webapp/scripts/hudson-behavior.js

          dogfood added a comment - Integrated in jenkins_main_trunk #3967 [FIXED JENKINS-26406] Build history text field wrap fails when containing markup (Revision b31bb1cc1c5a61a3e984e45e33cafa6130517938) Result = SUCCESS tom.fennelly : b31bb1cc1c5a61a3e984e45e33cafa6130517938 Files : war/src/main/webapp/css/style.css war/src/main/webapp/scripts/hudson-behavior.js

          Hmm, you're right Daniel, I could only think of testing this with real data, but that's not really needed here of course. I see this was pushed to the main_trunk by now, does this mean it will be in the next release (I'll just test it by upgrading then)?

          Arnt Witteveen added a comment - Hmm, you're right Daniel, I could only think of testing this with real data, but that's not really needed here of course. I see this was pushed to the main_trunk by now, does this mean it will be in the next release (I'll just test it by upgrading then)?

          Daniel Beck added a comment -

          It'll be in 1.600. (The delayed release due to the RC process means turnaround time on everything feels like forever, so it's more important to test early!)

          Daniel Beck added a comment - It'll be in 1.600. (The delayed release due to the RC process means turnaround time on everything feels like forever, so it's more important to test early!)

          Code changed in jenkins
          User: tfennelly
          Path:
          war/src/main/webapp/css/style.css
          war/src/main/webapp/scripts/hudson-behavior.js
          http://jenkins-ci.org/commit/jenkins/446f3cae9f1e660ae48e989a561b7d1ddb722127
          Log:
          [FIXED JENKINS-26406] Build history text field wrap fails when containing markup

          (cherry picked from commit b31bb1cc1c5a61a3e984e45e33cafa6130517938)

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: tfennelly Path: war/src/main/webapp/css/style.css war/src/main/webapp/scripts/hudson-behavior.js http://jenkins-ci.org/commit/jenkins/446f3cae9f1e660ae48e989a561b7d1ddb722127 Log: [FIXED JENKINS-26406] Build history text field wrap fails when containing markup (cherry picked from commit b31bb1cc1c5a61a3e984e45e33cafa6130517938)

          Daryl Spartz added a comment -

          The patch fixed a problem we discovered with html hyperlink in build description not being clickable. Please add to next LTS

          Daryl Spartz added a comment - The patch fixed a problem we discovered with html hyperlink in build description not being clickable. Please add to next LTS

          dogfood added a comment -

          Integrated in jenkins_main_trunk #4292
          [FIXED JENKINS-26406] Build history text field wrap fails when containing markup (Revision 446f3cae9f1e660ae48e989a561b7d1ddb722127)

          Result = UNSTABLE
          ogondza : 446f3cae9f1e660ae48e989a561b7d1ddb722127
          Files :

          • war/src/main/webapp/css/style.css
          • war/src/main/webapp/scripts/hudson-behavior.js

          dogfood added a comment - Integrated in jenkins_main_trunk #4292 [FIXED JENKINS-26406] Build history text field wrap fails when containing markup (Revision 446f3cae9f1e660ae48e989a561b7d1ddb722127) Result = UNSTABLE ogondza : 446f3cae9f1e660ae48e989a561b7d1ddb722127 Files : war/src/main/webapp/css/style.css war/src/main/webapp/scripts/hudson-behavior.js

            tfennelly Tom FENNELLY
            legolas Arnt Witteveen
            Votes:
            3 Vote for this issue
            Watchers:
            10 Start watching this issue

              Created:
              Updated:
              Resolved: