Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-26406

Build history text field wrap fails when containing markup

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Minor Minor
    • core
    • Jenkins 1.596 with description-setter plugin 1.9 (and other plugins, including build-name-setter )

      Upgrading from 1.578 to 1.596, I find that all the links I have in the build descriptions don't work in the build history (they do work on the build's main page).

      I use the description-setter to set discriptions like:
      <a href="${JOB_URL}../compiler=vc12/${BUILD_NUMBER}/console">win console</a>
      to link directly to the console form each job. (And 3 more links, to the build results and then the same for the mac build of this Multi-configuration project). These links still show as links on job/myjob/xx/ but only the text shows in the build history 'sidebar'. I add these links mostly for use from the sidebar (to save clicks and page load time when going to the console and build artefacts for a specific build).

      Looking through the Jenkins Changelog, I'm guessing this may be the result of the change in 1.593 (or maybe issue 16184?). The plugin itself did not change. I'm not sure if this change was intentional or not, at least nothing in the changelog seems to indicate it was.

          [JENKINS-26406] Build history text field wrap fails when containing markup

          Arnt Witteveen created issue -

          Daniel Beck added a comment -

          JENKINS-16184 is unrelated.

          The 1.593 change may be related.

          Could you please confirm that you have a HTML markup formatter selected in Manage Jenkins / Configure Global Security?

          Daniel Beck added a comment - JENKINS-16184 is unrelated. The 1.593 change may be related. Could you please confirm that you have a HTML markup formatter selected in Manage Jenkins / Configure Global Security?

          Kari Sivonen added a comment -

          I have a same problem. I checked that Safe HTML is selected in HTML markup formatter. And in job build page HTML format is shown correct.

          I have also 1.596 version, but I think this change is related to 1.593 changes and issue JENKINS-25381

          Kari Sivonen added a comment - I have a same problem. I checked that Safe HTML is selected in HTML markup formatter. And in job build page HTML format is shown correct. I have also 1.596 version, but I think this change is related to 1.593 changes and issue JENKINS-25381
          Daniel Beck made changes -
          Link New: This issue is duplicated by JENKINS-26539 [ JENKINS-26539 ]

          Tom FENNELLY added a comment -

          I'd say what's happening here is that the code I added tries to insert invisible line-break characters into the cell text, which screws up markup. Sorry about that guys. I'll try get a fix ASAP.

          Tom FENNELLY added a comment - I'd say what's happening here is that the code I added tries to insert invisible line-break characters into the cell text, which screws up markup. Sorry about that guys. I'll try get a fix ASAP.
          Tom FENNELLY made changes -
          Assignee New: Tom FENNELLY [ tfennelly ]

          Tom FENNELLY added a comment -

          Guys, can someone give me an explanation of how best to set this up please? I installed the Description Setter plugin (https://wiki.jenkins-ci.org/display/JENKINS/Description+Setter+Plugin). I read the instructions for using it but they're a head wrecker so maybe if someone could just tell me the steps to reproduce this in some way i.e. what values to put in what fields and where.

          Tom FENNELLY added a comment - Guys, can someone give me an explanation of how best to set this up please? I installed the Description Setter plugin ( https://wiki.jenkins-ci.org/display/JENKINS/Description+Setter+Plugin ). I read the instructions for using it but they're a head wrecker so maybe if someone could just tell me the steps to reproduce this in some way i.e. what values to put in what fields and where.

          Daniel Beck added a comment -

          Tom: As geekdave and me wrote in the original PR, it's sufficient to set up Jenkins to use the Safe HTML markup formatter, and enter an HTML build description.

          Daniel Beck added a comment - Tom: As geekdave and me wrote in the original PR , it's sufficient to set up Jenkins to use the Safe HTML markup formatter, and enter an HTML build description.

          Tom FENNELLY added a comment -

          Daniel, you're a star ! Thanks.

          Tom FENNELLY added a comment - Daniel, you're a star ! Thanks.

          Tom FENNELLY added a comment -

          I don't have a "Safe HTML" option in my formatters (security is enabled etc). I installed the anything goes formatter too but it doesn't seem to make a difference in terms of the build description - html tags are always being removed for e.g. https://www.dropbox.com/s/saf8bvg054ee8y1/Screenshot%202015-01-23%2007.52.17.png?dl=0 appears as regular text in the page i.e. view source, tags are removed.

          Tom FENNELLY added a comment - I don't have a "Safe HTML" option in my formatters (security is enabled etc). I installed the anything goes formatter too but it doesn't seem to make a difference in terms of the build description - html tags are always being removed for e.g. https://www.dropbox.com/s/saf8bvg054ee8y1/Screenshot%202015-01-23%2007.52.17.png?dl=0 appears as regular text in the page i.e. view source, tags are removed.

            tfennelly Tom FENNELLY
            legolas Arnt Witteveen
            Votes:
            3 Vote for this issue
            Watchers:
            10 Start watching this issue

              Created:
              Updated:
              Resolved: