Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-26438

"Keep this build forever" button not visible if BuildDiscarder other than LogRotator is configured

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Major Major
    • core
    • Jenkins 1.565.1

      The button "Keep this build forever" is not visible in the build summary page when a BuildDiscarder other than LogRotator is configured. I don't think this is intentionally.

      The problem is in Jelly file core\src\main\resources\hudson\model\Run\logKeep.jelly, line 30:

      <j:if test="${it.parent.logRotator!=null and it.canToggleLogKeep()}">
      

      Should be fixed to:

      <j:if test="${it.parent.buildDiscarder!=null and it.canToggleLogKeep()}">
      

          [JENKINS-26438] "Keep this build forever" button not visible if BuildDiscarder other than LogRotator is configured

          Daniel Beck added a comment -

          I agree. Great analysis!

          Daniel Beck added a comment - I agree. Great analysis!

          Alexander A added a comment -

          danielbeck, could you fix it in next release, please? It's quite painful to use default LogRotator.

          Alexander A added a comment - danielbeck , could you fix it in next release, please? It's quite painful to use default LogRotator.

          Daniel Beck added a comment -

          Sorry about that delay. I'll try to get it done soon.

          Daniel Beck added a comment - Sorry about that delay. I'll try to get it done soon.

          Daniel Beck added a comment -

          Again, sorry about the delay. In the future, this is something where you could definitely file a PR to get it fixed more quickly

          https://github.com/jenkinsci/jenkins/pull/2443

          Daniel Beck added a comment - Again, sorry about the delay. In the future, this is something where you could definitely file a PR to get it fixed more quickly https://github.com/jenkinsci/jenkins/pull/2443

          Alexander A added a comment -

          danielbeck, I didn't know that it's possible to create PR without signed CLA. Anyway, thanks a lot!

          Alexander A added a comment - danielbeck , I didn't know that it's possible to create PR without signed CLA. Anyway, thanks a lot!

          Daniel Beck added a comment -

          Merged towards 2.14.

          Daniel Beck added a comment - Merged towards 2.14.

            danielbeck Daniel Beck
            matmoers Matthias Moers
            Votes:
            1 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated:
              Resolved: