Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-26665

Complete lack of correct synchronization or concern for thread safety in mansion cloud plugin

      So the mansion cloud plugin does not pay attention to locking when removing nodes. This can result in builds starting on a node that does not exist or a build being aborted while in progress as it gets removed. This will result in stack traces such as:

      java.lang.IllegalStateException: no longer a configured node for 1f13542c
      at hudson.model.AbstractBuild$AbstractBuildExecution.getCurrentNode(AbstractBuild.java:462)
      at hudson.model.AbstractBuild$AbstractBuildExecution.run(AbstractBuild.java:494)
      at hudson.model.Run.execute(Run.java:1745)
      at hudson.matrix.MatrixRun.run(MatrixRun.java:146)
      at hudson.model.ResourceController.execute(ResourceController.java:89)
      at hudson.model.Executor.run(Executor.java:240)
      

      For correct behaviour look at some of the recent changes to the durable builds plugin within the retention strategy (or - if you are a bee - the closed source operations-center-cloud or nectar-vmware plugins of CloudBees... though this should just be additional examples of the changes pushed to the durable tasks plugin)

          [JENKINS-26665] Complete lack of correct synchronization or concern for thread safety in mansion cloud plugin

          Antoine Musso added a comment -

          Antoine Musso added a comment - I looked at the git log for the durable task plugin. Seems Stephen refer to: JENKINS-26380 Pull request: https://github.com/jenkinsci/durable-task-plugin/pull/2 Commit: https://github.com/jenkinsci/durable-task-plugin/commit/cce88cad22f78997d6a7b839fb3f2f75b4ce94c9 And there is a follow up: Pull request: https://github.com/jenkinsci/durable-task-plugin/pull/3 Commit: https://github.com/jenkinsci/durable-task-plugin/commit/12c593402410034fe6e9f066d5fb4c1503891d54

            Unassigned Unassigned
            stephenconnolly Stephen Connolly
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated: