Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-26840

GitHub Pull request plugin v1.16-8 builds master instead of PR

XMLWordPrintable

      After updating from version 1.16-5 to 1.16-8 early February, I noticed that pull request from GitHub were building master instead of the PR content.

      Feel free to browse build history at Ehcache on cloudbees

      See logs from last valid PR build:

      GitHub pull request #277 of commit c86d869f7fadf3e35e4ba23c08dae31dc57c8a3d automatically merged.
      Building in workspace /home/ehcache/hudson_home/workspace/ehcache3-pull-requests
      Wiping out workspace first.
      Cloning the remote Git repository
      Cloning repository https://github.com/ehcache/ehcache3.git
       > git init /home/ehcache/hudson_home/workspace/ehcache3-pull-requests # timeout=10
      Fetching upstream changes from https://github.com/ehcache/ehcache3.git
       > git --version # timeout=10
       > git fetch --tags --progress https://github.com/ehcache/ehcache3.git +refs/heads/*:refs/remotes/origin/*
       > git config remote.origin.url https://github.com/ehcache/ehcache3.git # timeout=10
       > git config remote.origin.fetch +refs/heads/*:refs/remotes/origin/* # timeout=10
       > git config remote.origin.url https://github.com/ehcache/ehcache3.git # timeout=10
      Fetching upstream changes from https://github.com/ehcache/ehcache3.git
       > git fetch --tags --progress https://github.com/ehcache/ehcache3.git +refs/pull/*:refs/remotes/origin/pr/*
       > git rev-parse origin/pr/277/merge^{commit} # timeout=10
      Checking out Revision 3d9700fbdeedd2a1d3756c299d3d180cde52f2e6 (detached)
       > git config core.sparsecheckout # timeout=10
       > git checkout -f 3d9700fbdeedd2a1d3756c299d3d180cde52f2e6
       > git rev-list c2c66f56edb44abda3ce63a37f899252f3b2c9da # timeout=10
      No emails were triggered.
      Triggering ehcache3-pull-requests » Oracle JDK 1.8(latest)
      Triggering ehcache3-pull-requests » Sun JDK 1.6 (latest)
      Triggering ehcache3-pull-requests » Oracle JDK 1.7 (latest)
      Configuration ehcache3-pull-requests » Oracle JDK 1.8(latest) is still in the queue: Waiting for next available executor
      ehcache3-pull-requests » Oracle JDK 1.8(latest) completed with result SUCCESS
      ehcache3-pull-requests » Sun JDK 1.6 (latest) completed with result SUCCESS
      ehcache3-pull-requests » Oracle JDK 1.7 (latest) completed with result SUCCESS
      No emails were triggered.
      Finished: SUCCESS
      

      The line git rev-parse origin/pr/277/merge^{commit} indicates that the PR was built.

      Then all build after 477 look as follows (this one for example):

      GitHub pull request #274 of commit 65127d8a1bbddf9d715d2491c614bbcf5604b52a automatically merged.
      Setting status of 65127d8a1bbddf9d715d2491c614bbcf5604b52a to PENDING with url https://ehcache.ci.cloudbees.com/job/ehcache3-pull-requests/495/ and message: Merged build started.
      Building remotely on dd2e8c91 (lxc-fedora17 m1.small small) in workspace /scratch/jenkins/workspace/ehcache3-pull-requests
      Wiping out workspace first.
      Cloning the remote Git repository
      Cloning repository https://github.com/ehcache/ehcache3.git
       > git init /scratch/jenkins/workspace/ehcache3-pull-requests # timeout=10
      Fetching upstream changes from https://github.com/ehcache/ehcache3.git
       > git --version # timeout=10
       > git -c core.askpass=true fetch --tags --progress https://github.com/ehcache/ehcache3.git +refs/heads/*:refs/remotes/origin/*
       > git config remote.origin.url https://github.com/ehcache/ehcache3.git # timeout=10
       > git config remote.origin.fetch +refs/heads/*:refs/remotes/origin/* # timeout=10
       > git config remote.origin.url https://github.com/ehcache/ehcache3.git # timeout=10
      Fetching upstream changes from https://github.com/ehcache/ehcache3.git
       > git -c core.askpass=true fetch --tags --progress https://github.com/ehcache/ehcache3.git +refs/pull/*:refs/remotes/origin/pr/*
       > git rev-parse refs/remotes/origin/master^{commit} # timeout=10
       > git rev-parse refs/remotes/origin/origin/master^{commit} # timeout=10
      Checking out Revision 954e6f0ffc324a384f4fae14bc9419a301020a3f (refs/remotes/origin/master)
       > git config core.sparsecheckout # timeout=10
       > git checkout -f 954e6f0ffc324a384f4fae14bc9419a301020a3f
       > git rev-list 155c4774863ea30e6679b0c8837f2060b2d0bed2 # timeout=10
      No emails were triggered.
      Triggering ehcache3-pull-requests » Oracle JDK 1.7 (latest)
      Triggering ehcache3-pull-requests » Sun JDK 1.6 (latest)
      Triggering ehcache3-pull-requests » Oracle JDK 1.8(latest)
      ehcache3-pull-requests » Oracle JDK 1.7 (latest) completed with result SUCCESS
      ehcache3-pull-requests » Sun JDK 1.6 (latest) completed with result SUCCESS
      ehcache3-pull-requests » Oracle JDK 1.8(latest) completed with result SUCCESS
      No emails were triggered.
      Setting status of 65127d8a1bbddf9d715d2491c614bbcf5604b52a to SUCCESS with url https://ehcache.ci.cloudbees.com/job/ehcache3-pull-requests/495/ and message: Merged build finished.
      Finished: SUCCESS
      

      There are two git rev-parse lines but they both look at master instead of the PR. And you can see that what is checked out (954e6f0ffc324a384f4fae14bc9419a301020a3f) is different than what is announced at the top (c86d869f7fadf3e35e4ba23c08dae31dc57c8a3d).

      I have downgraded the plugin back to version 1.16-5, and the latest build at this time is now a valid PR build once more.

            janinko Honza Brázdil
            ljacomet Louis Jacomet
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated:
              Resolved: