Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-26848

Does not actually randomize DISPLAY

    XMLWordPrintable

    Details

    • Similar Issues:

      Description

      The docs say displayName is "(default) choosen by random"

      The code comments on the variable say "DISPLAY name, if NULL chosen by random."

      The actual contents of src/main/java/org/jenkinsci/plugins/xvfb/XvfbBuildWrapper.java L470 say that it will always use executor.getNumber() + displayNameOffset - which always returns displayNameOffset (default 1).

      As a result, DISPLAY is always 1.

      Using autoDisplayName is not an option, because it requires a version of Xvfb far too new for our builders (1.14 I think?)

        Attachments

          Activity

          Hide
          directhex Jo Shields added a comment -

          Amazing. I'll try that next time I'm near a computer - I'd rather not break a production system from a smartphone

          Show
          directhex Jo Shields added a comment - Amazing. I'll try that next time I'm near a computer - I'd rather not break a production system from a smartphone
          Hide
          directhex Jo Shields added a comment -
          Show
          directhex Jo Shields added a comment - Doesn't seem to be in http://ftp-chi.osuosl.org/pub/jenkins/updates/experimental/update-center.json or http://updates.jenkins-ci.org/download/plugins/xvfb/ - do you have a direct link to the .hpi I can use?
          Hide
          directhex Jo Shields added a comment -

          Never mind, I'm a big boy and I can build from a git tag.

          Seems to work - https://jenkins.mono-project.com/job/test-mono-mainline/993/label=debian-armhf/console and https://jenkins.mono-project.com/job/test-mono-mainline/993/label=debian-armel/console you can see one build using :1401 and one using :1501. Yay!

          Show
          directhex Jo Shields added a comment - Never mind, I'm a big boy and I can build from a git tag. Seems to work - https://jenkins.mono-project.com/job/test-mono-mainline/993/label=debian-armhf/console and https://jenkins.mono-project.com/job/test-mono-mainline/993/label=debian-armel/console you can see one build using :1401 and one using :1501. Yay!
          Hide
          zregvart zregvart added a comment -

          Thank you for testing, I'll make the release. The update centers are periodically updated so it should be under 24 hours until it's available in the regular update center...

          Show
          zregvart zregvart added a comment - Thank you for testing, I'll make the release. The update centers are periodically updated so it should be under 24 hours until it's available in the regular update center...
          Hide
          zregvart zregvart added a comment -

          Closing old/resolved issue.

          Show
          zregvart zregvart added a comment - Closing old/resolved issue.

            People

            Assignee:
            zregvart zregvart
            Reporter:
            directhex Jo Shields
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved: