Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-2730

Minor fixes for UI permission checks in computer(slaves) section

    • Icon: Patch Patch
    • Resolution: Fixed
    • Icon: Minor Minor
    • _unsorted
    • None
    • Platform: All, OS: All

      Attached patch has the following changes:

      • Omit "Script Console" link on master node page for non-admins
      • Omit "toggleOffline" button on node pages for non-admins
      • For JNLP slave node when slave agent port is -1, remove extra error icon (it
        seems div class="error" already has an icon) and omit the link to configure page
        for non-admins
      • Remove extra / in "Build History" link URL in both master and slave node sidepanel

          [JENKINS-2730] Minor fixes for UI permission checks in computer(slaves) section

          Alan Harder added a comment -

          Created an attachment (id=470)
          Fix some permission checks for showing UI elements

          Alan Harder added a comment - Created an attachment (id=470) Fix some permission checks for showing UI elements

          Code changed in hudson
          User: : kohsuke
          Path:
          trunk/hudson/main/core/src/main/resources/hudson/model/Computer/index.jelly
          trunk/hudson/main/core/src/main/resources/hudson/model/Computer/sidepanel.jelly
          trunk/hudson/main/core/src/main/resources/hudson/slaves/JNLPLauncher/main.jelly
          trunk/hudson/main/core/src/main/resources/hudson/slaves/SlaveComputer/sidepanel.jelly
          trunk/www/changelog.html
          http://fisheye4.cenqua.com/changelog/hudson/?cs=13652
          Log:
          [FIXED JENKINS-2730] In 1.265.

          SCM/JIRA link daemon added a comment - Code changed in hudson User: : kohsuke Path: trunk/hudson/main/core/src/main/resources/hudson/model/Computer/index.jelly trunk/hudson/main/core/src/main/resources/hudson/model/Computer/sidepanel.jelly trunk/hudson/main/core/src/main/resources/hudson/slaves/JNLPLauncher/main.jelly trunk/hudson/main/core/src/main/resources/hudson/slaves/SlaveComputer/sidepanel.jelly trunk/www/changelog.html http://fisheye4.cenqua.com/changelog/hudson/?cs=13652 Log: [FIXED JENKINS-2730] In 1.265.

            Unassigned Unassigned
            mindless Alan Harder
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

              Created:
              Updated:
              Resolved: