[JENKINS-27387] NPE generating snippet for BindingStep

Type: Bug
Resolution: Fixed
Priority: Minor
Component/s: credentials-binding-plugin
Labels:
- pipeline
- stapler

Similar Issues:
Powered by SuggestiMate

Show

Not clear how to reproduce.

java.lang.RuntimeException: Failed to instantiate class org.jenkinsci.plugins.credentialsbinding.impl.BindingStep from {"stapler-class":"org.jenkinsci.plugins.credentialsbinding.impl.BindingStep","bindings":{"variable":"foo","credentialsId":["",""],"stapler-class":"org.jenkinsci.plugins.credentialsbinding.impl.StringBinding","kind":"org.jenkinsci.plugins.credentialsbinding.impl.StringBinding"}}
	at hudson.model.Descriptor.newInstance(Descriptor.java:577)
	at org.jenkinsci.plugins.workflow.cps.Snippetizer.doGenerateSnippet(Snippetizer.java:203)
	at ...
Caused by: java.lang.NullPointerException
	at org.kohsuke.stapler.RequestImpl$TypePair.convertJSON(RequestImpl.java:632)
	at org.kohsuke.stapler.RequestImpl.bindJSON(RequestImpl.java:400)
	at org.kohsuke.stapler.RequestImpl.instantiate(RequestImpl.java:684)
	at org.kohsuke.stapler.RequestImpl.access$100(RequestImpl.java:81)
	at org.kohsuke.stapler.RequestImpl$TypePair.convertJSON(RequestImpl.java:587)
	at org.kohsuke.stapler.RequestImpl$TypePair.convertJSON(RequestImpl.java:625)
	at org.kohsuke.stapler.RequestImpl.bindJSON(RequestImpl.java:400)
	at org.kohsuke.stapler.RequestImpl.instantiate(RequestImpl.java:684)
	at org.kohsuke.stapler.RequestImpl.access$100(RequestImpl.java:81)
	at org.kohsuke.stapler.RequestImpl$TypePair.convertJSON(RequestImpl.java:587)
	at org.kohsuke.stapler.RequestImpl.bindJSON(RequestImpl.java:400)
	at org.kohsuke.stapler.RequestImpl.bindJSON(RequestImpl.java:396)
	at hudson.model.Descriptor.newInstance(Descriptor.java:568)
	... 56 more

- - Sort By Name
  - Sort By Date
  - Ascending
  - Descending
  - Thumbnails
  - List
  - Download All

screenshot-1.png
89 kB
2016-01-26 16:31

is duplicated by

JENKINS-27960 Snippet Generator for 'Bind Credentials to variables' blows up

Resolved

JENKINS-28988 Snippet Generator fails for Secret File Binding

Resolved

JENKINS-31813 [withCredentials] NPE in snippet generator

Resolved

is related to

JENKINS-27397 Add credentials directly in control in Snippet Generator does not work

Resolved

JENKINS-37707 Saving SecretBuildWrapper for the first time fails due to duplicated credentialsId field unless git also installed

Resolved

JENKINS-35490 JENKINS-27387 broke binding to credentials parameter for Freestyle jobs

Closed

links to

PR 15

(1 is related to, 1 links to)

susie hernandez added a comment - 2016-01-21 18:09

Hi,

I'm getting the same error than you, see below. Any update in this fix?

java.lang.RuntimeException: Failed to instantiate class org.jenkinsci.plugins.credentialsbinding.impl.BindingStep from {"bindings":

{"usernameVariable":"svn_username","passwordVariable":"svn_password","credentialsId":["59a9e8cb-97e8-4fca-9c4a-06764843d039",""],"stapler-class":"org.jenkinsci.plugins.credentialsbinding.impl.UsernamePasswordMultiBinding","$class":"org.jenkinsci.plugins.credentialsbinding.impl.UsernamePasswordMultiBinding"}

,"stapler-class":"org.jenkinsci.plugins.credentialsbinding.impl.BindingStep","$class":"org.jenkinsci.plugins.credentialsbinding.impl.BindingStep"}

susie hernandez added a comment - 2016-01-21 18:09 Hi, I'm getting the same error than you, see below. Any update in this fix? java.lang.RuntimeException: Failed to instantiate class org.jenkinsci.plugins.credentialsbinding.impl.BindingStep from {"bindings": {"usernameVariable":"svn_username","passwordVariable":"svn_password","credentialsId":["59a9e8cb-97e8-4fca-9c4a-06764843d039",""],"stapler-class":"org.jenkinsci.plugins.credentialsbinding.impl.UsernamePasswordMultiBinding","$class":"org.jenkinsci.plugins.credentialsbinding.impl.UsernamePasswordMultiBinding"} ,"stapler-class":"org.jenkinsci.plugins.credentialsbinding.impl.BindingStep","$class":"org.jenkinsci.plugins.credentialsbinding.impl.BindingStep"}

Cyrille Le Clerc added a comment - 2016-01-26 16:33

I found a workaround when I was getting an NPE generating the snippet of a "Secret File" binding.
I first add a binding that does not break, a "Username and password (conjoined)" binding and then the "Secret File" binding that I need. And then I can generate the groovy snippet. I just have to remove the generated binding for the "Username and password (conjoined)" and I'm done.

Cyrille Le Clerc added a comment - 2016-01-26 16:33 I found a workaround when I was getting an NPE generating the snippet of a "Secret File" binding. I first add a binding that does not break, a "Username and password (conjoined)" binding and then the "Secret File" binding that I need. And then I can generate the groovy snippet. I just have to remove the generated binding for the "Username and password (conjoined)" and I'm done.

Jesse Glick added a comment - 2016-03-01 21:34

The problem is that credentialsId is being passed as an array rather than a single value, and this code is incompatible with databinding stephenconnolly. Somehow it works in SecretBuildWrapper in a freestyle project, not sure how.

Jesse Glick added a comment - 2016-03-01 21:34 The problem is that credentialsId is being passed as an array rather than a single value, and this code is incompatible with databinding stephenconnolly . Somehow it works in SecretBuildWrapper in a freestyle project, not sure how.

SCM/JIRA link daemon added a comment - 2016-03-04 02:35

Code changed in jenkins
User: Jesse Glick
Path:
src/main/resources/org/jenkinsci/plugins/credentialsbinding/MultiBinding/config.jelly
src/main/resources/org/jenkinsci/plugins/credentialsbinding/impl/BindingStep/config.jelly
src/main/resources/org/jenkinsci/plugins/credentialsbinding/impl/SecretBuildWrapper/config.jelly
http://jenkins-ci.org/commit/credentials-binding-plugin/1aa7d7ad6cbb6cf5ac6a4d246704de0f42af8456
Log:
[FIXED JENKINS-27387] Suppress expressionAllowed in BindingStep config; unnecessary and throws exceptions.

SCM/JIRA link daemon added a comment - 2016-03-04 02:35 Code changed in jenkins User: Jesse Glick Path: src/main/resources/org/jenkinsci/plugins/credentialsbinding/MultiBinding/config.jelly src/main/resources/org/jenkinsci/plugins/credentialsbinding/impl/BindingStep/config.jelly src/main/resources/org/jenkinsci/plugins/credentialsbinding/impl/SecretBuildWrapper/config.jelly http://jenkins-ci.org/commit/credentials-binding-plugin/1aa7d7ad6cbb6cf5ac6a4d246704de0f42af8456 Log: [FIXED JENKINS-27387] Suppress expressionAllowed in BindingStep config; unnecessary and throws exceptions.

SCM/JIRA link daemon added a comment - 2016-03-04 02:35

Code changed in jenkins
User: Jesse Glick
Path:
src/main/resources/org/jenkinsci/plugins/credentialsbinding/MultiBinding/config.jelly
src/main/resources/org/jenkinsci/plugins/credentialsbinding/impl/BindingStep/config.jelly
src/main/resources/org/jenkinsci/plugins/credentialsbinding/impl/SecretBuildWrapper/config.jelly
http://jenkins-ci.org/commit/credentials-binding-plugin/fbefd8d4646fa28d971a102c368f5bcfad5a7ac6
Log:
Merge pull request #15 from jglick/snippetizer-~~JENKINS-27387~~

~~JENKINS-27387~~ NPE from Snippetizer

Compare: https://github.com/jenkinsci/credentials-binding-plugin/compare/ed93648cf840...fbefd8d4646f

SCM/JIRA link daemon added a comment - 2016-03-04 02:35 Code changed in jenkins User: Jesse Glick Path: src/main/resources/org/jenkinsci/plugins/credentialsbinding/MultiBinding/config.jelly src/main/resources/org/jenkinsci/plugins/credentialsbinding/impl/BindingStep/config.jelly src/main/resources/org/jenkinsci/plugins/credentialsbinding/impl/SecretBuildWrapper/config.jelly http://jenkins-ci.org/commit/credentials-binding-plugin/fbefd8d4646fa28d971a102c368f5bcfad5a7ac6 Log: Merge pull request #15 from jglick/snippetizer- JENKINS-27387 JENKINS-27387 NPE from Snippetizer Compare: https://github.com/jenkinsci/credentials-binding-plugin/compare/ed93648cf840...fbefd8d4646f

Stephen Connolly added a comment - 2016-06-09 08:55

The fix for this has broken the use case of binding a credentials parameter in a freestyle job

Stephen Connolly added a comment - 2016-06-09 08:55 The fix for this has broken the use case of binding a credentials parameter in a freestyle job

Jenkins

Details

Description

Attachments

Attachments

Issue Links

Activity

Collapse comment: susie hernandez added a comment - 2016-01-21 18:09

Expand comment: susie hernandez added a comment - 2016-01-21 18:09

Collapse comment: Cyrille Le Clerc added a comment - 2016-01-26 16:33

Expand comment: Cyrille Le Clerc added a comment - 2016-01-26 16:33

Collapse comment: Jesse Glick added a comment - 2016-03-01 21:34

Expand comment: Jesse Glick added a comment - 2016-03-01 21:34

Collapse comment: SCM/JIRA link daemon added a comment - 2016-03-04 02:35

Expand comment: SCM/JIRA link daemon added a comment - 2016-03-04 02:35

Collapse comment: SCM/JIRA link daemon added a comment - 2016-03-04 02:35

Expand comment: SCM/JIRA link daemon added a comment - 2016-03-04 02:35

Collapse comment: Stephen Connolly added a comment - 2016-06-09 08:55

Expand comment: Stephen Connolly added a comment - 2016-06-09 08:55

People

Dates