Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-27704

Clean up build record storage

    XMLWordPrintable

Details

    Description

      1. program.dat should be deleted after the build completes.
      2. CpsFlowExecution.owner should be transient.
      3. .script and .loadedScripts could probably be nulled out at the end of the build. (no, would break Replay)
      4. SCMCheckout.changelogFile should be relative.
      5. .pollingBaseline should use null rather than SCMRevisionState.None.
      6. As perhaps should MultiSCMRevisionState.revisionStates.values(). If possible, MultiSCMRevisionState should not be stored at all.
      7. EnvActionImpl should be deleted at the end of the build if empty.

      Attachments

        Issue Links

          is blocking

          Bug - A problem which impairs or prevents the functions of the product. JENKINS-29571 Unreadable data after renaming a Workflow job

          • Critical - Crashes, loss of data, severe memory leak.
          • Resolved
          is related to

          Bug - A problem which impairs or prevents the functions of the product. JENKINS-26761 WorkflowJob.getSCMs throws NullPointerException from notifyCommit hooks after Jenkins Restart

          • Critical - Crashes, loss of data, severe memory leak.
          • Resolved

          Bug - A problem which impairs or prevents the functions of the product. JENKINS-27531 Stack overflow in WorkflowRun.reload after run ID migration

          • Blocker - Blocks development and/or testing work, production could not run.
          • Resolved

          Activity

            Ascending order - Click to sort in descending order
            jglick Jesse Glick created issue -
            jglick Jesse Glick made changes -
            Field Original Value New Value
            Link This issue is related to JENKINS-26761 [ JENKINS-26761 ]
            jglick Jesse Glick made changes -
            Link This issue is blocking JENKINS-29571 [ JENKINS-29571 ]
            jglick Jesse Glick made changes -
            Status Open [ 1 ] In Progress [ 3 ]
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Jesse Glick
            Path:
            aggregator/src/test/java/org/jenkinsci/plugins/workflow/WorkflowRunTest.java
            http://jenkins-ci.org/commit/workflow-plugin/9d087ca7fcb3e6f186d3f44f289bae8861dedad7
            Log:
            JENKINS-29571 reproduced in test and confirmed to depend on part of JENKINS-27704.

            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: aggregator/src/test/java/org/jenkinsci/plugins/workflow/WorkflowRunTest.java http://jenkins-ci.org/commit/workflow-plugin/9d087ca7fcb3e6f186d3f44f289bae8861dedad7 Log: JENKINS-29571 reproduced in test and confirmed to depend on part of JENKINS-27704 .
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Jesse Glick
            Path:
            CHANGES.md
            aggregator/src/test/java/org/jenkinsci/plugins/workflow/WorkflowRunTest.java
            api/src/main/java/org/jenkinsci/plugins/workflow/flow/FlowExecution.java
            cps/src/main/java/org/jenkinsci/plugins/workflow/cps/CpsFlowExecution.java
            cps/src/test/java/org/jenkinsci/plugins/workflow/cps/CpsFlowDefinition2Test.java
            job/src/main/java/org/jenkinsci/plugins/workflow/job/WorkflowRun.java
            http://jenkins-ci.org/commit/workflow-plugin/b7014e66b8b064794efea6c78f35160c5250cc2e
            Log:
            [FIXED JENKINS-29571] Make CpsFlowExecution.owner transient (JENKINS-27704) to avoid problems after renames/moves.

            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: CHANGES.md aggregator/src/test/java/org/jenkinsci/plugins/workflow/WorkflowRunTest.java api/src/main/java/org/jenkinsci/plugins/workflow/flow/FlowExecution.java cps/src/main/java/org/jenkinsci/plugins/workflow/cps/CpsFlowExecution.java cps/src/test/java/org/jenkinsci/plugins/workflow/cps/CpsFlowDefinition2Test.java job/src/main/java/org/jenkinsci/plugins/workflow/job/WorkflowRun.java http://jenkins-ci.org/commit/workflow-plugin/b7014e66b8b064794efea6c78f35160c5250cc2e Log: [FIXED JENKINS-29571] Make CpsFlowExecution.owner transient ( JENKINS-27704 ) to avoid problems after renames/moves.
            jglick Jesse Glick made changes -
            Link This issue is related to JENKINS-27531 [ JENKINS-27531 ]
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Jesse Glick
            Path:
            job/src/main/java/org/jenkinsci/plugins/workflow/job/WorkflowRun.java
            http://jenkins-ci.org/commit/workflow-plugin/fc3851f4df8881e24c079cf51f42b48ec9596ab9
            Log:
            The fix of JENKINS-27531 in #97 seems to be made simpler by the fix of JENKINS-29571 via JENKINS-27704 in #157.
            We only needed getId(WorkflowRun) because CpsFlowExecution.unmarshal was trying to use an Owner.

            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: job/src/main/java/org/jenkinsci/plugins/workflow/job/WorkflowRun.java http://jenkins-ci.org/commit/workflow-plugin/fc3851f4df8881e24c079cf51f42b48ec9596ab9 Log: The fix of JENKINS-27531 in #97 seems to be made simpler by the fix of JENKINS-29571 via JENKINS-27704 in #157. We only needed getId(WorkflowRun) because CpsFlowExecution.unmarshal was trying to use an Owner.
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Jesse Glick
            Path:
            api/src/main/java/org/jenkinsci/plugins/workflow/flow/FlowExecution.java
            http://jenkins-ci.org/commit/workflow-api-plugin/e26d0b7daa2cccae76ca7494e8fe35a8b31604dd
            Log:
            [FIXED JENKINS-29571] Make CpsFlowExecution.owner transient (JENKINS-27704) to avoid problems after renames/moves.
            Originally-Committed-As: b7014e66b8b064794efea6c78f35160c5250cc2e

            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: api/src/main/java/org/jenkinsci/plugins/workflow/flow/FlowExecution.java http://jenkins-ci.org/commit/workflow-api-plugin/e26d0b7daa2cccae76ca7494e8fe35a8b31604dd Log: [FIXED JENKINS-29571] Make CpsFlowExecution.owner transient ( JENKINS-27704 ) to avoid problems after renames/moves. Originally-Committed-As: b7014e66b8b064794efea6c78f35160c5250cc2e
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Jesse Glick
            Path:
            cps/src/main/java/org/jenkinsci/plugins/workflow/cps/CpsFlowExecution.java
            cps/src/test/java/org/jenkinsci/plugins/workflow/cps/CpsFlowDefinition2Test.java
            http://jenkins-ci.org/commit/workflow-cps-plugin/e4d1b6291b92f6c82f6cbd652b5c62067aeb7119
            Log:
            [FIXED JENKINS-29571] Make CpsFlowExecution.owner transient (JENKINS-27704) to avoid problems after renames/moves.
            Originally-Committed-As: b7014e66b8b064794efea6c78f35160c5250cc2e

            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: cps/src/main/java/org/jenkinsci/plugins/workflow/cps/CpsFlowExecution.java cps/src/test/java/org/jenkinsci/plugins/workflow/cps/CpsFlowDefinition2Test.java http://jenkins-ci.org/commit/workflow-cps-plugin/e4d1b6291b92f6c82f6cbd652b5c62067aeb7119 Log: [FIXED JENKINS-29571] Make CpsFlowExecution.owner transient ( JENKINS-27704 ) to avoid problems after renames/moves. Originally-Committed-As: b7014e66b8b064794efea6c78f35160c5250cc2e
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Jesse Glick
            Path:
            aggregator/src/test/java/org/jenkinsci/plugins/workflow/WorkflowRunTest.java
            http://jenkins-ci.org/commit/workflow-job-plugin/305082c4530f6253878a8a3700d4881e8da6627d
            Log:
            JENKINS-29571 reproduced in test and confirmed to depend on part of JENKINS-27704.
            Originally-Committed-As: 9d087ca7fcb3e6f186d3f44f289bae8861dedad7

            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: aggregator/src/test/java/org/jenkinsci/plugins/workflow/WorkflowRunTest.java http://jenkins-ci.org/commit/workflow-job-plugin/305082c4530f6253878a8a3700d4881e8da6627d Log: JENKINS-29571 reproduced in test and confirmed to depend on part of JENKINS-27704 . Originally-Committed-As: 9d087ca7fcb3e6f186d3f44f289bae8861dedad7
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Jesse Glick
            Path:
            aggregator/src/test/java/org/jenkinsci/plugins/workflow/WorkflowRunTest.java
            job/src/main/java/org/jenkinsci/plugins/workflow/job/WorkflowRun.java
            http://jenkins-ci.org/commit/workflow-job-plugin/5170bb152334a56987f03711ef3896d64fb98bc0
            Log:
            [FIXED JENKINS-29571] Make CpsFlowExecution.owner transient (JENKINS-27704) to avoid problems after renames/moves.
            Originally-Committed-As: b7014e66b8b064794efea6c78f35160c5250cc2e

            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: aggregator/src/test/java/org/jenkinsci/plugins/workflow/WorkflowRunTest.java job/src/main/java/org/jenkinsci/plugins/workflow/job/WorkflowRun.java http://jenkins-ci.org/commit/workflow-job-plugin/5170bb152334a56987f03711ef3896d64fb98bc0 Log: [FIXED JENKINS-29571] Make CpsFlowExecution.owner transient ( JENKINS-27704 ) to avoid problems after renames/moves. Originally-Committed-As: b7014e66b8b064794efea6c78f35160c5250cc2e
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Jesse Glick
            Path:
            job/src/main/java/org/jenkinsci/plugins/workflow/job/WorkflowRun.java
            http://jenkins-ci.org/commit/workflow-job-plugin/c034f77059966d1097e16a2bcc1dad2ddbe41994
            Log:
            The fix of JENKINS-27531 in #97 seems to be made simpler by the fix of JENKINS-29571 via JENKINS-27704 in #157.
            We only needed getId(WorkflowRun) because CpsFlowExecution.unmarshal was trying to use an Owner.
            Originally-Committed-As: fc3851f4df8881e24c079cf51f42b48ec9596ab9

            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: job/src/main/java/org/jenkinsci/plugins/workflow/job/WorkflowRun.java http://jenkins-ci.org/commit/workflow-job-plugin/c034f77059966d1097e16a2bcc1dad2ddbe41994 Log: The fix of JENKINS-27531 in #97 seems to be made simpler by the fix of JENKINS-29571 via JENKINS-27704 in #157. We only needed getId(WorkflowRun) because CpsFlowExecution.unmarshal was trying to use an Owner. Originally-Committed-As: fc3851f4df8881e24c079cf51f42b48ec9596ab9
            rtyler R. Tyler Croy made changes -
            Workflow JNJira [ 162017 ] JNJira + In-Review [ 185586 ]
            abayer Andrew Bayer made changes -
            Component/s pipeline-general [ 21692 ]
            abayer Andrew Bayer made changes -
            Component/s workflow-plugin [ 18820 ]
            jglick Jesse Glick made changes -
            Component/s workflow-cps-plugin [ 21713 ]
            Component/s workflow-scm-step-plugin [ 21717 ]
            Component/s pipeline [ 21692 ]
            jglick Jesse Glick made changes -
            Description # {{program.dat}} should be deleted after the build completes.
            # {{CpsFlowExecution.owner}} should be {{transient}}.
            # {{.script}} and {{.loadedScripts}} could probably be nulled out at the end of the build.
            # {{SCMCheckout.changelogFile}} should be relative.
            # {{.pollingBaseline}} should use {{null}} rather than {{SCMRevisionState.None}}.
            # As perhaps should {{MultiSCMRevisionState.revisionStates.values()}}. If possible, {{MultiSCMRevisionState}} should not be stored at all.
            # {{EnvActionImpl}} should be deleted at the end of the build if empty.             		# {{program.dat}} should be deleted after the build completes.
            # -{{CpsFlowExecution.owner}} should be {{transient}}.-
            # -{{.script}} and {{.loadedScripts}} could probably be nulled out at the end of the build.- _(no, would break *Replay*)_
            # {{SCMCheckout.changelogFile}} should be relative.
            # {{.pollingBaseline}} should use {{null}} rather than {{SCMRevisionState.None}}.
            # As perhaps should {{MultiSCMRevisionState.revisionStates.values()}}. If possible, {{MultiSCMRevisionState}} should not be stored at all.
            # {{EnvActionImpl}} should be deleted at the end of the build if empty.
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Jesse Glick
            Path:
            src/main/java/org/jenkinsci/plugins/workflow/job/WorkflowRun.java
            http://jenkins-ci.org/commit/workflow-job-plugin/86e4b0633daca29e6f774e32e82bd4108797b681
            Log:
            Noting JENKINS-27704.

            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: src/main/java/org/jenkinsci/plugins/workflow/job/WorkflowRun.java http://jenkins-ci.org/commit/workflow-job-plugin/86e4b0633daca29e6f774e32e82bd4108797b681 Log: Noting JENKINS-27704 .
            abayer Andrew Bayer made changes -
            Issue Type Bug [ 1 ] Improvement [ 4 ]

            People

              jglick Jesse Glick
              jglick Jesse Glick
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated: