Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-28062

Channel listener onClose propagated exceptions

    XMLWordPrintable

Details

    Description

      Channel listeners onClose method would propagate exceptions causing extra noise when failing to close the channel.

      Attachments

        Activity

          Code changed in jenkins
          User: Stephen Connolly
          Path:
          changelog.html
          http://jenkins-ci.org/commit/jenkins/6a138b59b4eee42f65d620730802d3a97a0f6c4a
          Log:
          Noting JENKINS-28062

          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Stephen Connolly Path: changelog.html http://jenkins-ci.org/commit/jenkins/6a138b59b4eee42f65d620730802d3a97a0f6c4a Log: Noting JENKINS-28062
          dogfood dogfood added a comment -

          Integrated in jenkins_main_trunk #4106
          [FIXED JENKINS-28062] A Launcher.afterDisconnect() method that propagates an exception is a sign of a bad Launcher not a problem closing the channel. (Revision d760216d1e3a927b971edf27c7af317a5de71e20)
          Noting JENKINS-28062 (Revision 6a138b59b4eee42f65d620730802d3a97a0f6c4a)

          Result = SUCCESS
          stephen connolly : d760216d1e3a927b971edf27c7af317a5de71e20
          Files :

          • core/src/main/java/hudson/slaves/SlaveComputer.java

          stephen connolly : 6a138b59b4eee42f65d620730802d3a97a0f6c4a
          Files :

          • changelog.html
          dogfood dogfood added a comment - Integrated in jenkins_main_trunk #4106 [FIXED JENKINS-28062] A Launcher.afterDisconnect() method that propagates an exception is a sign of a bad Launcher not a problem closing the channel. (Revision d760216d1e3a927b971edf27c7af317a5de71e20) Noting JENKINS-28062 (Revision 6a138b59b4eee42f65d620730802d3a97a0f6c4a) Result = SUCCESS stephen connolly : d760216d1e3a927b971edf27c7af317a5de71e20 Files : core/src/main/java/hudson/slaves/SlaveComputer.java stephen connolly : 6a138b59b4eee42f65d620730802d3a97a0f6c4a Files : changelog.html

          Code changed in jenkins
          User: Stephen Connolly
          Path:
          core/src/main/java/hudson/slaves/SlaveComputer.java
          http://jenkins-ci.org/commit/jenkins/d42e8465fc2829bc7a926fe8d52d3bdfaabd857e
          Log:
          [FIXED JENKINS-28062] A Launcher.afterDisconnect() method that propagates an exception is a sign of a bad Launcher not a problem closing the channel.

          (cherry picked from commit d760216d1e3a927b971edf27c7af317a5de71e20)

          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Stephen Connolly Path: core/src/main/java/hudson/slaves/SlaveComputer.java http://jenkins-ci.org/commit/jenkins/d42e8465fc2829bc7a926fe8d52d3bdfaabd857e Log: [FIXED JENKINS-28062] A Launcher.afterDisconnect() method that propagates an exception is a sign of a bad Launcher not a problem closing the channel. (cherry picked from commit d760216d1e3a927b971edf27c7af317a5de71e20)

          I do not think this can be 1.609.1-fixed, as it also requires remoting pull request 42 which hasn't been released yet.

          schristou Steven Christou added a comment - I do not think this can be 1.609.1-fixed, as it also requires remoting pull request 42 which hasn't been released yet.
          dogfood dogfood added a comment -

          Integrated in jenkins_main_trunk #4292
          [FIXED JENKINS-28062] A Launcher.afterDisconnect() method that propagates an exception is a sign of a bad Launcher not a problem closing the channel. (Revision d42e8465fc2829bc7a926fe8d52d3bdfaabd857e)

          Result = UNSTABLE
          ogondza : d42e8465fc2829bc7a926fe8d52d3bdfaabd857e
          Files :

          • core/src/main/java/hudson/slaves/SlaveComputer.java
          dogfood dogfood added a comment - Integrated in jenkins_main_trunk #4292 [FIXED JENKINS-28062] A Launcher.afterDisconnect() method that propagates an exception is a sign of a bad Launcher not a problem closing the channel. (Revision d42e8465fc2829bc7a926fe8d52d3bdfaabd857e) Result = UNSTABLE ogondza : d42e8465fc2829bc7a926fe8d52d3bdfaabd857e Files : core/src/main/java/hudson/slaves/SlaveComputer.java

          People

            Unassigned Unassigned
            schristou Steven Christou
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: