Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-28148

Fail to create a swarm when using a toolLocations with whitespaces.

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Minor Minor
    • swarm-plugin
    • Jenkins : 1.596.2, swarm-plugin : 1.22, Windows7

      It is impossible to start correctly a swarm when specifying a toolLocations argument with whitespaces (ie. jdk:C:/Program Files/Java/...).

      The problem seems to come from :
      swarm-plugin/client/src/main/java/hudson/plugins/swarm/SwarmClient.java, line 308.
      swarm-plugin/plugin/src/main/java/hudson/plugins/swarm/PluginImpl.java, line 121.

      which use " " as a separator for tools. As a consequence, the part after the whitespace is considered to be another tool (which is just the rest of the previous one), and throw RuntimeException because it is not recognized.

      IMO, the solution would either be :

      • change the splitting character (ie. tool1:location@tool2:location). Quick win.
      • use a more complex structure for data sent from client to plugin than just raw text and simple separators.

          [JENKINS-28148] Fail to create a swarm when using a toolLocations with whitespaces.

          Paul Popineau added a comment -

          I have posted this PR#28. I would be glad to have insights on it.

          Paul Popineau added a comment - I have posted this PR#28 . I would be glad to have insights on it.

          Oleg Nenashev added a comment -

          KK does not maintain this plugin anymore. Moving to unassigned to set the expectation

          Oleg Nenashev added a comment - KK does not maintain this plugin anymore. Moving to unassigned to set the expectation

            Unassigned Unassigned
            polopi Paul Popineau
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated:
              Resolved: