Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-28339

Allow skip-vote to also skip vote for "Started"

    XMLWordPrintable

    Details

    • Similar Issues:

      Description

      Gerrit Trigger's skip-vote feature currently allows you to skip-vote for:

      • Successful
      • Failed
      • Unstable
      • Not Built

      We need to add "Started" to this list as well because a job that needs to skip all votes will still vote on a "Started" trigger.

      In our use case this "Started" trigger defaults to 0 so unsets any existing verify state that was previously voted on.

        Attachments

          Activity

          Hide
          zaro0508 Khai Do added a comment -

          I'm using gerrit trigger 2.22.0 and I don't this behavior at all. The gerrit-trigger only seems to send feedback (votes & comments) after jobs are completed. Although I could be missing the correct configuration to reproduce this use case. Might be good if you could provide the repro steps for this issue.

          On a related note, the pull request to add a silent level[1] parameter should allow you to turn off voting feedback completely.

          [1] https://github.com/jenkinsci/gerrit-trigger-plugin/pull/298

          Show
          zaro0508 Khai Do added a comment - I'm using gerrit trigger 2.22.0 and I don't this behavior at all. The gerrit-trigger only seems to send feedback (votes & comments) after jobs are completed. Although I could be missing the correct configuration to reproduce this use case. Might be good if you could provide the repro steps for this issue. On a related note, the pull request to add a silent level [1] parameter should allow you to turn off voting feedback completely. [1] https://github.com/jenkinsci/gerrit-trigger-plugin/pull/298
          Hide
          zxiiro Thanh Ha added a comment -

          Jenkins will remove a vote on started. See:

          I was able to reproduced with gerrit-trigger 2.22.0. Some steps to reproduce on a fresh Jenkins system:

          1. Install Gerrit Trigger plugin
          2. Setup Gerrit Trigger plugin server configuration
          3. Setup a job to vote Verified+1 when job passes
          4. Run job
          5. Reconfigure job to skip vote for all available categories: Job Configuration > Gerrit Event > Advanced > Skip Vote on Successful, Failed, Unstable, Not Built
          6. Rerun job
          7. Gerrit Trigger removes the Verified+1 vote when job starts.

          Show
          zxiiro Thanh Ha added a comment - Jenkins will remove a vote on started. See: I was able to reproduced with gerrit-trigger 2.22.0. Some steps to reproduce on a fresh Jenkins system: 1. Install Gerrit Trigger plugin 2. Setup Gerrit Trigger plugin server configuration 3. Setup a job to vote Verified+1 when job passes 4. Run job 5. Reconfigure job to skip vote for all available categories: Job Configuration > Gerrit Event > Advanced > Skip Vote on Successful, Failed, Unstable, Not Built 6. Rerun job 7. Gerrit Trigger removes the Verified+1 vote when job starts.
          Hide
          tykeal Andrew Grimberg added a comment -

          Khai Do Yes the silent start is an option but our customers like to get feedback that the job has started. Which means that with the current options Jenkins will reset its votes if a job is retriggered.

          I'll also note that as of Gerrit 2.13 a retriggering on an already merged change will cause any, and all messaging that has votes in it to fail and not even post the message if the votes don't match what Gerrit already has for the voting user. This makes it even more difficult for merge based jobs to work correctly without doing an override of the vote values in the job to be what they would "normally" be.

          Show
          tykeal Andrew Grimberg added a comment - Khai Do Yes the silent start is an option but our customers like to get feedback that the job has started. Which means that with the current options Jenkins will reset its votes if a job is retriggered. I'll also note that as of Gerrit 2.13 a retriggering on an already merged change will cause any, and all messaging that has votes in it to fail and not even post the message if the votes don't match what Gerrit already has for the voting user. This makes it even more difficult for merge based jobs to work correctly without doing an override of the vote values in the job to be what they would "normally" be.

            People

            Assignee:
            rsandell rsandell
            Reporter:
            zxiiro Thanh Ha
            Votes:
            3 Vote for this issue
            Watchers:
            4 Start watching this issue

              Dates

              Created:
              Updated: