Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-28444

Invalid cc:, bcc: recipients handling when mail address contains a dot

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Trivial Trivial
    • email-ext-plugin
    • Fedora 21 x86_64,
      Jenkins from official repos

      I have a strange behaviour with e-mail addresses having dot. Presumably Ext plugin has a typo in inet-address parsing in ListProvider.

      Case 1:
      Project Recipient List: adonai.elohim, cc:master.maker, bcc:lich.king
      In this case Ext plugin only sends E-mail to adonai.elohim$suffix
      CC and BCC are ignored

      Case 2:
      Project Recipient List: adonai.elohim, cc:"master.maker", bcc:lich.king
      In this case Ext plugin sends E-mail to adonai.elohim$suffix
      and CC's to "master.maker"$suffix,
      BCC is ignored
      (btw I see these quotes around names when reading with mail-client)

      Case 3:
      Project Recipient List: adonai.elohim, cc:"master.maker", bcc:"lich.king"
      In this case Ext plugin sends E-mail to adonai.elohim$suffix
      and CC's to "master.maker"$suffix and "lich.king"$suffix,
      no BCC is sent, all recipients are visible

          [JENKINS-28444] Invalid cc:, bcc: recipients handling when mail address contains a dot

          Alex Earl added a comment -

          Everything looks ok in the log. Which users from the list didn't receive the email?

          Alex Earl added a comment - Everything looks ok in the log. Which users from the list didn't receive the email?

          Adonai Elohim added a comment -

          At least BCC became CC

          I'll attach another log without quotes shortly.

          Adonai Elohim added a comment - At least BCC became CC I'll attach another log without quotes shortly.

          Alex Earl added a comment -

          Does your mail server support bcc? I sent to addresses with dots in cc and bcc to gmail with no problems. I even put quotes around some addresses like you have.

          Alex Earl added a comment - Does your mail server support bcc? I sent to addresses with dots in cc and bcc to gmail with no problems. I even put quotes around some addresses like you have.

          Adonai Elohim added a comment -

          Just sent mail to myself and BCC'd to colleague through Outlook
          He got it and does not see himself as a recipient

          Anyways, I see Ext plugin adds it as explicit RCPT, this should not happen if the person is BCC'd, does it?

          Adonai Elohim added a comment - Just sent mail to myself and BCC'd to colleague through Outlook He got it and does not see himself as a recipient Anyways, I see Ext plugin adds it as explicit RCPT, this should not happen if the person is BCC'd, does it?

          Alex Earl added a comment -

          I meant DavMail, not Outlook. See "How SMTP actually works" on http://stackoverflow.com/questions/2750211/sending-bcc-emails-using-a-smtp-server. Based on that, you would still see the BCC person as a RCPT entry with the mailserver.

          Alex Earl added a comment - I meant DavMail, not Outlook. See "How SMTP actually works" on http://stackoverflow.com/questions/2750211/sending-bcc-emails-using-a-smtp-server . Based on that, you would still see the BCC person as a RCPT entry with the mailserver.

          Adonai Elohim added a comment -

          Ok, I'll go take a look at DavMail source. Don't close this issue, I'll update it with non-quoted version soon

          Adonai Elohim added a comment - Ok, I'll go take a look at DavMail source. Don't close this issue, I'll update it with non-quoted version soon

          Alex Earl added a comment -

          I won't close until resolved.

          Alex Earl added a comment - I won't close until resolved.

          Alex Earl added a comment -

          This actually has nothing to do with dots in the email address. It has to do with a bug I introduced that parsed the cc and bcc stuff incorrectly. I was not seeing it on the code I was using because I had already fixed it. I should have run earlier with the released version of the code. Should have a fix in the next version.

          Alex Earl added a comment - This actually has nothing to do with dots in the email address. It has to do with a bug I introduced that parsed the cc and bcc stuff incorrectly. I was not seeing it on the code I was using because I had already fixed it. I should have run earlier with the released version of the code. Should have a fix in the next version.

          Code changed in jenkins
          User: Alex Earl
          Path:
          src/main/java/hudson/plugins/emailext/EmailRecipientUtils.java
          http://jenkins-ci.org/commit/email-ext-plugin/cea631c421b7964ba710d21c3a4131d7a881f739
          Log:
          Fix JENKINS-28444

          Fix incorrect check for > 0 size on the bcc an cc lists.

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Alex Earl Path: src/main/java/hudson/plugins/emailext/EmailRecipientUtils.java http://jenkins-ci.org/commit/email-ext-plugin/cea631c421b7964ba710d21c3a4131d7a881f739 Log: Fix JENKINS-28444 Fix incorrect check for > 0 size on the bcc an cc lists.

          Adonai Elohim added a comment -

          Oh!
          Very sorry for not providing logs.
          Suddenly got very sick.

          Thanks for sorting this out anyways!

          Adonai Elohim added a comment - Oh! Very sorry for not providing logs. Suddenly got very sick. Thanks for sorting this out anyways!

            slide_o_mix Alex Earl
            adonai Adonai Elohim
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

              Created:
              Updated:
              Resolved: