-
Improvement
-
Resolution: Fixed
-
Minor
By default, when using the docker configuration option, the approach used by mesos to run a docker based jenkins slave is by passing the jenkins slave commands as arguments to
the standard shell e.g. /bin/sh -c java -jar ...
There may be cases (for example when wanting to run a docker-in-docker aka
dind image) where a custom shell command is desired instead so that more than just the jenkins slave command can be executed. I.e. start docker then run the jenkins slave command.
This has been highlighted in a google group chat as well. See https://groups.google.com/forum/#!topic/jenkins-mesos/JgFCmqOO7Fg
It would be nice to be able to override this behaviour to make it possible.
[JENKINS-28641] Allow for configuration of a custom command shell when using docker
Code changed in jenkins
User: Nicki Watt
Path:
src/main/java/org/jenkinsci/plugins/mesos/JenkinsScheduler.java
src/main/java/org/jenkinsci/plugins/mesos/MesosCloud.java
src/main/java/org/jenkinsci/plugins/mesos/MesosSlaveInfo.java
src/main/resources/org/jenkinsci/plugins/mesos/MesosCloud/config.jelly
src/main/resources/org/jenkinsci/plugins/mesos/MesosCloud/help-customDockerCommandShell.html
src/main/resources/org/jenkinsci/plugins/mesos/MesosCloud/help-useCustomDockerCommandShell.html
src/test/java/org/jenkinsci/plugins/mesos/JenkinsSchedulerTest.java
http://jenkins-ci.org/commit/mesos-plugin/9dc06a091b63711e2660686535d0ba4d179dce92
Log:
JENKINS-28641 - Allow for configuration of a custom command shell when using docker
Code changed in jenkins
User: Manivannan Selvaraj
Path:
src/main/java/org/jenkinsci/plugins/mesos/JenkinsScheduler.java
src/main/java/org/jenkinsci/plugins/mesos/MesosCloud.java
src/main/java/org/jenkinsci/plugins/mesos/MesosSlaveInfo.java
src/main/resources/org/jenkinsci/plugins/mesos/MesosCloud/config.jelly
src/main/resources/org/jenkinsci/plugins/mesos/MesosCloud/help-customDockerCommandShell.html
src/main/resources/org/jenkinsci/plugins/mesos/MesosCloud/help-useCustomDockerCommandShell.html
src/test/java/org/jenkinsci/plugins/mesos/JenkinsSchedulerTest.java
http://jenkins-ci.org/commit/mesos-plugin/0c4a9523e8ba528924c8072b4f68921418e17e00
Log:
Merge pull request #141 from nickithewatt/dind-enablement
JENKINS-28641 - Allow for configuration of a custom command shell when using docker
Compare: https://github.com/jenkinsci/mesos-plugin/compare/8eb6d1858107...0c4a9523e8ba
Here is a PR which adds this functionality:
https://github.com/jenkinsci/mesos-plugin/pull/112