Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-28657

Support creation of named fingerprints in DockerFingerprints

    XMLWordPrintable

    Details

    • Similar Issues:

      Description

      Currently docker-commons assigns <docker-image> filename to any created fingerprint. It would be better to display image IDs or names in the filename.

      APIs should be extended to support such feature

        Attachments

          Issue Links

            Activity

            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Oleg Nenashev
            Path:
            src/main/java/org/jenkinsci/plugins/docker/commons/fingerprint/DockerFingerprints.java
            http://jenkins-ci.org/commit/docker-commons-plugin/39b57e715d83ffeb3f8bfe0378538f45e44d58b2
            Log:
            [FIXED JENKINS-28657] - Support the creation of named fingerprints

            The fix also changes the default behavior for missing names. Instead of non-informative "<docker-image>" we will be using "Docker image $(64-char id)" (which may be too long BTW)

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Oleg Nenashev Path: src/main/java/org/jenkinsci/plugins/docker/commons/fingerprint/DockerFingerprints.java http://jenkins-ci.org/commit/docker-commons-plugin/39b57e715d83ffeb3f8bfe0378538f45e44d58b2 Log: [FIXED JENKINS-28657] - Support the creation of named fingerprints The fix also changes the default behavior for missing names. Instead of non-informative "<docker-image>" we will be using "Docker image $(64-char id)" (which may be too long BTW)
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Oleg Nenashev
            Path:
            src/main/java/org/jenkinsci/plugins/docker/commons/fingerprint/DockerFingerprints.java
            http://jenkins-ci.org/commit/docker-commons-plugin/ae64ac19f227739fc79682cb63f7cebb3510aadf
            Log:
            Merge pull request #37 from oleg-nenashev/named-fingerprints

            [FIXED JENKINS-28657] - Support the creation of named fingerprints

            Compare: https://github.com/jenkinsci/docker-commons-plugin/compare/e09ead383aa6...ae64ac19f227

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Oleg Nenashev Path: src/main/java/org/jenkinsci/plugins/docker/commons/fingerprint/DockerFingerprints.java http://jenkins-ci.org/commit/docker-commons-plugin/ae64ac19f227739fc79682cb63f7cebb3510aadf Log: Merge pull request #37 from oleg-nenashev/named-fingerprints [FIXED JENKINS-28657] - Support the creation of named fingerprints Compare: https://github.com/jenkinsci/docker-commons-plugin/compare/e09ead383aa6...ae64ac19f227

              People

              Assignee:
              oleg_nenashev Oleg Nenashev
              Reporter:
              oleg_nenashev Oleg Nenashev
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved: