SSHAgentBuildWrapper as SimpleBuildWrapper

      Making SSHAgentBuildWrapper be a SimpleBuildWrapper would allow it to be used from Workflow builds. The tricky part is that AgentServer cannot be made Serializable. So perhaps a proxy needs to be stored which could call RemoteAgentFactory.start after a Jenkins restart.

          [JENKINS-28689] Make SSH Agent Plugin compatible with Workflow

          Code changed in jenkins
          User: recena
          Path:
          src/main/java/com/cloudbees/jenkins/plugins/sshagent/SSHAgentStep.java
          src/main/java/com/cloudbees/jenkins/plugins/sshagent/SSHAgentStepExecution.java
          src/test/java/com/cloudbees/jenkins/plugins/sshagent/SSHAgentBuildWrapperTest.java
          http://jenkins-ci.org/commit/ssh-agent-plugin/7b41d49c21fa0e32388fc65eb25d0daa900ff37f
          Log:
          JENKINS-28689 Fixed some reviews suggested

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: recena Path: src/main/java/com/cloudbees/jenkins/plugins/sshagent/SSHAgentStep.java src/main/java/com/cloudbees/jenkins/plugins/sshagent/SSHAgentStepExecution.java src/test/java/com/cloudbees/jenkins/plugins/sshagent/SSHAgentBuildWrapperTest.java http://jenkins-ci.org/commit/ssh-agent-plugin/7b41d49c21fa0e32388fc65eb25d0daa900ff37f Log: JENKINS-28689 Fixed some reviews suggested

          Code changed in jenkins
          User: Manuel Recena
          Path:
          src/main/java/com/cloudbees/jenkins/plugins/sshagent/SSHAgentStep.java
          src/main/java/com/cloudbees/jenkins/plugins/sshagent/SSHAgentStepExecution.java
          src/test/java/com/cloudbees/jenkins/plugins/sshagent/SSHAgentStepWorkflowTest.java
          http://jenkins-ci.org/commit/ssh-agent-plugin/88a22245645d2546e1e75f6f737290df97fed915
          Log:
          JENKINS-28689 Fixed some reviews suggested

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Manuel Recena Path: src/main/java/com/cloudbees/jenkins/plugins/sshagent/SSHAgentStep.java src/main/java/com/cloudbees/jenkins/plugins/sshagent/SSHAgentStepExecution.java src/test/java/com/cloudbees/jenkins/plugins/sshagent/SSHAgentStepWorkflowTest.java http://jenkins-ci.org/commit/ssh-agent-plugin/88a22245645d2546e1e75f6f737290df97fed915 Log: JENKINS-28689 Fixed some reviews suggested

          Code changed in jenkins
          User: recena
          Path:
          src/main/java/com/cloudbees/jenkins/plugins/sshagent/SSHAgentStepExecution.java
          http://jenkins-ci.org/commit/ssh-agent-plugin/7ce22bfa8fc8cd9ceb72ad9070b8e8a9cd4351cc
          Log:
          JENKINS-28689 cleanUp method has been moved from Callback to SSHAgentStepExecution

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: recena Path: src/main/java/com/cloudbees/jenkins/plugins/sshagent/SSHAgentStepExecution.java http://jenkins-ci.org/commit/ssh-agent-plugin/7ce22bfa8fc8cd9ceb72ad9070b8e8a9cd4351cc Log: JENKINS-28689 cleanUp method has been moved from Callback to SSHAgentStepExecution

          Code changed in jenkins
          User: recena
          Path:
          src/main/java/com/cloudbees/jenkins/plugins/sshagent/SSHAgentStep.java
          src/main/resources/com/cloudbees/jenkins/plugins/sshagent/SSHAgentBuildWrapper/config.jelly
          src/main/resources/com/cloudbees/jenkins/plugins/sshagent/SSHAgentStep/config.jelly
          src/main/resources/com/cloudbees/jenkins/plugins/sshagent/SSHAgentStep/help.html
          http://jenkins-ci.org/commit/ssh-agent-plugin/bc0dd37381e1316f276401bee34464bd78e90426
          Log:
          JENKINS-28689 Snippet Generator is working

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: recena Path: src/main/java/com/cloudbees/jenkins/plugins/sshagent/SSHAgentStep.java src/main/resources/com/cloudbees/jenkins/plugins/sshagent/SSHAgentBuildWrapper/config.jelly src/main/resources/com/cloudbees/jenkins/plugins/sshagent/SSHAgentStep/config.jelly src/main/resources/com/cloudbees/jenkins/plugins/sshagent/SSHAgentStep/help.html http://jenkins-ci.org/commit/ssh-agent-plugin/bc0dd37381e1316f276401bee34464bd78e90426 Log: JENKINS-28689 Snippet Generator is working

          Code changed in jenkins
          User: Manuel Recena
          Path:
          src/main/resources/com/cloudbees/jenkins/plugins/sshagent/SSHAgentStep/help.html
          http://jenkins-ci.org/commit/ssh-agent-plugin/ee6ce32149a3f71651bf29c230efcad3d5de7303
          Log:
          JENKINS-28689 help.html has been reviewed

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Manuel Recena Path: src/main/resources/com/cloudbees/jenkins/plugins/sshagent/SSHAgentStep/help.html http://jenkins-ci.org/commit/ssh-agent-plugin/ee6ce32149a3f71651bf29c230efcad3d5de7303 Log: JENKINS-28689 help.html has been reviewed

          Code changed in jenkins
          User: Manuel Recena
          Path:
          src/main/java/com/cloudbees/jenkins/plugins/sshagent/jna/JNRRemoteAgentStarter.java
          src/main/java/com/cloudbees/jenkins/plugins/sshagent/mina/MinaRemoteAgentFactory.java
          src/main/java/com/cloudbees/jenkins/plugins/sshagent/mina/MinaRemoteAgentStarter.java
          http://jenkins-ci.org/commit/ssh-agent-plugin/0cefdd3c52ae8d9c8b0f0e1e4646b7066b8e2085
          Log:
          JENKINS-28689 Serial Version UIDs has been reviewed following the Stephen's recommendations

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Manuel Recena Path: src/main/java/com/cloudbees/jenkins/plugins/sshagent/jna/JNRRemoteAgentStarter.java src/main/java/com/cloudbees/jenkins/plugins/sshagent/mina/MinaRemoteAgentFactory.java src/main/java/com/cloudbees/jenkins/plugins/sshagent/mina/MinaRemoteAgentStarter.java http://jenkins-ci.org/commit/ssh-agent-plugin/0cefdd3c52ae8d9c8b0f0e1e4646b7066b8e2085 Log: JENKINS-28689 Serial Version UIDs has been reviewed following the Stephen's recommendations

          Code changed in jenkins
          User: Manuel Recena
          Path:
          src/main/java/com/cloudbees/jenkins/plugins/sshagent/jna/JNRRemoteAgentStarter.java
          src/main/java/com/cloudbees/jenkins/plugins/sshagent/mina/MinaRemoteAgentFactory.java
          src/main/java/com/cloudbees/jenkins/plugins/sshagent/mina/MinaRemoteAgentStarter.java
          http://jenkins-ci.org/commit/ssh-agent-plugin/050eebf746e2f8b33a5430d234613d13439dd8d7
          Log:
          JENKINS-28689 Included javadocs to explain that these SerialVersionUID was generated from 1.7

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Manuel Recena Path: src/main/java/com/cloudbees/jenkins/plugins/sshagent/jna/JNRRemoteAgentStarter.java src/main/java/com/cloudbees/jenkins/plugins/sshagent/mina/MinaRemoteAgentFactory.java src/main/java/com/cloudbees/jenkins/plugins/sshagent/mina/MinaRemoteAgentStarter.java http://jenkins-ci.org/commit/ssh-agent-plugin/050eebf746e2f8b33a5430d234613d13439dd8d7 Log: JENKINS-28689 Included javadocs to explain that these SerialVersionUID was generated from 1.7

          Code changed in jenkins
          User: Stephen Connolly
          Path:
          pom.xml
          src/main/java/com/cloudbees/jenkins/plugins/sshagent/SSHAgentBuildWrapper.java
          src/main/java/com/cloudbees/jenkins/plugins/sshagent/SSHAgentStep.java
          src/main/java/com/cloudbees/jenkins/plugins/sshagent/SSHAgentStepExecution.java
          src/main/java/com/cloudbees/jenkins/plugins/sshagent/jna/JNRRemoteAgentStarter.java
          src/main/java/com/cloudbees/jenkins/plugins/sshagent/mina/MinaRemoteAgentFactory.java
          src/main/java/com/cloudbees/jenkins/plugins/sshagent/mina/MinaRemoteAgentStarter.java
          src/main/resources/com/cloudbees/jenkins/plugins/sshagent/SSHAgentBuildWrapper/config.jelly
          src/main/resources/com/cloudbees/jenkins/plugins/sshagent/SSHAgentStep/config.jelly
          src/main/resources/com/cloudbees/jenkins/plugins/sshagent/SSHAgentStep/help.html
          src/test/java/com/cloudbees/jenkins/plugins/sshagent/SSHAgentBase.java
          src/test/java/com/cloudbees/jenkins/plugins/sshagent/SSHAgentBuildWrapperTest.java
          src/test/java/com/cloudbees/jenkins/plugins/sshagent/SSHAgentStepWorkflowTest.java
          http://jenkins-ci.org/commit/ssh-agent-plugin/5a72bf85a7ec500e8e3a80ac60690da4be03e077
          Log:
          Merge pull request #4 from recena/JENKINS-28689

          JENKINS-28689 Make compatible with Workflow plugin

          Compare: https://github.com/jenkinsci/ssh-agent-plugin/compare/7c398955f660...5a72bf85a7ec

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Stephen Connolly Path: pom.xml src/main/java/com/cloudbees/jenkins/plugins/sshagent/SSHAgentBuildWrapper.java src/main/java/com/cloudbees/jenkins/plugins/sshagent/SSHAgentStep.java src/main/java/com/cloudbees/jenkins/plugins/sshagent/SSHAgentStepExecution.java src/main/java/com/cloudbees/jenkins/plugins/sshagent/jna/JNRRemoteAgentStarter.java src/main/java/com/cloudbees/jenkins/plugins/sshagent/mina/MinaRemoteAgentFactory.java src/main/java/com/cloudbees/jenkins/plugins/sshagent/mina/MinaRemoteAgentStarter.java src/main/resources/com/cloudbees/jenkins/plugins/sshagent/SSHAgentBuildWrapper/config.jelly src/main/resources/com/cloudbees/jenkins/plugins/sshagent/SSHAgentStep/config.jelly src/main/resources/com/cloudbees/jenkins/plugins/sshagent/SSHAgentStep/help.html src/test/java/com/cloudbees/jenkins/plugins/sshagent/SSHAgentBase.java src/test/java/com/cloudbees/jenkins/plugins/sshagent/SSHAgentBuildWrapperTest.java src/test/java/com/cloudbees/jenkins/plugins/sshagent/SSHAgentStepWorkflowTest.java http://jenkins-ci.org/commit/ssh-agent-plugin/5a72bf85a7ec500e8e3a80ac60690da4be03e077 Log: Merge pull request #4 from recena/ JENKINS-28689 JENKINS-28689 Make compatible with Workflow plugin Compare: https://github.com/jenkinsci/ssh-agent-plugin/compare/7c398955f660...5a72bf85a7ec

          This feature will be released coming soon.

          Manuel Recena Soto added a comment - This feature will be released coming soon.

          Code changed in jenkins
          User: Jesse Glick
          Path:
          COMPATIBILITY.md
          http://jenkins-ci.org/commit/workflow-plugin/4f5e0afa6bd5dff7f9d64c4a4dd1af814b6c37bc
          Log:
          JENKINS-28689 Noting release of ssh-agent 1.8.

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: COMPATIBILITY.md http://jenkins-ci.org/commit/workflow-plugin/4f5e0afa6bd5dff7f9d64c4a4dd1af814b6c37bc Log: JENKINS-28689 Noting release of ssh-agent 1.8.

            recena Manuel Recena Soto
            jglick Jesse Glick
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

              Created:
              Updated:
              Resolved: