Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-28697

Aborted job is marked as SUCCESS if "Wait for Rundeck" is used

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed (View Workflow)
    • Priority: Major
    • Resolution: Fixed
    • Component/s: rundeck-plugin
    • Labels:
      None
    • Environment:
      Rundeck plugin 3.4
    • Similar Issues:

      Description

      Looking at the code (RundeckNotifier) if "sleep(5000)" is interupted ("Oops, interrupted !" is in a log) the while loop is finished and current Rundeck job execution status is RUNNING. It causes that switch..case hits "default" and the whole job is marked as SUCESS.

        Attachments

          Activity

          Hide
          emszpak Marcin Zajączkowski added a comment -
          Show
          emszpak Marcin Zajączkowski added a comment - Created corresponding PR: https://github.com/jenkinsci/rundeck-plugin/pull/16
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Marcin Zajaczkowski
          Path:
          .gitignore
          src/main/java/org/jenkinsci/plugins/rundeck/RundeckNotifier.java
          http://jenkins-ci.org/commit/rundeck-plugin/8d618fa14c4e7451c7e8202a9a906b6564d47f9f
          Log:
          JENKINS-28697 Aborted build is marked as FAILED

          Fixed treating aborted build as SUCCESS. In addition on
          a build abort there is a try to abort also Rundeck job.

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Marcin Zajaczkowski Path: .gitignore src/main/java/org/jenkinsci/plugins/rundeck/RundeckNotifier.java http://jenkins-ci.org/commit/rundeck-plugin/8d618fa14c4e7451c7e8202a9a906b6564d47f9f Log: JENKINS-28697 Aborted build is marked as FAILED Fixed treating aborted build as SUCCESS. In addition on a build abort there is a try to abort also Rundeck job.
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Marcin Zajaczkowski
          Path:
          pom.xml
          src/main/java/org/jenkinsci/plugins/rundeck/OptionProvider.java
          src/main/java/org/jenkinsci/plugins/rundeck/RunDeckLogTail.java
          src/main/java/org/jenkinsci/plugins/rundeck/RundeckNotifier.java
          src/main/java/org/jenkinsci/plugins/rundeck/WebHookListener.java
          src/main/resources/org/jenkinsci/plugins/rundeck/RundeckNotifier/config.jelly
          src/main/resources/org/jenkinsci/plugins/rundeck/RundeckNotifier/global.jelly
          src/main/resources/org/jenkinsci/plugins/rundeck/RundeckNotifier/help-shouldWaitForRundeckJob.html
          src/main/resources/org/jenkinsci/plugins/rundeck/RundeckNotifier/help-tailLog.html
          src/test/java/org/jenkinsci/plugins/rundeck/RunDeckLogTailTest.java
          src/test/java/org/jenkinsci/plugins/rundeck/RundeckNotifierBackwardCompatibilityTest.java
          src/test/java/org/jenkinsci/plugins/rundeck/RundeckNotifierTest.java
          src/test/resources/org/jenkinsci/plugins/rundeck/RundeckNotifierBackwardCompatibilityTest/config.xml
          src/test/resources/org/jenkinsci/plugins/rundeck/RundeckNotifierBackwardCompatibilityTest/jobs/old/config.xml
          src/test/resources/org/jenkinsci/plugins/rundeck/RundeckNotifierBackwardCompatibilityTest/org.jenkinsci.plugins.rundeck.RundeckNotifier.xml
          http://jenkins-ci.org/commit/rundeck-plugin/3c0f5410303420b5c232923d65dbd24f44df4fb5
          Log:
          Merge branch 'master' into JENKINS-28697-aborted-job

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Marcin Zajaczkowski Path: pom.xml src/main/java/org/jenkinsci/plugins/rundeck/OptionProvider.java src/main/java/org/jenkinsci/plugins/rundeck/RunDeckLogTail.java src/main/java/org/jenkinsci/plugins/rundeck/RundeckNotifier.java src/main/java/org/jenkinsci/plugins/rundeck/WebHookListener.java src/main/resources/org/jenkinsci/plugins/rundeck/RundeckNotifier/config.jelly src/main/resources/org/jenkinsci/plugins/rundeck/RundeckNotifier/global.jelly src/main/resources/org/jenkinsci/plugins/rundeck/RundeckNotifier/help-shouldWaitForRundeckJob.html src/main/resources/org/jenkinsci/plugins/rundeck/RundeckNotifier/help-tailLog.html src/test/java/org/jenkinsci/plugins/rundeck/RunDeckLogTailTest.java src/test/java/org/jenkinsci/plugins/rundeck/RundeckNotifierBackwardCompatibilityTest.java src/test/java/org/jenkinsci/plugins/rundeck/RundeckNotifierTest.java src/test/resources/org/jenkinsci/plugins/rundeck/RundeckNotifierBackwardCompatibilityTest/config.xml src/test/resources/org/jenkinsci/plugins/rundeck/RundeckNotifierBackwardCompatibilityTest/jobs/old/config.xml src/test/resources/org/jenkinsci/plugins/rundeck/RundeckNotifierBackwardCompatibilityTest/org.jenkinsci.plugins.rundeck.RundeckNotifier.xml http://jenkins-ci.org/commit/rundeck-plugin/3c0f5410303420b5c232923d65dbd24f44df4fb5 Log: Merge branch 'master' into JENKINS-28697 -aborted-job
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Marcin Zajaczkowski
          Path:
          src/main/java/org/jenkinsci/plugins/rundeck/RundeckNotifier.java
          http://jenkins-ci.org/commit/rundeck-plugin/ccd1f3fbba07a754ceb0989c7b4223e98fb4bbae
          Log:
          JENKINS-28697 Refactor code merged from upstream

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Marcin Zajaczkowski Path: src/main/java/org/jenkinsci/plugins/rundeck/RundeckNotifier.java http://jenkins-ci.org/commit/rundeck-plugin/ccd1f3fbba07a754ceb0989c7b4223e98fb4bbae Log: JENKINS-28697 Refactor code merged from upstream
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Greg Schueler
          Path:
          .gitignore
          src/main/java/org/jenkinsci/plugins/rundeck/RundeckNotifier.java
          http://jenkins-ci.org/commit/rundeck-plugin/5acdd8b82b30c1aa278912bccf31ac15a4f16be2
          Log:
          Merge pull request #16 from szpak/JENKINS-28697-aborted-job

          JENKINS-28697 Aborted build is marked as FAILED

          Compare: https://github.com/jenkinsci/rundeck-plugin/compare/63984a833797...5acdd8b82b30

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Greg Schueler Path: .gitignore src/main/java/org/jenkinsci/plugins/rundeck/RundeckNotifier.java http://jenkins-ci.org/commit/rundeck-plugin/5acdd8b82b30c1aa278912bccf31ac15a4f16be2 Log: Merge pull request #16 from szpak/ JENKINS-28697 -aborted-job JENKINS-28697 Aborted build is marked as FAILED Compare: https://github.com/jenkinsci/rundeck-plugin/compare/63984a833797...5acdd8b82b30
          Hide
          dserodio Daniel Serodio added a comment -

          Closing since https://github.com/jenkinsci/rundeck-plugin/pull/16 was merged and version 3.5.4 of the plugin released.

          Show
          dserodio Daniel Serodio added a comment - Closing since https://github.com/jenkinsci/rundeck-plugin/pull/16 was merged and version 3.5.4 of the plugin released.

            People

            Assignee:
            vbehar Vincent Behar
            Reporter:
            emszpak Marcin Zajączkowski
            Votes:
            1 Vote for this issue
            Watchers:
            3 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved: