Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-28928

Make XvfbBuildWrapper extend SimpleBuildWrapper

    • Icon: New Feature New Feature
    • Resolution: Fixed
    • Icon: Major Major
    • xvfb-plugin

      This would make it available from Workflow scripts. See https://github.com/jenkinsci/xvnc-plugin/pull/5 for an example.

          [JENKINS-28928] Make XvfbBuildWrapper extend SimpleBuildWrapper

          Code changed in jenkins
          User: Jesse Glick
          Path:
          COMPATIBILITY.md
          http://jenkins-ci.org/commit/workflow-plugin/f9bfa0bc66173e68df7d061aa636db2b42db6633
          Log:
          JENKINS-28928 Noting.

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: COMPATIBILITY.md http://jenkins-ci.org/commit/workflow-plugin/f9bfa0bc66173e68df7d061aa636db2b42db6633 Log: JENKINS-28928 Noting.

          Code changed in jenkins
          User: Zoran Regvart
          Path:
          pom.xml
          src/main/java/org/jenkinsci/plugins/xvfb/XvfbBuildWrapper.java
          src/main/java/org/jenkinsci/plugins/xvfb/XvfbDisposer.java
          src/main/java/org/jenkinsci/plugins/xvfb/XvfbEnvironment.java
          src/main/java/org/jenkinsci/plugins/xvfb/XvfbEnvironmentConverter.java
          src/test/java/org/jenkinsci/plugins/xvfb/BaseXvfbTest.java
          src/test/java/org/jenkinsci/plugins/xvfb/XvfbBuildWrapperTest.java
          src/test/java/org/jenkinsci/plugins/xvfb/XvfbBuildWrapperWorkflowTest.java
          http://jenkins-ci.org/commit/xvfb-plugin/3a5ca77a855f2f75ff19a4e830caf579a8009bdd
          Log:
          JENKINS-28928 Make XvfbBuildWrapper extend SimpleBuildWrapper

          This implements support for Workflow job type in Jenkins. Couple of
          things had to be changed:

          • The XvfbBuildWrapper is now based on SimpleBuildWrapper
          • The Disposer was implemented to shutdown Xvfb on job end for
            traditional jobs, and on block end for workflow jobs
          • the XvfbEnvironment, InvisibleAction was made Serializable in order to
            survive workflow job interruptions
          • shutdown in regular and zombie cleanup cases is now based on a cookie
            value (random UUID) placed in environment when starting Xvfb

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Zoran Regvart Path: pom.xml src/main/java/org/jenkinsci/plugins/xvfb/XvfbBuildWrapper.java src/main/java/org/jenkinsci/plugins/xvfb/XvfbDisposer.java src/main/java/org/jenkinsci/plugins/xvfb/XvfbEnvironment.java src/main/java/org/jenkinsci/plugins/xvfb/XvfbEnvironmentConverter.java src/test/java/org/jenkinsci/plugins/xvfb/BaseXvfbTest.java src/test/java/org/jenkinsci/plugins/xvfb/XvfbBuildWrapperTest.java src/test/java/org/jenkinsci/plugins/xvfb/XvfbBuildWrapperWorkflowTest.java http://jenkins-ci.org/commit/xvfb-plugin/3a5ca77a855f2f75ff19a4e830caf579a8009bdd Log: JENKINS-28928 Make XvfbBuildWrapper extend SimpleBuildWrapper This implements support for Workflow job type in Jenkins. Couple of things had to be changed: The XvfbBuildWrapper is now based on SimpleBuildWrapper The Disposer was implemented to shutdown Xvfb on job end for traditional jobs, and on block end for workflow jobs the XvfbEnvironment, InvisibleAction was made Serializable in order to survive workflow job interruptions shutdown in regular and zombie cleanup cases is now based on a cookie value (random UUID) placed in environment when starting Xvfb

          zregvart added a comment -

          This has been implemented and released to the experimental update center in version 1.1.0-beta-1. There are a few kinks I wish to investigate further:

          • renaming the XvfbBuildWrapper to Xvfb to make workflow script less verbose
          • implementing test cases for zombie termination
          • using some default Xvfb tool installation, also to make workflow scripts less verbose

          zregvart added a comment - This has been implemented and released to the experimental update center in version 1.1.0-beta-1. There are a few kinks I wish to investigate further: renaming the XvfbBuildWrapper to Xvfb to make workflow script less verbose implementing test cases for zombie termination using some default Xvfb tool installation, also to make workflow scripts less verbose

          Code changed in jenkins
          User: Jesse Glick
          Path:
          COMPATIBILITY.md
          http://jenkins-ci.org/commit/workflow-plugin/4b7a12287d9bf5401c57378513814e0af3482585
          Log:
          JENKINS-28928 Noting.

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: COMPATIBILITY.md http://jenkins-ci.org/commit/workflow-plugin/4b7a12287d9bf5401c57378513814e0af3482585 Log: JENKINS-28928 Noting.

          zregvart Any chance to make a final 1.1 release anytime soon? I'm so looking forward to give it a try!

          Timo Stollenwerk added a comment - zregvart Any chance to make a final 1.1 release anytime soon? I'm so looking forward to give it a try!

          Jesse Glick added a comment -

          You should be able to install 1.1.0-beta-1 from the experimental update center already.

          Jesse Glick added a comment - You should be able to install 1.1.0-beta-1 from the experimental update center already.

          zregvart added a comment -

          The 1.1.0 version is available with workflow support in the update center.

          zregvart added a comment - The 1.1.0 version is available with workflow support in the update center.

          Awesome! Thanks for your work!

          Timo Stollenwerk added a comment - Awesome! Thanks for your work!

          zregvart added a comment -

          Closing old issues

          zregvart added a comment - Closing old issues

            zregvart zregvart
            jglick Jesse Glick
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

              Created:
              Updated:
              Resolved: